[ML] Fix model deployment check in file uploader#209585
Merged
jgowdyelastic merged 7 commits intoelastic:mainfrom Feb 11, 2025
Merged
[ML] Fix model deployment check in file uploader#209585jgowdyelastic merged 7 commits intoelastic:mainfrom
jgowdyelastic merged 7 commits intoelastic:mainfrom
Conversation
…check-in-file-uploader
…com:jgowdyelastic/kibana into fix-model-allocation-check-in-file-uploader
jgowdyelastic
changed the title
jgowdyelastic
added
:ml
Feature:File and Index Data Viz
Contributor
|
Pinging @elastic/ml-ui (:ml) |
jgowdyelastic
added
the
release_note:skip
peteharverson
approved these changes
Feb 7, 2025
Contributor
peteharverson
left a comment
peteharverson
left a comment
There was a problem hiding this comment.
Tested using your instructions and LGTM. No longer see any uploads stalling.
jgowdyelastic
requested review from
peteharverson and
qn895
and removed request for
alvarezmelissa87
peteharverson
approved these changes
Feb 11, 2025
Contributor
|
Starting backport for target branches: 8.18, 8.x, 9.0 https://github.com/elastic/kibana/actions/runs/13268591262 |
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 11, 2025
Adding an additional check to see if the selected model has been
deployed before continuing with the upload.
The `num_allocations` count can occasionally be incorrect, so this also
checks to see if the initial call to the inference api has returned with
no error. If it has, the model must be deployed.
To test:
Manually deploy both `.elser_model_2` and `.multilingual-e5-small` in
ML's trained models page.
In dev tools call:
```
POST /_inference/.multilingual-e5-small-elasticsearch
{
"input": ""
}
```
then call:
```
POST /_inference/.elser-2-elasticsearch
{
"input": ""
}
```
Once both models have been deployed, check the `num_allocations` of
`.elser-2-elasticsearch`
```
GET /_inference/.elser-2-elasticsearch
```
It should be `0` even though the model has been deployed.
If it isn't `0`. wait around 15mins for both models to scale down then
repeat the dev tools commands.
Call this to check `num_allocations ` in both models.
```
GET /_inference/_all
```
(cherry picked from commit 06801d8)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 11, 2025
Adding an additional check to see if the selected model has been
deployed before continuing with the upload.
The `num_allocations` count can occasionally be incorrect, so this also
checks to see if the initial call to the inference api has returned with
no error. If it has, the model must be deployed.
To test:
Manually deploy both `.elser_model_2` and `.multilingual-e5-small` in
ML's trained models page.
In dev tools call:
```
POST /_inference/.multilingual-e5-small-elasticsearch
{
"input": ""
}
```
then call:
```
POST /_inference/.elser-2-elasticsearch
{
"input": ""
}
```
Once both models have been deployed, check the `num_allocations` of
`.elser-2-elasticsearch`
```
GET /_inference/.elser-2-elasticsearch
```
It should be `0` even though the model has been deployed.
If it isn't `0`. wait around 15mins for both models to scale down then
repeat the dev tools commands.
Call this to check `num_allocations ` in both models.
```
GET /_inference/_all
```
(cherry picked from commit 06801d8)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 11, 2025
Adding an additional check to see if the selected model has been
deployed before continuing with the upload.
The `num_allocations` count can occasionally be incorrect, so this also
checks to see if the initial call to the inference api has returned with
no error. If it has, the model must be deployed.
To test:
Manually deploy both `.elser_model_2` and `.multilingual-e5-small` in
ML's trained models page.
In dev tools call:
```
POST /_inference/.multilingual-e5-small-elasticsearch
{
"input": ""
}
```
then call:
```
POST /_inference/.elser-2-elasticsearch
{
"input": ""
}
```
Once both models have been deployed, check the `num_allocations` of
`.elser-2-elasticsearch`
```
GET /_inference/.elser-2-elasticsearch
```
It should be `0` even though the model has been deployed.
If it isn't `0`. wait around 15mins for both models to scale down then
repeat the dev tools commands.
Call this to check `num_allocations ` in both models.
```
GET /_inference/_all
```
(cherry picked from commit 06801d8)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Feb 11, 2025
…10644) # Backport This will backport the following commits from `main` to `8.18`: - [[ML] Fix model deployment check in file uploader (#209585)](#209585) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"James Gowdy","email":"jgowdy@elastic.co"},"sourceCommit":{"committedDate":"2025-02-11T17:14:31Z","message":"[ML] Fix model deployment check in file uploader (#209585)\n\nAdding an additional check to see if the selected model has been\r\ndeployed before continuing with the upload.\r\nThe `num_allocations` count can occasionally be incorrect, so this also\r\nchecks to see if the initial call to the inference api has returned with\r\nno error. If it has, the model must be deployed.\r\n\r\nTo test:\r\nManually deploy both `.elser_model_2` and `.multilingual-e5-small` in\r\nML's trained models page.\r\n\r\nIn dev tools call:\r\n```\r\nPOST /_inference/.multilingual-e5-small-elasticsearch\r\n{\r\n\"input\": \"\"\r\n}\r\n```\r\nthen call:\r\n```\r\nPOST /_inference/.elser-2-elasticsearch\r\n{\r\n\"input\": \"\"\r\n}\r\n```\r\nOnce both models have been deployed, check the `num_allocations` of\r\n`.elser-2-elasticsearch`\r\n```\r\nGET /_inference/.elser-2-elasticsearch\r\n```\r\n\r\nIt should be `0` even though the model has been deployed.\r\nIf it isn't `0`. wait around 15mins for both models to scale down then\r\nrepeat the dev tools commands.\r\nCall this to check `num_allocations ` in both models.\r\n```\r\nGET /_inference/_all\r\n```","sha":"06801d82fed6329368ffa0a817483ec4e4d0c251","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":[":ml","release_note:skip","Feature:File and Index Data Viz","Feature:File Upload","v9.0.0","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[ML] Fix model deployment check in file uploader","number":209585,"url":"https://github.com/elastic/kibana/pull/209585","mergeCommit":{"message":"[ML] Fix model deployment check in file uploader (#209585)\n\nAdding an additional check to see if the selected model has been\r\ndeployed before continuing with the upload.\r\nThe `num_allocations` count can occasionally be incorrect, so this also\r\nchecks to see if the initial call to the inference api has returned with\r\nno error. If it has, the model must be deployed.\r\n\r\nTo test:\r\nManually deploy both `.elser_model_2` and `.multilingual-e5-small` in\r\nML's trained models page.\r\n\r\nIn dev tools call:\r\n```\r\nPOST /_inference/.multilingual-e5-small-elasticsearch\r\n{\r\n\"input\": \"\"\r\n}\r\n```\r\nthen call:\r\n```\r\nPOST /_inference/.elser-2-elasticsearch\r\n{\r\n\"input\": \"\"\r\n}\r\n```\r\nOnce both models have been deployed, check the `num_allocations` of\r\n`.elser-2-elasticsearch`\r\n```\r\nGET /_inference/.elser-2-elasticsearch\r\n```\r\n\r\nIt should be `0` even though the model has been deployed.\r\nIf it isn't `0`. wait around 15mins for both models to scale down then\r\nrepeat the dev tools commands.\r\nCall this to check `num_allocations ` in both models.\r\n```\r\nGET /_inference/_all\r\n```","sha":"06801d82fed6329368ffa0a817483ec4e4d0c251"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/209585","number":209585,"mergeCommit":{"message":"[ML] Fix model deployment check in file uploader (#209585)\n\nAdding an additional check to see if the selected model has been\r\ndeployed before continuing with the upload.\r\nThe `num_allocations` count can occasionally be incorrect, so this also\r\nchecks to see if the initial call to the inference api has returned with\r\nno error. If it has, the model must be deployed.\r\n\r\nTo test:\r\nManually deploy both `.elser_model_2` and `.multilingual-e5-small` in\r\nML's trained models page.\r\n\r\nIn dev tools call:\r\n```\r\nPOST /_inference/.multilingual-e5-small-elasticsearch\r\n{\r\n\"input\": \"\"\r\n}\r\n```\r\nthen call:\r\n```\r\nPOST /_inference/.elser-2-elasticsearch\r\n{\r\n\"input\": \"\"\r\n}\r\n```\r\nOnce both models have been deployed, check the `num_allocations` of\r\n`.elser-2-elasticsearch`\r\n```\r\nGET /_inference/.elser-2-elasticsearch\r\n```\r\n\r\nIt should be `0` even though the model has been deployed.\r\nIf it isn't `0`. wait around 15mins for both models to scale down then\r\nrepeat the dev tools commands.\r\nCall this to check `num_allocations ` in both models.\r\n```\r\nGET /_inference/_all\r\n```","sha":"06801d82fed6329368ffa0a817483ec4e4d0c251"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: James Gowdy <jgowdy@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Feb 11, 2025
…0646) # Backport This will backport the following commits from `main` to `9.0`: - [[ML] Fix model deployment check in file uploader (#209585)](#209585) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"James Gowdy","email":"jgowdy@elastic.co"},"sourceCommit":{"committedDate":"2025-02-11T17:14:31Z","message":"[ML] Fix model deployment check in file uploader (#209585)\n\nAdding an additional check to see if the selected model has been\r\ndeployed before continuing with the upload.\r\nThe `num_allocations` count can occasionally be incorrect, so this also\r\nchecks to see if the initial call to the inference api has returned with\r\nno error. If it has, the model must be deployed.\r\n\r\nTo test:\r\nManually deploy both `.elser_model_2` and `.multilingual-e5-small` in\r\nML's trained models page.\r\n\r\nIn dev tools call:\r\n```\r\nPOST /_inference/.multilingual-e5-small-elasticsearch\r\n{\r\n\"input\": \"\"\r\n}\r\n```\r\nthen call:\r\n```\r\nPOST /_inference/.elser-2-elasticsearch\r\n{\r\n\"input\": \"\"\r\n}\r\n```\r\nOnce both models have been deployed, check the `num_allocations` of\r\n`.elser-2-elasticsearch`\r\n```\r\nGET /_inference/.elser-2-elasticsearch\r\n```\r\n\r\nIt should be `0` even though the model has been deployed.\r\nIf it isn't `0`. wait around 15mins for both models to scale down then\r\nrepeat the dev tools commands.\r\nCall this to check `num_allocations ` in both models.\r\n```\r\nGET /_inference/_all\r\n```","sha":"06801d82fed6329368ffa0a817483ec4e4d0c251","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":[":ml","release_note:skip","Feature:File and Index Data Viz","Feature:File Upload","v9.0.0","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[ML] Fix model deployment check in file uploader","number":209585,"url":"https://github.com/elastic/kibana/pull/209585","mergeCommit":{"message":"[ML] Fix model deployment check in file uploader (#209585)\n\nAdding an additional check to see if the selected model has been\r\ndeployed before continuing with the upload.\r\nThe `num_allocations` count can occasionally be incorrect, so this also\r\nchecks to see if the initial call to the inference api has returned with\r\nno error. If it has, the model must be deployed.\r\n\r\nTo test:\r\nManually deploy both `.elser_model_2` and `.multilingual-e5-small` in\r\nML's trained models page.\r\n\r\nIn dev tools call:\r\n```\r\nPOST /_inference/.multilingual-e5-small-elasticsearch\r\n{\r\n\"input\": \"\"\r\n}\r\n```\r\nthen call:\r\n```\r\nPOST /_inference/.elser-2-elasticsearch\r\n{\r\n\"input\": \"\"\r\n}\r\n```\r\nOnce both models have been deployed, check the `num_allocations` of\r\n`.elser-2-elasticsearch`\r\n```\r\nGET /_inference/.elser-2-elasticsearch\r\n```\r\n\r\nIt should be `0` even though the model has been deployed.\r\nIf it isn't `0`. wait around 15mins for both models to scale down then\r\nrepeat the dev tools commands.\r\nCall this to check `num_allocations ` in both models.\r\n```\r\nGET /_inference/_all\r\n```","sha":"06801d82fed6329368ffa0a817483ec4e4d0c251"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/209585","number":209585,"mergeCommit":{"message":"[ML] Fix model deployment check in file uploader (#209585)\n\nAdding an additional check to see if the selected model has been\r\ndeployed before continuing with the upload.\r\nThe `num_allocations` count can occasionally be incorrect, so this also\r\nchecks to see if the initial call to the inference api has returned with\r\nno error. If it has, the model must be deployed.\r\n\r\nTo test:\r\nManually deploy both `.elser_model_2` and `.multilingual-e5-small` in\r\nML's trained models page.\r\n\r\nIn dev tools call:\r\n```\r\nPOST /_inference/.multilingual-e5-small-elasticsearch\r\n{\r\n\"input\": \"\"\r\n}\r\n```\r\nthen call:\r\n```\r\nPOST /_inference/.elser-2-elasticsearch\r\n{\r\n\"input\": \"\"\r\n}\r\n```\r\nOnce both models have been deployed, check the `num_allocations` of\r\n`.elser-2-elasticsearch`\r\n```\r\nGET /_inference/.elser-2-elasticsearch\r\n```\r\n\r\nIt should be `0` even though the model has been deployed.\r\nIf it isn't `0`. wait around 15mins for both models to scale down then\r\nrepeat the dev tools commands.\r\nCall this to check `num_allocations ` in both models.\r\n```\r\nGET /_inference/_all\r\n```","sha":"06801d82fed6329368ffa0a817483ec4e4d0c251"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: James Gowdy <jgowdy@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Feb 11, 2025
…0645) # Backport This will backport the following commits from `main` to `8.x`: - [[ML] Fix model deployment check in file uploader (#209585)](#209585) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"James Gowdy","email":"jgowdy@elastic.co"},"sourceCommit":{"committedDate":"2025-02-11T17:14:31Z","message":"[ML] Fix model deployment check in file uploader (#209585)\n\nAdding an additional check to see if the selected model has been\r\ndeployed before continuing with the upload.\r\nThe `num_allocations` count can occasionally be incorrect, so this also\r\nchecks to see if the initial call to the inference api has returned with\r\nno error. If it has, the model must be deployed.\r\n\r\nTo test:\r\nManually deploy both `.elser_model_2` and `.multilingual-e5-small` in\r\nML's trained models page.\r\n\r\nIn dev tools call:\r\n```\r\nPOST /_inference/.multilingual-e5-small-elasticsearch\r\n{\r\n\"input\": \"\"\r\n}\r\n```\r\nthen call:\r\n```\r\nPOST /_inference/.elser-2-elasticsearch\r\n{\r\n\"input\": \"\"\r\n}\r\n```\r\nOnce both models have been deployed, check the `num_allocations` of\r\n`.elser-2-elasticsearch`\r\n```\r\nGET /_inference/.elser-2-elasticsearch\r\n```\r\n\r\nIt should be `0` even though the model has been deployed.\r\nIf it isn't `0`. wait around 15mins for both models to scale down then\r\nrepeat the dev tools commands.\r\nCall this to check `num_allocations ` in both models.\r\n```\r\nGET /_inference/_all\r\n```","sha":"06801d82fed6329368ffa0a817483ec4e4d0c251","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":[":ml","release_note:skip","Feature:File and Index Data Viz","Feature:File Upload","v9.0.0","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[ML] Fix model deployment check in file uploader","number":209585,"url":"https://github.com/elastic/kibana/pull/209585","mergeCommit":{"message":"[ML] Fix model deployment check in file uploader (#209585)\n\nAdding an additional check to see if the selected model has been\r\ndeployed before continuing with the upload.\r\nThe `num_allocations` count can occasionally be incorrect, so this also\r\nchecks to see if the initial call to the inference api has returned with\r\nno error. If it has, the model must be deployed.\r\n\r\nTo test:\r\nManually deploy both `.elser_model_2` and `.multilingual-e5-small` in\r\nML's trained models page.\r\n\r\nIn dev tools call:\r\n```\r\nPOST /_inference/.multilingual-e5-small-elasticsearch\r\n{\r\n\"input\": \"\"\r\n}\r\n```\r\nthen call:\r\n```\r\nPOST /_inference/.elser-2-elasticsearch\r\n{\r\n\"input\": \"\"\r\n}\r\n```\r\nOnce both models have been deployed, check the `num_allocations` of\r\n`.elser-2-elasticsearch`\r\n```\r\nGET /_inference/.elser-2-elasticsearch\r\n```\r\n\r\nIt should be `0` even though the model has been deployed.\r\nIf it isn't `0`. wait around 15mins for both models to scale down then\r\nrepeat the dev tools commands.\r\nCall this to check `num_allocations ` in both models.\r\n```\r\nGET /_inference/_all\r\n```","sha":"06801d82fed6329368ffa0a817483ec4e4d0c251"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/209585","number":209585,"mergeCommit":{"message":"[ML] Fix model deployment check in file uploader (#209585)\n\nAdding an additional check to see if the selected model has been\r\ndeployed before continuing with the upload.\r\nThe `num_allocations` count can occasionally be incorrect, so this also\r\nchecks to see if the initial call to the inference api has returned with\r\nno error. If it has, the model must be deployed.\r\n\r\nTo test:\r\nManually deploy both `.elser_model_2` and `.multilingual-e5-small` in\r\nML's trained models page.\r\n\r\nIn dev tools call:\r\n```\r\nPOST /_inference/.multilingual-e5-small-elasticsearch\r\n{\r\n\"input\": \"\"\r\n}\r\n```\r\nthen call:\r\n```\r\nPOST /_inference/.elser-2-elasticsearch\r\n{\r\n\"input\": \"\"\r\n}\r\n```\r\nOnce both models have been deployed, check the `num_allocations` of\r\n`.elser-2-elasticsearch`\r\n```\r\nGET /_inference/.elser-2-elasticsearch\r\n```\r\n\r\nIt should be `0` even though the model has been deployed.\r\nIf it isn't `0`. wait around 15mins for both models to scale down then\r\nrepeat the dev tools commands.\r\nCall this to check `num_allocations ` in both models.\r\n```\r\nGET /_inference/_all\r\n```","sha":"06801d82fed6329368ffa0a817483ec4e4d0c251"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: James Gowdy <jgowdy@elastic.co>
kapral18
added a commit
to agusruidiazgd/kibana
that referenced
this pull request
Feb 11, 2025
…on-206439 * main: (402 commits) [Search]: Fix Number type field to have correct property (elastic#210462) Change filter for rule monitoring gaps (elastic#209983) Update Logs Explorer deprecation messages (elastic#201307) [APM] Remove `error.id` in `getErrorGroupMainStatistics` query as it's not used (elastic#210613) [Embeddable] Fix presentation panel styles (elastic#210113) [ci] enable Scout reporter for on-merge-unsupported-ftrs (elastic#210627) [Fix][Synonyms UI]Add navigation link to the Detail breadcrumb. (elastic#209574) chore(dep): bump `store2` from `2.12.0` to `2.14.4` (elastic#210530) [scout] adding test helper `@kbn/scout-oblt` package and uptate onboarding tests (elastic#209761) [Cloud Security] Asset Inventory table flyout controls (elastic#208452) [ML] Fix model deployment check in file uploader (elastic#209585) Updates archive again (elastic#209828) [Security Solution] Added concurrency limits and request throttling to prebuilt rule routes (elastic#209551) [Search] [Onboarding] Update search api to use EventEmitter instead of Provider (elastic#209784) [maps] lazy load map actions (elastic#210252) [Cloud Security] Adding telemetry collection condition based on render condition (elastic#208758) [Solution nav] Use flyout for Stack Management in Search and Observability solutions (elastic#208632) [Search] Fix Add Inference Endpoint API call (elastic#210243) [Agentless Connectors] Integration overview panel (elastic#210222) [Lens] Restore dynamic colouring by value for Last value agg (elastic#209110) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding an additional check to see if the selected model has been deployed before continuing with the upload.
The
num_allocationscount can occasionally be incorrect, so this also checks to see if the initial call to the inference api has returned with no error. If it has, the model must be deployed.To test:
Manually deploy both
.elser_model_2and.multilingual-e5-smallin ML's trained models page.In dev tools call:
then call:
Once both models have been deployed, check the
num_allocationsof.elser-2-elasticsearchIt should be
0even though the model has been deployed.If it isn't
0. wait around 15mins for both models to scale down then repeat the dev tools commands.Call this to check
num_allocationsin both models.