Skip to content

Conversation

@weronikaolejniczak
Copy link
Contributor

@weronikaolejniczak weronikaolejniczak commented Mar 31, 2025

Summary

Pipeline is failing at the linting stage on the PR: elastic/kibana#210082 because we're trying access init in undefined in the @elastic/eui/no-css-color.

Related to https://github.com/elastic/eui-private/issues/275

QA

  1. Checkout this branch: gh pr checkout 8524
  2. Build the ESLint plugin: yarn workspace @elastic/eslint-plugin-eui build
  3. Publish locally: cd packages/eslint-plugin && yalc publish

Then, in Kibana:

  1. Install the local ESLint plugin version: yalc add @elastic/eslint-plugin-eui
  2. Reinstall dependencies: yarn kbn bootstrap --no-validate

Test files:

  • src/platform/packages/shared/kbn-discover-utils/src/components/custom_control_columns/degraded_docs_control.tsx
  • src/platform/plugins/shared/console/public/application/containers/editor/editor.tsx
  • src/platform/plugins/shared/unified_search/public/saved_query_management/saved_query_management_list.tsx

There should be no errors in the ESLint output. Other warnings should display as appropriate.

@weronikaolejniczak weronikaolejniczak requested a review from a team as a code owner March 31, 2025 19:38
@weronikaolejniczak weronikaolejniczak added the skip-changelog Use on PRs to skip changelog requirement (Don't delete - used for automation) label Mar 31, 2025
@weronikaolejniczak weronikaolejniczak changed the title Fix/eslint plugin no css color fix(eslint-plugin): add optional chaining in no_css_color Mar 31, 2025
@weronikaolejniczak weronikaolejniczak self-assigned this Mar 31, 2025
@weronikaolejniczak weronikaolejniczak enabled auto-merge (squash) March 31, 2025 19:59
@kibanamachine
Copy link

Preview staging links for this PR:

@weronikaolejniczak weronikaolejniczak merged commit 23a83a1 into elastic:main Mar 31, 2025
7 of 8 checks passed
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @weronikaolejniczak

@weronikaolejniczak weronikaolejniczak deleted the fix/eslint-plugin-no-css-color branch April 16, 2025 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog Use on PRs to skip changelog requirement (Don't delete - used for automation)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants