Skip to content

[8.18] [Custom threshold] Fix using data view runtime fields during rule execution for the custom threshold rule (#209133)#209253

Merged
kibanamachine merged 4 commits intoelastic:8.18from
kibanamachine:backport/8.18/pr-209133
Feb 4, 2025
Merged

[8.18] [Custom threshold] Fix using data view runtime fields during rule execution for the custom threshold rule (#209133)#209253
kibanamachine merged 4 commits intoelastic:8.18from
kibanamachine:backport/8.18/pr-209133

Conversation

@kibanamachine
Copy link
Copy Markdown
Contributor

Backport

This will backport the following commits from main to 8.18:

Questions ?

Please refer to the Backport tool documentation

…cution for the custom threshold rule (elastic#209133)

Fixes elastic#200772

## 🐉  Summary

This PR fixes supporting data view runtime fields during rule execution
for the custom threshold rule.

## 🧪 How to test

1. Create a runtime field as shown below:

    |Runtime field| Preview|
    |---|---|

|![Image](https://github.com/user-attachments/assets/09fc0754-8944-486e-bf85-10b3f3464d17)|![Image](https://github.com/user-attachments/assets/e93efad5-bc3b-4306-b820-8b096dbba360)|

2. Make sure alerts are generated as expected both for regular and
no-data alerts:

![image](https://github.com/user-attachments/assets/a2174e40-11a4-4d75-8500-bfce126ba7cd)

### TODO
- [x] Add an API integration test
    - [x] Test on MKI

(cherry picked from commit 8fe5738)
@kibanamachine kibanamachine added the backport This PR is a backport of another PR label Feb 3, 2025
@kibanamachine kibanamachine enabled auto-merge (squash) February 3, 2025 11:15
@botelastic botelastic bot added the Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. label Feb 3, 2025
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Feb 3, 2025

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #84 / Stateful Observability - Deployment-agnostic API integration tests Observability Alerting Custom Threshold rule CARDINALITY - RUNTIME FIELD - FIRED Rule creation should set correct action variables
  • [job] [logs] FTR Configs #84 / Stateful Observability - Deployment-agnostic API integration tests Observability Alerting Custom Threshold rule CARDINALITY - RUNTIME FIELD - FIRED Rule creation should set correct action variables

Metrics [docs]

✅ unchanged

History

cc @maryam-saeidi

…lity/alerting/custom_threshold/cardinality_runtime_field_fired.ts


Fix checking the locator
@kibanamachine kibanamachine merged commit 4792470 into elastic:8.18 Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants