[Custom threshold] Fix using data view runtime fields during rule execution for the custom threshold rule#209133
Merged
maryam-saeidi merged 6 commits intoelastic:mainfrom Feb 3, 2025
Conversation
botelastic
bot
added
the
Team:actionable-obs
Contributor
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
maryam-saeidi
added
the
bug
maryam-saeidi
changed the title
dmlemeshko
approved these changes
Jan 31, 2025
Contributor
dmlemeshko
left a comment
dmlemeshko
left a comment
There was a problem hiding this comment.
x-pack/test/api_integration/deployment_agnostic/services/data_view_api.ts changes LGTM
maryam-saeidi
added
the
ci:project-deploy-observability
Contributor
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
maryam-saeidi
added
ci:project-deploy-observability
Contributor
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
Contributor
💚 Build Succeeded
Metrics [docs]
History |
Contributor
|
Starting backport for target branches: 8.16, 8.17, 8.18, 8.x https://github.com/elastic/kibana/actions/runs/13112145461 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 3, 2025
…cution for the custom threshold rule (elastic#209133) Fixes elastic#200772 ## 🐉 Summary This PR fixes supporting data view runtime fields during rule execution for the custom threshold rule. ## 🧪 How to test 1. Create a runtime field as shown below: |Runtime field| Preview| |---|---| ||| 2. Make sure alerts are generated as expected both for regular and no-data alerts:  ### TODO - [x] Add an API integration test - [x] Test on MKI (cherry picked from commit 8fe5738)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 3, 2025
…cution for the custom threshold rule (elastic#209133) Fixes elastic#200772 ## 🐉 Summary This PR fixes supporting data view runtime fields during rule execution for the custom threshold rule. ## 🧪 How to test 1. Create a runtime field as shown below: |Runtime field| Preview| |---|---| ||| 2. Make sure alerts are generated as expected both for regular and no-data alerts:  ### TODO - [x] Add an API integration test - [x] Test on MKI (cherry picked from commit 8fe5738)
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
maryam-saeidi
added a commit
to maryam-saeidi/kibana
that referenced
this pull request
Feb 3, 2025
…cution for the custom threshold rule (elastic#209133) Fixes elastic#200772 ## 🐉 Summary This PR fixes supporting data view runtime fields during rule execution for the custom threshold rule. ## 🧪 How to test 1. Create a runtime field as shown below: |Runtime field| Preview| |---|---| ||| 2. Make sure alerts are generated as expected both for regular and no-data alerts:  ### TODO - [x] Add an API integration test - [x] Test on MKI (cherry picked from commit 8fe5738) # Conflicts: # x-pack/plugins/observability_solution/observability/server/lib/rules/custom_threshold/lib/is_populated_object.test.ts # x-pack/plugins/observability_solution/observability/server/lib/rules/custom_threshold/lib/is_populated_object.ts
Member
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
maryam-saeidi
added a commit
to maryam-saeidi/kibana
that referenced
this pull request
Feb 3, 2025
…cution for the custom threshold rule (elastic#209133) Fixes elastic#200772 ## 🐉 Summary This PR fixes supporting data view runtime fields during rule execution for the custom threshold rule. ## 🧪 How to test 1. Create a runtime field as shown below: |Runtime field| Preview| |---|---| ||| 2. Make sure alerts are generated as expected both for regular and no-data alerts:  ### TODO - [x] Add an API integration test - [x] Test on MKI (cherry picked from commit 8fe5738) # Conflicts: # x-pack/plugins/observability_solution/observability/server/lib/rules/custom_threshold/lib/is_populated_object.test.ts # x-pack/plugins/observability_solution/observability/server/lib/rules/custom_threshold/lib/is_populated_object.ts # x-pack/test/api_integration/deployment_agnostic/services/data_view_api.ts # x-pack/test_serverless/api_integration/test_suites/observability/custom_threshold_rule/cardinality_runtime_field_fired.ts # x-pack/test_serverless/api_integration/test_suites/observability/custom_threshold_rule/index.ts
Member
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
4 tasks
kibanamachine
added a commit
that referenced
this pull request
Feb 4, 2025
…ule execution for the custom threshold rule (#209133) (#209253) # Backport This will backport the following commits from `main` to `8.18`: - [[Custom threshold] Fix using data view runtime fields during rule execution for the custom threshold rule (#209133)](#209133) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Maryam Saeidi","email":"maryam.saeidi@elastic.co"},"sourceCommit":{"committedDate":"2025-02-03T11:09:29Z","message":"[Custom threshold] Fix using data view runtime fields during rule execution for the custom threshold rule (#209133)\n\nFixes #200772\r\n\r\n## 🐉 Summary\r\n\r\n\r\nThis PR fixes supporting data view runtime fields during rule execution\r\nfor the custom threshold rule.\r\n\r\n## 🧪 How to test\r\n\r\n1. Create a runtime field as shown below:\r\n\r\n |Runtime field| Preview|\r\n |---|---|\r\n\r\n|||\r\n\r\n2. Make sure alerts are generated as expected both for regular and\r\nno-data alerts:\r\n\r\n\r\n\r\n### TODO\r\n- [x] Add an API integration test\r\n - [x] Test on MKI","sha":"8fe5738b24048972f801dc96e243d5a3d5d72eb3","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","backport:prev-major","ci:project-deploy-observability","Team:obs-ux-management","v9.1.0"],"title":"[Custom threshold] Fix using data view runtime fields during rule execution for the custom threshold rule","number":209133,"url":"https://github.com/elastic/kibana/pull/209133","mergeCommit":{"message":"[Custom threshold] Fix using data view runtime fields during rule execution for the custom threshold rule (#209133)\n\nFixes #200772\r\n\r\n## 🐉 Summary\r\n\r\n\r\nThis PR fixes supporting data view runtime fields during rule execution\r\nfor the custom threshold rule.\r\n\r\n## 🧪 How to test\r\n\r\n1. Create a runtime field as shown below:\r\n\r\n |Runtime field| Preview|\r\n |---|---|\r\n\r\n|||\r\n\r\n2. Make sure alerts are generated as expected both for regular and\r\nno-data alerts:\r\n\r\n\r\n\r\n### TODO\r\n- [x] Add an API integration test\r\n - [x] Test on MKI","sha":"8fe5738b24048972f801dc96e243d5a3d5d72eb3"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/209133","number":209133,"mergeCommit":{"message":"[Custom threshold] Fix using data view runtime fields during rule execution for the custom threshold rule (#209133)\n\nFixes #200772\r\n\r\n## 🐉 Summary\r\n\r\n\r\nThis PR fixes supporting data view runtime fields during rule execution\r\nfor the custom threshold rule.\r\n\r\n## 🧪 How to test\r\n\r\n1. Create a runtime field as shown below:\r\n\r\n |Runtime field| Preview|\r\n |---|---|\r\n\r\n|||\r\n\r\n2. Make sure alerts are generated as expected both for regular and\r\nno-data alerts:\r\n\r\n\r\n\r\n### TODO\r\n- [x] Add an API integration test\r\n - [x] Test on MKI","sha":"8fe5738b24048972f801dc96e243d5a3d5d72eb3"}}]}] BACKPORT--> --------- Co-authored-by: Maryam Saeidi <maryam.saeidi@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Feb 4, 2025
…le execution for the custom threshold rule (#209133) (#209254) # Backport This will backport the following commits from `main` to `8.x`: - [[Custom threshold] Fix using data view runtime fields during rule execution for the custom threshold rule (#209133)](#209133) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Maryam Saeidi","email":"maryam.saeidi@elastic.co"},"sourceCommit":{"committedDate":"2025-02-03T11:09:29Z","message":"[Custom threshold] Fix using data view runtime fields during rule execution for the custom threshold rule (#209133)\n\nFixes #200772\r\n\r\n## 🐉 Summary\r\n\r\n\r\nThis PR fixes supporting data view runtime fields during rule execution\r\nfor the custom threshold rule.\r\n\r\n## 🧪 How to test\r\n\r\n1. Create a runtime field as shown below:\r\n\r\n |Runtime field| Preview|\r\n |---|---|\r\n\r\n|||\r\n\r\n2. Make sure alerts are generated as expected both for regular and\r\nno-data alerts:\r\n\r\n\r\n\r\n### TODO\r\n- [x] Add an API integration test\r\n - [x] Test on MKI","sha":"8fe5738b24048972f801dc96e243d5a3d5d72eb3","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","backport:prev-major","ci:project-deploy-observability","Team:obs-ux-management","v9.1.0"],"title":"[Custom threshold] Fix using data view runtime fields during rule execution for the custom threshold rule","number":209133,"url":"https://github.com/elastic/kibana/pull/209133","mergeCommit":{"message":"[Custom threshold] Fix using data view runtime fields during rule execution for the custom threshold rule (#209133)\n\nFixes #200772\r\n\r\n## 🐉 Summary\r\n\r\n\r\nThis PR fixes supporting data view runtime fields during rule execution\r\nfor the custom threshold rule.\r\n\r\n## 🧪 How to test\r\n\r\n1. Create a runtime field as shown below:\r\n\r\n |Runtime field| Preview|\r\n |---|---|\r\n\r\n|||\r\n\r\n2. Make sure alerts are generated as expected both for regular and\r\nno-data alerts:\r\n\r\n\r\n\r\n### TODO\r\n- [x] Add an API integration test\r\n - [x] Test on MKI","sha":"8fe5738b24048972f801dc96e243d5a3d5d72eb3"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/209133","number":209133,"mergeCommit":{"message":"[Custom threshold] Fix using data view runtime fields during rule execution for the custom threshold rule (#209133)\n\nFixes #200772\r\n\r\n## 🐉 Summary\r\n\r\n\r\nThis PR fixes supporting data view runtime fields during rule execution\r\nfor the custom threshold rule.\r\n\r\n## 🧪 How to test\r\n\r\n1. Create a runtime field as shown below:\r\n\r\n |Runtime field| Preview|\r\n |---|---|\r\n\r\n|||\r\n\r\n2. Make sure alerts are generated as expected both for regular and\r\nno-data alerts:\r\n\r\n\r\n\r\n### TODO\r\n- [x] Add an API integration test\r\n - [x] Test on MKI","sha":"8fe5738b24048972f801dc96e243d5a3d5d72eb3"}}]}] BACKPORT--> --------- Co-authored-by: Maryam Saeidi <maryam.saeidi@elastic.co>
maryam-saeidi
added a commit
that referenced
this pull request
Feb 4, 2025
…ule execution for the custom threshold rule (#209133) (#209280) # Backport This will backport the following commits from `main` to `8.17`: - [[Custom threshold] Fix using data view runtime fields during rule execution for the custom threshold rule (#209133)](#209133) <!--- Backport version: 9.6.4 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Maryam Saeidi","email":"maryam.saeidi@elastic.co"},"sourceCommit":{"committedDate":"2025-02-03T11:09:29Z","message":"[Custom threshold] Fix using data view runtime fields during rule execution for the custom threshold rule (#209133)\n\nFixes #200772\r\n\r\n## 🐉 Summary\r\n\r\n\r\nThis PR fixes supporting data view runtime fields during rule execution\r\nfor the custom threshold rule.\r\n\r\n## 🧪 How to test\r\n\r\n1. Create a runtime field as shown below:\r\n\r\n |Runtime field| Preview|\r\n |---|---|\r\n\r\n|||\r\n\r\n2. Make sure alerts are generated as expected both for regular and\r\nno-data alerts:\r\n\r\n\r\n\r\n### TODO\r\n- [x] Add an API integration test\r\n - [x] Test on MKI","sha":"8fe5738b24048972f801dc96e243d5a3d5d72eb3","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","backport:prev-major","ci:project-deploy-observability","Team:obs-ux-management","v9.1.0"],"title":"[Custom threshold] Fix using data view runtime fields during rule execution for the custom threshold rule","number":209133,"url":"https://github.com/elastic/kibana/pull/209133","mergeCommit":{"message":"[Custom threshold] Fix using data view runtime fields during rule execution for the custom threshold rule (#209133)\n\nFixes #200772\r\n\r\n## 🐉 Summary\r\n\r\n\r\nThis PR fixes supporting data view runtime fields during rule execution\r\nfor the custom threshold rule.\r\n\r\n## 🧪 How to test\r\n\r\n1. Create a runtime field as shown below:\r\n\r\n |Runtime field| Preview|\r\n |---|---|\r\n\r\n|||\r\n\r\n2. Make sure alerts are generated as expected both for regular and\r\nno-data alerts:\r\n\r\n\r\n\r\n### TODO\r\n- [x] Add an API integration test\r\n - [x] Test on MKI","sha":"8fe5738b24048972f801dc96e243d5a3d5d72eb3"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/209133","number":209133,"mergeCommit":{"message":"[Custom threshold] Fix using data view runtime fields during rule execution for the custom threshold rule (#209133)\n\nFixes #200772\r\n\r\n## 🐉 Summary\r\n\r\n\r\nThis PR fixes supporting data view runtime fields during rule execution\r\nfor the custom threshold rule.\r\n\r\n## 🧪 How to test\r\n\r\n1. Create a runtime field as shown below:\r\n\r\n |Runtime field| Preview|\r\n |---|---|\r\n\r\n|||\r\n\r\n2. Make sure alerts are generated as expected both for regular and\r\nno-data alerts:\r\n\r\n\r\n\r\n### TODO\r\n- [x] Add an API integration test\r\n - [x] Test on MKI","sha":"8fe5738b24048972f801dc96e243d5a3d5d72eb3"}},{"url":"https://github.com/elastic/kibana/pull/209253","number":209253,"branch":"8.18","state":"OPEN"},{"url":"https://github.com/elastic/kibana/pull/209254","number":209254,"branch":"8.x","state":"OPEN"}]}] BACKPORT-->
maryam-saeidi
added a commit
that referenced
this pull request
Feb 4, 2025
…ule execution for the custom threshold rule (#209133) (#209287) # Backport This will backport the following commits from `main` to `8.16`: - [[Custom threshold] Fix using data view runtime fields during rule execution for the custom threshold rule (#209133)](#209133) <!--- Backport version: 9.6.4 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Maryam Saeidi","email":"maryam.saeidi@elastic.co"},"sourceCommit":{"committedDate":"2025-02-03T11:09:29Z","message":"[Custom threshold] Fix using data view runtime fields during rule execution for the custom threshold rule (#209133)\n\nFixes #200772\r\n\r\n## 🐉 Summary\r\n\r\n\r\nThis PR fixes supporting data view runtime fields during rule execution\r\nfor the custom threshold rule.\r\n\r\n## 🧪 How to test\r\n\r\n1. Create a runtime field as shown below:\r\n\r\n |Runtime field| Preview|\r\n |---|---|\r\n\r\n|||\r\n\r\n2. Make sure alerts are generated as expected both for regular and\r\nno-data alerts:\r\n\r\n\r\n\r\n### TODO\r\n- [x] Add an API integration test\r\n - [x] Test on MKI","sha":"8fe5738b24048972f801dc96e243d5a3d5d72eb3","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","backport:prev-major","ci:project-deploy-observability","Team:obs-ux-management","v9.1.0"],"title":"[Custom threshold] Fix using data view runtime fields during rule execution for the custom threshold rule","number":209133,"url":"https://github.com/elastic/kibana/pull/209133","mergeCommit":{"message":"[Custom threshold] Fix using data view runtime fields during rule execution for the custom threshold rule (#209133)\n\nFixes #200772\r\n\r\n## 🐉 Summary\r\n\r\n\r\nThis PR fixes supporting data view runtime fields during rule execution\r\nfor the custom threshold rule.\r\n\r\n## 🧪 How to test\r\n\r\n1. Create a runtime field as shown below:\r\n\r\n |Runtime field| Preview|\r\n |---|---|\r\n\r\n|||\r\n\r\n2. Make sure alerts are generated as expected both for regular and\r\nno-data alerts:\r\n\r\n\r\n\r\n### TODO\r\n- [x] Add an API integration test\r\n - [x] Test on MKI","sha":"8fe5738b24048972f801dc96e243d5a3d5d72eb3"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/209133","number":209133,"mergeCommit":{"message":"[Custom threshold] Fix using data view runtime fields during rule execution for the custom threshold rule (#209133)\n\nFixes #200772\r\n\r\n## 🐉 Summary\r\n\r\n\r\nThis PR fixes supporting data view runtime fields during rule execution\r\nfor the custom threshold rule.\r\n\r\n## 🧪 How to test\r\n\r\n1. Create a runtime field as shown below:\r\n\r\n |Runtime field| Preview|\r\n |---|---|\r\n\r\n|||\r\n\r\n2. Make sure alerts are generated as expected both for regular and\r\nno-data alerts:\r\n\r\n\r\n\r\n### TODO\r\n- [x] Add an API integration test\r\n - [x] Test on MKI","sha":"8fe5738b24048972f801dc96e243d5a3d5d72eb3"}},{"url":"https://github.com/elastic/kibana/pull/209253","number":209253,"branch":"8.18","state":"OPEN"},{"url":"https://github.com/elastic/kibana/pull/209254","number":209254,"branch":"8.x","state":"OPEN"},{"url":"https://github.com/elastic/kibana/pull/209280","number":209280,"branch":"8.17","state":"OPEN"}]}] BACKPORT-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #200772
🐉 Summary
This PR fixes supporting data view runtime fields during rule execution for the custom threshold rule.
🧪 How to test
Create a runtime field as shown below:
Make sure alerts are generated as expected both for regular and no-data alerts:
TODO
How to run the test