[Bug] Agent-based deployment selections are not showing on prem for integrations with agentless as a deployment option#209350
Merged
seanrathier merged 2 commits intoelastic:mainfrom Feb 3, 2025
Conversation
seanrathier
added
release_note:skip
Contributor
|
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security) |
botelastic
bot
added
the
Team:Fleet
Contributor
|
Pinging @elastic/fleet (Team:Fleet) |
seanrathier
changed the title
maxcold
requested changes
Feb 3, 2025
Contributor
maxcold
left a comment
maxcold
left a comment
There was a problem hiding this comment.
This doesn't fix the problem entirely though, the preferred methods show only agentless supported options (direct and temp access key) when for agent-based we have 4 manual methods and one automated (eg. Cloudformation for AWS)
seanrathier
added
backport:prev-major
backport
maxcold
approved these changes
Feb 3, 2025
Contributor
|
tested after the second commit, now it's working as expected |
Contributor
|
Starting backport for target branches: 8.16, 8.17, 8.18, 8.x, 9.0 https://github.com/elastic/kibana/actions/runs/13122294462 |
Contributor
seanrathier
added
9.1 candidate
9.0 candidate
8.19 candidate
backport:version
Contributor
|
Starting backport for target branches: 8.16, 8.17, 8.18, 8.x, 9.0 https://github.com/elastic/kibana/actions/runs/13122500194 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 3, 2025
…ntegrations with agentless as a deployment option (elastic#209350) (cherry picked from commit dff20a6)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 3, 2025
…ntegrations with agentless as a deployment option (elastic#209350) (cherry picked from commit dff20a6)
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
seanrathier
added
backport:prev-minor
and removed
backport:version
Contributor
|
Starting backport for target branches: 9.0 https://github.com/elastic/kibana/actions/runs/13122601282 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 3, 2025
…ntegrations with agentless as a deployment option (elastic#209350) (cherry picked from commit dff20a6)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Feb 3, 2025
… for integrations with agentless as a deployment option (#209350) (#209415) # Backport This will backport the following commits from `main` to `8.x`: - [[Bug] Agent-based deployment selections are not showing on prem for integrations with agentless as a deployment option (#209350)](#209350) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"seanrathier","email":"sean.rathier@gmail.com"},"sourceCommit":{"committedDate":"2025-02-03T20:31:26Z","message":"[Bug] Agent-based deployment selections are not showing on prem for integrations with agentless as a deployment option (#209350)","sha":"dff20a63c48cfc89c740fd8b3eea47f29b15f79f","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","release_note:skip","Team:Fleet","Team:Cloud Security","backport:prev-minor","backport:prev-major","v9.1.0"],"title":"[Bug] Agent-based deployment selections are not showing on prem for integrations with agentless as a deployment option","number":209350,"url":"https://github.com/elastic/kibana/pull/209350","mergeCommit":{"message":"[Bug] Agent-based deployment selections are not showing on prem for integrations with agentless as a deployment option (#209350)","sha":"dff20a63c48cfc89c740fd8b3eea47f29b15f79f"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/209350","number":209350,"mergeCommit":{"message":"[Bug] Agent-based deployment selections are not showing on prem for integrations with agentless as a deployment option (#209350)","sha":"dff20a63c48cfc89c740fd8b3eea47f29b15f79f"}}]}] BACKPORT--> Co-authored-by: seanrathier <sean.rathier@gmail.com>
kibanamachine
added a commit
that referenced
this pull request
Feb 3, 2025
…m for integrations with agentless as a deployment option (#209350) (#209414) # Backport This will backport the following commits from `main` to `8.18`: - [[Bug] Agent-based deployment selections are not showing on prem for integrations with agentless as a deployment option (#209350)](#209350) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"seanrathier","email":"sean.rathier@gmail.com"},"sourceCommit":{"committedDate":"2025-02-03T20:31:26Z","message":"[Bug] Agent-based deployment selections are not showing on prem for integrations with agentless as a deployment option (#209350)","sha":"dff20a63c48cfc89c740fd8b3eea47f29b15f79f","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","release_note:skip","Team:Fleet","Team:Cloud Security","backport:prev-minor","backport:prev-major","v9.1.0"],"title":"[Bug] Agent-based deployment selections are not showing on prem for integrations with agentless as a deployment option","number":209350,"url":"https://github.com/elastic/kibana/pull/209350","mergeCommit":{"message":"[Bug] Agent-based deployment selections are not showing on prem for integrations with agentless as a deployment option (#209350)","sha":"dff20a63c48cfc89c740fd8b3eea47f29b15f79f"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/209350","number":209350,"mergeCommit":{"message":"[Bug] Agent-based deployment selections are not showing on prem for integrations with agentless as a deployment option (#209350)","sha":"dff20a63c48cfc89c740fd8b3eea47f29b15f79f"}}]}] BACKPORT--> Co-authored-by: seanrathier <sean.rathier@gmail.com>
kibanamachine
added a commit
that referenced
this pull request
Feb 3, 2025
… for integrations with agentless as a deployment option (#209350) (#209416) # Backport This will backport the following commits from `main` to `9.0`: - [[Bug] Agent-based deployment selections are not showing on prem for integrations with agentless as a deployment option (#209350)](#209350) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"seanrathier","email":"sean.rathier@gmail.com"},"sourceCommit":{"committedDate":"2025-02-03T20:31:26Z","message":"[Bug] Agent-based deployment selections are not showing on prem for integrations with agentless as a deployment option (#209350)","sha":"dff20a63c48cfc89c740fd8b3eea47f29b15f79f","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","release_note:skip","Team:Fleet","Team:Cloud Security","backport:prev-minor","backport:prev-major","v9.1.0"],"title":"[Bug] Agent-based deployment selections are not showing on prem for integrations with agentless as a deployment option","number":209350,"url":"https://github.com/elastic/kibana/pull/209350","mergeCommit":{"message":"[Bug] Agent-based deployment selections are not showing on prem for integrations with agentless as a deployment option (#209350)","sha":"dff20a63c48cfc89c740fd8b3eea47f29b15f79f"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/209350","number":209350,"mergeCommit":{"message":"[Bug] Agent-based deployment selections are not showing on prem for integrations with agentless as a deployment option (#209350)","sha":"dff20a63c48cfc89c740fd8b3eea47f29b15f79f"}}]}] BACKPORT--> Co-authored-by: seanrathier <sean.rathier@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes [Bug] Agent-based deployment selections are not showing on prem for integrations with agentless option
Before
After
Checklist
Identify risks
Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.
Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.