[EUI Visual Refresh][Security Gen AI] Add support for borealis theme by patrykkopycinski · Pull Request #202393 · elastic/kibana

patrykkopycinski · 2024-12-01T21:39:28Z

Summary

…ealis

patrykkopycinski · 2025-01-08T17:36:53Z

/ci

…bana into feat/gen-ai-borealis

patrykkopycinski · 2025-01-08T17:52:30Z

/ci

x-pack/packages/kbn-elastic-assistant/impl/assistant/assistant_overlay/flyout_navigation.tsx

...packages/shared/kbn-elastic-assistant/impl/assistant/assistant_overlay/flyout_navigation.tsx

...-elastic-assistant/impl/assistant/prompt_editor/system_prompt/select_system_prompt/index.tsx

mgadewoll · 2025-01-09T13:09:37Z

...orm/packages/shared/kbn-elastic-assistant/impl/data_anonymization_editor/context_preview.tsx

  color: ${(props) =>
-    props.showRealValues ? euiThemeVars.euiColorSuccess : euiThemeVars.euiColorAccent};
+    props.showRealValues
+      ? props.theme.euiTheme.colors.textPrimary


Question: Is this an intentional change from success to primary? (This will affect Amsterdam as well)

yes, it's used in this context, so I believe primary better serves the purpose:
before changes (success):

after changes (textPrimary):

toggled (textAccent):

@james-elastic @bojanasan are you ok with this change? (green -> blue text color)
the change was introduced due to #199715 (comment)

@patrykkopycinski all good on my end, I agree that think it makes more sense to use the primary color instead of success for anonymization strings.

++ good with me.

…bana into feat/gen-ai-borealis

...packages/shared/kbn-elastic-assistant/impl/assistant/assistant_overlay/flyout_navigation.tsx

mgadewoll

✅ Changes LGTM from EUI side.

e40pud

LGTM! Left a small comment

...tion/public/detections/components/rules/rule_execution_status/rule_status_failed_callout.tsx

elasticmachine · 2025-01-14T16:11:46Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: c49d45e

Failed CI Steps

Test Failures

[job] [logs] x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts / Serverless Observability - Deployment-agnostic API integration tests observability AI Assistant When there are knowledge base entries (from 8.15 or earlier) that does not contain semantic_text embeddings "after all" hook in "When there are knowledge base entries (from 8.15 or earlier) that does not contain semantic_text embeddings"
[job] [logs] x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts / Serverless Observability - Deployment-agnostic API integration tests observability AI Assistant When there are knowledge base entries (from 8.15 or earlier) that does not contain semantic_text embeddings "before all" hook in "When there are knowledge base entries (from 8.15 or earlier) that does not contain semantic_text embeddings"
[job] [logs] Jest Integration Tests #4 / StorageIndexAdapter when indexing into a clean Elasticsearch instance after rolling over the index manually and indexing the same document deletes the document from the rolled over index
[job] [logs] Jest Integration Tests #4 / StorageIndexAdapter when indexing into a clean Elasticsearch instance after rolling over the index manually and indexing the same document puts the document in the new write index

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`securitySolution`	21.2MB	21.2MB	+223.0B

History

💔 Build #266511 failed 0247a5b
💔 Build #265886 failed afd6efa
💛 Build #265671 was flaky 622154b
💔 Build #265357 failed 8e352f8
💛 Build #265331 was flaky e34caf0

cc @patrykkopycinski

kibanamachine · 2025-01-14T17:26:53Z

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12773075096

…lastic#202393) ## Summary <img width="3003" alt="Zrzut ekranu 2025-01-8 o 18 33 20" src="https://github.com/user-attachments/assets/4bc2f0f4-74f6-439b-b3dc-2c8e5182321b" /> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 760d6fe)

kibanamachine · 2025-01-14T17:32:08Z

💚 All backports created successfully

Status	Branch	Result
✅	8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

…lastic#202393) ## Summary <img width="3003" alt="Zrzut ekranu 2025-01-8 o 18 33 20" src="https://github.com/user-attachments/assets/4bc2f0f4-74f6-439b-b3dc-2c8e5182321b" /> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

caused by missing backport from elastic#202393

Add support for borealis theme

75b6d2f

KDKHD mentioned this pull request Dec 2, 2024

[Security Assistant] Fix animation border color of security AI assistant #202319

Merged

2 tasks

patrykkopycinski added 2 commits December 9, 2024 18:09

cleanup

99261a0

Merge branch 'main' of github.com:elastic/kibana into feat/gen-ai-bor…

7781a1b

…ealis

JasonStoltz added the EUI Visual Refresh label Dec 10, 2024

mgadewoll added the backport:skip This PR does not require backporting label Dec 12, 2024

patrykkopycinski added 4 commits January 7, 2025 23:00

Merge branch 'main' of github.com:elastic/kibana into feat/gen-ai-bor…

554333e

…ealis

Merge branch 'main' of github.com:elastic/kibana into feat/gen-ai-bor…

ef1823d

…ealis

Merge branch 'main' of github.com:elastic/kibana into feat/gen-ai-bor…

b09468c

…ealis

Cleanup

f7e8a44

kibanamachine and others added 3 commits January 8, 2025 17:47

[CI] Auto-commit changed files from 'node scripts/yarn_deduplicate'

a77eafd

Cleanup

b8e29f7

Merge branch 'feat/gen-ai-borealis' of github.com:patrykkopycinski/ki…

e34caf0

…bana into feat/gen-ai-borealis

deprecated tokens

621187d

patrykkopycinski requested review from JasonStoltz and mgadewoll January 8, 2025 19:34

Merge branch 'main' into feat/gen-ai-borealis

8e352f8

patrykkopycinski changed the title ~~Add support for borealis theme~~ [EUI Visual Refresh][Security Gen AI] Add support for borealis theme Jan 8, 2025

patrykkopycinski marked this pull request as ready for review January 8, 2025 19:35

patrykkopycinski requested review from a team as code owners January 8, 2025 19:35

patrykkopycinski requested a review from xcrzx January 8, 2025 19:35

mgadewoll reviewed Jan 9, 2025

View reviewed changes

xcrzx approved these changes Jan 9, 2025

View reviewed changes

patrykkopycinski added 3 commits January 9, 2025 15:28

change border colors

f587936

Merge branch 'feat/gen-ai-borealis' of github.com:patrykkopycinski/ki…

f8e244a

…bana into feat/gen-ai-borealis

fix

0f5fe27

mgadewoll reviewed Jan 9, 2025

View reviewed changes

...packages/shared/kbn-elastic-assistant/impl/assistant/assistant_overlay/flyout_navigation.tsx Outdated Show resolved Hide resolved

fix

622154b

mgadewoll approved these changes Jan 9, 2025

View reviewed changes

patrykkopycinski self-assigned this Jan 10, 2025

patrykkopycinski added release_note:skip Skip the PR/issue when compiling release notes Feature:Security Assistant Security Assistant Team:Security Generative AI Security Generative AI labels Jan 10, 2025

Merge branch 'main' into feat/gen-ai-borealis

afd6efa

e40pud approved these changes Jan 10, 2025

View reviewed changes

...tion/public/detections/components/rules/rule_execution_status/rule_status_failed_callout.tsx Outdated Show resolved Hide resolved

patrykkopycinski added 2 commits January 13, 2025 14:48

Update rule_status_failed_callout.tsx

0247a5b

Merge branch 'main' into feat/gen-ai-borealis

c49d45e

patrykkopycinski added v9.0.0 backport:version Backport to applied version labels v8.18.0 and removed backport:skip This PR does not require backporting labels Jan 14, 2025

patrykkopycinski merged commit 760d6fe into elastic:main Jan 14, 2025

kibanamachine mentioned this pull request Jan 14, 2025

[8.x] [EUI Visual Refresh][Security Gen AI] Add support for borealis theme (#202393) #206647

Closed

patrykkopycinski added backport:skip This PR does not require backporting and removed backport:version Backport to applied version labels labels Jan 14, 2025

kibanamachine mentioned this pull request Jan 29, 2025

[Security Solution] [AI Assistant] Security AI Assistant - Citations #206683

Merged

9 tasks

kapral18 added a commit to kibanamachine/kibana that referenced this pull request Feb 11, 2025

chore: resolve snapshot update issue caused by missing backport

1922cbd

caused by missing backport from elastic#202393

kapral18 added a commit to kapral18/kibana that referenced this pull request Feb 11, 2025

chore: resolve snapshot update issue caused by missing backport

6787ef6

caused by missing backport from elastic#202393

kibanamachine mentioned this pull request Feb 21, 2025

[Security Solution] [AI Assistant] Update copy of the citations tour. #210398

Merged

9 tasks

kibanamachine mentioned this pull request Mar 3, 2025

[Security Assistant] Conversation pagination refactor #211831

Merged

Conversation

patrykkopycinski commented Dec 1, 2024 • edited by kibanamachine Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

patrykkopycinski commented Jan 8, 2025

Uh oh!

patrykkopycinski commented Jan 8, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mgadewoll Jan 9, 2025

Choose a reason for hiding this comment

Uh oh!

patrykkopycinski Jan 9, 2025

Choose a reason for hiding this comment

Uh oh!

patrykkopycinski Jan 13, 2025

Choose a reason for hiding this comment

Uh oh!

bojanasan Jan 14, 2025

Choose a reason for hiding this comment

Uh oh!

jamesspi Jan 14, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mgadewoll left a comment

Choose a reason for hiding this comment

Uh oh!

e40pud left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

elasticmachine commented Jan 14, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Async chunks

History

Uh oh!

kibanamachine commented Jan 14, 2025

Uh oh!

kibanamachine commented Jan 14, 2025

💚 All backports created successfully

Questions ?

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

patrykkopycinski commented Dec 1, 2024 •

edited by kibanamachine

Loading