[8.x] [Stack Monitoring] Remove 'observability' and 'observabilityShared' plugin dependencies (#203492)#204912
Merged
gbamparop merged 1 commit intoelastic:8.xfrom Dec 19, 2024
Merged
Conversation
…lugin dependencies (elastic#203492) ### Summary A recent [bug](elastic#199902) that affected some of the pages in Stack Monitoring was caused by changes related to the locators of the logs-related apps. The goal of this PR is to reduce the number of Observability dependencies that could potentially cause issues in the app by removing the `observability` and `observabilityShared` plugin dependencies from the `monitoring` plugin. Currently, the `monitoring` plugin is [categorised as observability](https://github.com/elastic/kibana/blob/main/x-pack/plugins/monitoring/kibana.jsonc#L7) but when the dependency on the `infra` plugin is removed, it can be marked as a `platform` plugin. ### Notes for reviewers - The components used to render the header menu as well as the [use_track_metric](https://github.com/elastic/kibana/pull/203492/files#diff-7e39fc60ca80ee551d824ca97f9f879e3364a368a5736cf9178b5943a12ca7a7) hook were copied from the `observabilityShared` plugin - There should be no UX and functionality changes in the stack monitoring header - Usage collection could be verified by searching for UI counters sent by the cluster created for this PR, once telemetry has been sent ### Testing The stateful environment deployed by this PR includes logs and metrics for stack monitoring. Please make sure to select a larger time range (e.g. last 14 days). --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit 7e2f67e)
botelastic
bot
added
ci:project-deploy-observability
Contributor
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
Contributor
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
flash1293
approved these changes
Dec 19, 2024
Contributor
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsasync chunk count
ESLint disabled line counts
References to deprecated APIs
Total ESLint disabled count
History |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.x:Questions ?
Please refer to the Backport tool documentation