[Stack Monitoring] Remove 'observability' and 'observabilityShared' plugin dependencies#203492
Merged
gbamparop merged 3 commits intoelastic:mainfrom Dec 10, 2024
Merged
Conversation
botelastic
bot
added
ci:project-deploy-observability
Contributor
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
Contributor
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
gbamparop
added
backport:skip
Contributor
Author
|
/ci |
gbamparop
changed the title
Contributor
Author
|
/oblt-deploy |
Contributor
Author
|
/ci |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsasync chunk count
ESLint disabled line counts
References to deprecated APIs
Total ESLint disabled count
History
|
miltonhultgren
approved these changes
Dec 10, 2024
Contributor
miltonhultgren
left a comment
miltonhultgren
left a comment
There was a problem hiding this comment.
Code review only, but these changes look correct.
consulthys
approved these changes
Dec 10, 2024
Contributor
consulthys
left a comment
consulthys
left a comment
There was a problem hiding this comment.
LGT Stack Monitoring
In the oblt test cluster deployed, I can see that:
- usage counters are being properly reported via
/api/ui_counters/_report - there doesn't appear to be any UX changes
- the header menu appears unchanged
- the Discover link appears at the bottom of the logs list and when clicked properly redirects the user to the Discover view
shahzad31
approved these changes
Dec 10, 2024
afharo
approved these changes
Dec 10, 2024
flash1293
added a commit
that referenced
this pull request
Dec 11, 2024
Blocked by #203492 The monitoring plugin is currently marked as observability plugin because it's relying on the `infra` plugin. However, in practice, no functionality is actually used. This PR removes the dependency -it makes monitoring and logstash a `platform/private` plugin as well (logstash needs to go along with monitoring, but that should be fine because it's only required by monitoring). Some considerations left as comments in the code. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 11, 2024
Blocked by elastic#203492 The monitoring plugin is currently marked as observability plugin because it's relying on the `infra` plugin. However, in practice, no functionality is actually used. This PR removes the dependency -it makes monitoring and logstash a `platform/private` plugin as well (logstash needs to go along with monitoring, but that should be fine because it's only required by monitoring). Some considerations left as comments in the code. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 59d3ac6)
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
…lugin dependencies (elastic#203492) ### Summary A recent [bug](elastic#199902) that affected some of the pages in Stack Monitoring was caused by changes related to the locators of the logs-related apps. The goal of this PR is to reduce the number of Observability dependencies that could potentially cause issues in the app by removing the `observability` and `observabilityShared` plugin dependencies from the `monitoring` plugin. Currently, the `monitoring` plugin is [categorised as observability](https://github.com/elastic/kibana/blob/main/x-pack/plugins/monitoring/kibana.jsonc#L7) but when the dependency on the `infra` plugin is removed, it can be marked as a `platform` plugin. ### Notes for reviewers - The components used to render the header menu as well as the [use_track_metric](https://github.com/elastic/kibana/pull/203492/files#diff-7e39fc60ca80ee551d824ca97f9f879e3364a368a5736cf9178b5943a12ca7a7) hook were copied from the `observabilityShared` plugin - There should be no UX and functionality changes in the stack monitoring header - Usage collection could be verified by searching for UI counters sent by the cluster created for this PR, once telemetry has been sent ### Testing The stateful environment deployed by this PR includes logs and metrics for stack monitoring. Please make sure to select a larger time range (e.g. last 14 days). --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
Blocked by elastic#203492 The monitoring plugin is currently marked as observability plugin because it's relying on the `infra` plugin. However, in practice, no functionality is actually used. This PR removes the dependency -it makes monitoring and logstash a `platform/private` plugin as well (logstash needs to go along with monitoring, but that should be fine because it's only required by monitoring). Some considerations left as comments in the code. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
gbamparop
added a commit
to gbamparop/kibana
that referenced
this pull request
Dec 19, 2024
…lugin dependencies (elastic#203492) ### Summary A recent [bug](elastic#199902) that affected some of the pages in Stack Monitoring was caused by changes related to the locators of the logs-related apps. The goal of this PR is to reduce the number of Observability dependencies that could potentially cause issues in the app by removing the `observability` and `observabilityShared` plugin dependencies from the `monitoring` plugin. Currently, the `monitoring` plugin is [categorised as observability](https://github.com/elastic/kibana/blob/main/x-pack/plugins/monitoring/kibana.jsonc#L7) but when the dependency on the `infra` plugin is removed, it can be marked as a `platform` plugin. ### Notes for reviewers - The components used to render the header menu as well as the [use_track_metric](https://github.com/elastic/kibana/pull/203492/files#diff-7e39fc60ca80ee551d824ca97f9f879e3364a368a5736cf9178b5943a12ca7a7) hook were copied from the `observabilityShared` plugin - There should be no UX and functionality changes in the stack monitoring header - Usage collection could be verified by searching for UI counters sent by the cluster created for this PR, once telemetry has been sent ### Testing The stateful environment deployed by this PR includes logs and metrics for stack monitoring. Please make sure to select a larger time range (e.g. last 14 days). --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit 7e2f67e)
gbamparop
added a commit
that referenced
this pull request
Dec 19, 2024
…red' plugin dependencies (#203492) (#204912) # Backport This will backport the following commits from `main` to `8.x`: - [[Stack Monitoring] Remove 'observability' and 'observabilityShared' plugin dependencies (#203492)](#203492) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Giorgos Bamparopoulos","email":"georgios.bamparopoulos@elastic.co"},"sourceCommit":{"committedDate":"2024-12-10T16:43:49Z","message":"[Stack Monitoring] Remove 'observability' and 'observabilityShared' plugin dependencies (#203492)\n\n### Summary\r\nA recent [bug](#199902) that\r\naffected some of the pages in Stack Monitoring was caused by changes\r\nrelated to the locators of the logs-related apps.\r\n\r\nThe goal of this PR is to reduce the number of Observability\r\ndependencies that could potentially cause issues in the app by removing\r\nthe `observability` and `observabilityShared` plugin dependencies from\r\nthe `monitoring` plugin.\r\n\r\nCurrently, the `monitoring` plugin is [categorised as\r\nobservability](https://github.com/elastic/kibana/blob/main/x-pack/plugins/monitoring/kibana.jsonc#L7)\r\nbut when the dependency on the `infra` plugin is removed, it can be\r\nmarked as a `platform` plugin.\r\n\r\n### Notes for reviewers\r\n- The components used to render the header menu as well as the\r\n[use_track_metric](https://github.com/elastic/kibana/pull/203492/files#diff-7e39fc60ca80ee551d824ca97f9f879e3364a368a5736cf9178b5943a12ca7a7)\r\nhook were copied from the `observabilityShared` plugin\r\n- There should be no UX and functionality changes in the stack\r\nmonitoring header\r\n- Usage collection could be verified by searching for UI counters sent\r\nby the cluster created for this PR, once telemetry has been sent\r\n\r\n### Testing\r\nThe stateful environment deployed by this PR includes logs and metrics\r\nfor stack monitoring. Please make sure to select a larger time range\r\n(e.g. last 14 days).\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"7e2f67ebc550167f8b9d678312c69eda1abc921b","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:skip","v9.0.0","ci:project-deploy-observability","Team:obs-ux-management"],"number":203492,"url":"https://github.com/elastic/kibana/pull/203492","mergeCommit":{"message":"[Stack Monitoring] Remove 'observability' and 'observabilityShared' plugin dependencies (#203492)\n\n### Summary\r\nA recent [bug](#199902) that\r\naffected some of the pages in Stack Monitoring was caused by changes\r\nrelated to the locators of the logs-related apps.\r\n\r\nThe goal of this PR is to reduce the number of Observability\r\ndependencies that could potentially cause issues in the app by removing\r\nthe `observability` and `observabilityShared` plugin dependencies from\r\nthe `monitoring` plugin.\r\n\r\nCurrently, the `monitoring` plugin is [categorised as\r\nobservability](https://github.com/elastic/kibana/blob/main/x-pack/plugins/monitoring/kibana.jsonc#L7)\r\nbut when the dependency on the `infra` plugin is removed, it can be\r\nmarked as a `platform` plugin.\r\n\r\n### Notes for reviewers\r\n- The components used to render the header menu as well as the\r\n[use_track_metric](https://github.com/elastic/kibana/pull/203492/files#diff-7e39fc60ca80ee551d824ca97f9f879e3364a368a5736cf9178b5943a12ca7a7)\r\nhook were copied from the `observabilityShared` plugin\r\n- There should be no UX and functionality changes in the stack\r\nmonitoring header\r\n- Usage collection could be verified by searching for UI counters sent\r\nby the cluster created for this PR, once telemetry has been sent\r\n\r\n### Testing\r\nThe stateful environment deployed by this PR includes logs and metrics\r\nfor stack monitoring. Please make sure to select a larger time range\r\n(e.g. last 14 days).\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"7e2f67ebc550167f8b9d678312c69eda1abc921b"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203492","number":203492,"mergeCommit":{"message":"[Stack Monitoring] Remove 'observability' and 'observabilityShared' plugin dependencies (#203492)\n\n### Summary\r\nA recent [bug](#199902) that\r\naffected some of the pages in Stack Monitoring was caused by changes\r\nrelated to the locators of the logs-related apps.\r\n\r\nThe goal of this PR is to reduce the number of Observability\r\ndependencies that could potentially cause issues in the app by removing\r\nthe `observability` and `observabilityShared` plugin dependencies from\r\nthe `monitoring` plugin.\r\n\r\nCurrently, the `monitoring` plugin is [categorised as\r\nobservability](https://github.com/elastic/kibana/blob/main/x-pack/plugins/monitoring/kibana.jsonc#L7)\r\nbut when the dependency on the `infra` plugin is removed, it can be\r\nmarked as a `platform` plugin.\r\n\r\n### Notes for reviewers\r\n- The components used to render the header menu as well as the\r\n[use_track_metric](https://github.com/elastic/kibana/pull/203492/files#diff-7e39fc60ca80ee551d824ca97f9f879e3364a368a5736cf9178b5943a12ca7a7)\r\nhook were copied from the `observabilityShared` plugin\r\n- There should be no UX and functionality changes in the stack\r\nmonitoring header\r\n- Usage collection could be verified by searching for UI counters sent\r\nby the cluster created for this PR, once telemetry has been sent\r\n\r\n### Testing\r\nThe stateful environment deployed by this PR includes logs and metrics\r\nfor stack monitoring. Please make sure to select a larger time range\r\n(e.g. last 14 days).\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"7e2f67ebc550167f8b9d678312c69eda1abc921b"}}]}] BACKPORT-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A recent bug that affected some of the pages in Stack Monitoring was caused by changes related to the locators of the logs-related apps.
The goal of this PR is to reduce the number of Observability dependencies that could potentially cause issues in the app by removing the
observabilityandobservabilitySharedplugin dependencies from themonitoringplugin.Currently, the
monitoringplugin is categorised as observability but when the dependency on theinfraplugin is removed, it can be marked as aplatformplugin.Notes for reviewers
observabilitySharedpluginTesting
The stateful environment deployed by this PR includes logs and metrics for stack monitoring. Please make sure to select a larger time range (e.g. last 14 days).