Skip to content

[8.x] Remove dependency on infra in monitoring plugin (#203551)#203836

Merged
stephmilovic merged 4 commits intoelastic:8.xfrom
kibanamachine:backport/8.x/pr-203551
Dec 19, 2024
Merged

[8.x] Remove dependency on infra in monitoring plugin (#203551)#203836
stephmilovic merged 4 commits intoelastic:8.xfrom
kibanamachine:backport/8.x/pr-203551

Conversation

@kibanamachine
Copy link
Copy Markdown
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

Blocked by elastic#203492

The monitoring plugin is currently marked as observability plugin
because it's relying on the `infra` plugin.

However, in practice, no functionality is actually used. This PR removes
the dependency -it makes monitoring and logstash a `platform/private`
plugin as well (logstash needs to go along with monitoring, but that
should be fine because it's only required by monitoring).

Some considerations left as comments in the code.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 59d3ac6)
@kibanamachine kibanamachine added the backport This PR is a backport of another PR label Dec 11, 2024
@kibanamachine kibanamachine enabled auto-merge (squash) December 11, 2024 16:16
@kapral18
Copy link
Copy Markdown
Contributor

Please do not merge this pull request. We disabled auto-merge because we are trying to merge a this big PR as part of sustainable architecture migration which is impossible with ever increasing stream of backports. We will resume the automerge after our PR is merged. Reach out to #sustainable-kibana-architecture for more info.

@kapral18 kapral18 disabled auto-merge December 17, 2024 16:39
@kapral18
Copy link
Copy Markdown
Contributor

Auto-merge has been re-enabled. Thank you for your patience. :heart

@stephmilovic stephmilovic enabled auto-merge (squash) December 17, 2024 19:32
@stephmilovic
Copy link
Copy Markdown
Contributor

@elasticmachine merge upstream

@flash1293
Copy link
Copy Markdown
Contributor

@gbamparop Looks like this backport conflicts because #203492 hasn't been backported. I guess we should backport both of these?

@gbamparop
Copy link
Copy Markdown
Contributor

@gbamparop Looks like this backport conflicts because #203492 hasn't been backported. I guess we should backport both of these?

Created a backport here #204912

@gbamparop
Copy link
Copy Markdown
Contributor

Created a backport here #204912

@flash1293 this is merged now

@flash1293
Copy link
Copy Markdown
Contributor

Thanks @gbamparop , let's see whether it goes through now

@stephmilovic stephmilovic merged commit 32d2cd7 into elastic:8.x Dec 19, 2024
@elasticmachine
Copy link
Copy Markdown
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #20 / alerting api integration security and spaces enabled - Group 3 Maintenance Window - Group 3 maintenance window findMaintenanceWindow global_read at space1 should handle find maintenance window request with pagination

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
monitoring 538.4KB 538.4KB +16.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
monitoring 25.7KB 25.7KB -44.0B

History

cc @flash1293

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants