Sustainable Kibana Architecture: Move modules under x-pack/packages/security-solution#203522
Conversation
|
Pinging @elastic/kibana-core (Team:Core) |
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
PhilippeOberti
left a comment
There was a problem hiding this comment.
Code LGTM for the @elastic/security-threat-hunting-investigations team as we only own the data-table package.
I want to point out to the @elastic/security-threat-hunting-explore team that running the yarn storybook security_solution_packages command succeeds but going to http://localhost:9001/ throws the following error:

This works fine in main so something in this PR is breaking Storybook
4b75cea to
5c35d52
Compare
ed3aa82 to
f3695c9
Compare
…t --include-path /api/status --include-path /api/alerting/rule/ --include-path /api/alerting/rules --include-path /api/actions --include-path /api/security/role --include-path /api/spaces --include-path /api/fleet --include-path /api/dashboards --update'
…-cache --fix'" This reverts commit 00b8170b1da85d5ab56ff4b8425cf6f99bd3a759.
f3695c9 to
e332c35
Compare
💚 Build Succeeded
Metrics [docs]
History
|
maxcold
left a comment
There was a problem hiding this comment.
distribution_bar component changes lgtm
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12295307819 |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…security-solution` (elastic#203522) ## Summary This PR aims at relocating some of the Kibana modules (plugins and packages) into a new folder structure, according to the _Sustainable Kibana Architecture_ initiative. > [!IMPORTANT] > * We kindly ask you to: > * Manually fix the errors in the error section below (if there are any). > * Search for the `packages[\/\\]` and `plugins[\/\\]` patterns in the source code (Babel and Eslint config files), and update them appropriately. > * Manually review `.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that any CI pipeline customizations continue to be correctly applied after the changed path names > * Review all of the updated files, specially the `.ts` and `.js` files listed in the sections below, as some of them contain relative paths that have been updated. > * Think of potential impact of the move, including tooling and configuration files that can be pointing to the relocated modules. E.g.: > * customised eslint rules > * docs pointing to source code > [!NOTE] > This PR has been auto-generated. > Do not attempt to push any changes unless you know what you are doing. > Please use [#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E) Slack channel for feedback. #### 7 package(s) are going to be relocated: | Id | Target folder | | -- | ------------- | | `@kbn/ecs-data-quality-dashboard` | `x-pack/solutions/security/packages/ecs_data_quality_dashboard` | | `@kbn/security-solution-distribution-bar` | `x-pack/solutions/security/packages/distribution_bar` | | `@kbn/security-solution-features` | `x-pack/solutions/security/packages/features` | | `@kbn/security-solution-navigation` | `x-pack/solutions/security/packages/navigation` | | `@kbn/security-solution-side-nav` | `x-pack/solutions/security/packages/side_nav` | | `@kbn/security-solution-upselling` | `x-pack/solutions/security/packages/upselling` | | `@kbn/securitysolution-data-table` | `x-pack/solutions/security/packages/data_table` | <details> <summary>Updated references</summary> ``` ./.eslintrc.js ./package.json ./packages/kbn-repo-packages/package-map.json ./packages/kbn-ts-projects/config-paths.json ./tsconfig.base.json ./tsconfig.base.type_check.json ./tsconfig.refs.json ./x-pack/solutions/security/packages/data_table/jest.config.js ./x-pack/solutions/security/packages/distribution_bar/jest.config.js ./x-pack/solutions/security/packages/ecs_data_quality_dashboard/jest.config.js ./x-pack/solutions/security/packages/features/jest.config.js ./x-pack/solutions/security/packages/navigation/jest.config.js ./x-pack/solutions/security/packages/side_nav/jest.config.js ./x-pack/solutions/security/packages/upselling/jest.config.js ./x-pack/solutions/security/plugins/security_solution_serverless/tsconfig.type_check.json ./yarn.lock ``` </details> <details> <summary>Updated relative paths</summary> ``` x-pack/solutions/security/packages/data_table/jest.config.js:11 x-pack/solutions/security/packages/data_table/tsconfig.json:2 x-pack/solutions/security/packages/distribution_bar/jest.config.js:11 x-pack/solutions/security/packages/distribution_bar/tsconfig.json:2 x-pack/solutions/security/packages/ecs_data_quality_dashboard/jest.config.js:21 x-pack/solutions/security/packages/ecs_data_quality_dashboard/tsconfig.json:2 x-pack/solutions/security/packages/features/jest.config.js:10 x-pack/solutions/security/packages/features/tsconfig.json:2 x-pack/solutions/security/packages/navigation/jest.config.js:10 x-pack/solutions/security/packages/navigation/tsconfig.json:2 x-pack/solutions/security/packages/side_nav/jest.config.js:10 x-pack/solutions/security/packages/side_nav/src/solution_side_nav.stories.tsx:11 x-pack/solutions/security/packages/side_nav/tsconfig.json:2 x-pack/solutions/security/packages/upselling/jest.config.js:10 x-pack/solutions/security/packages/upselling/tsconfig.json:2 ``` </details> <details> <summary>Script errors</summary> ``` ``` </details> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Angela Chuang <yi-chun.chuang@elastic.co> Co-authored-by: Karen Grigoryan <karen.grigoryan@elastic.co> (cherry picked from commit 50068fd) # Conflicts: # .github/CODEOWNERS
…kages/security-solution` (#203522) (#204006) # Backport This will backport the following commits from `main` to `8.x`: - [Sustainable Kibana Architecture: Move modules under `x-pack/packages/security-solution` (#203522)](#203522) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Gerard Soldevila","email":"gerard.soldevila@elastic.co"},"sourceCommit":{"committedDate":"2024-12-12T11:18:10Z","message":"Sustainable Kibana Architecture: Move modules under `x-pack/packages/security-solution` (#203522)\n\n## Summary\r\n\r\nThis PR aims at relocating some of the Kibana modules (plugins and\r\npackages) into a new folder structure, according to the _Sustainable\r\nKibana Architecture_ initiative.\r\n\r\n> [!IMPORTANT]\r\n> * We kindly ask you to:\r\n> * Manually fix the errors in the error section below (if there are\r\nany).\r\n> * Search for the `packages[\\/\\\\]` and `plugins[\\/\\\\]` patterns in the\r\nsource code (Babel and Eslint config files), and update them\r\nappropriately.\r\n> * Manually review\r\n`.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that\r\nany CI pipeline customizations continue to be correctly applied after\r\nthe changed path names\r\n> * Review all of the updated files, specially the `.ts` and `.js` files\r\nlisted in the sections below, as some of them contain relative paths\r\nthat have been updated.\r\n> * Think of potential impact of the move, including tooling and\r\nconfiguration files that can be pointing to the relocated modules. E.g.:\r\n> * customised eslint rules\r\n> * docs pointing to source code\r\n\r\n> [!NOTE]\r\n> This PR has been auto-generated.\r\n> Do not attempt to push any changes unless you know what you are doing.\r\n> Please use\r\n[#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E)\r\nSlack channel for feedback.\r\n\r\n\r\n#### 7 package(s) are going to be relocated:\r\n\r\n | Id | Target folder |\r\n | -- | ------------- |\r\n| `@kbn/ecs-data-quality-dashboard` |\r\n`x-pack/solutions/security/packages/ecs_data_quality_dashboard` |\r\n| `@kbn/security-solution-distribution-bar` |\r\n`x-pack/solutions/security/packages/distribution_bar` |\r\n| `@kbn/security-solution-features` |\r\n`x-pack/solutions/security/packages/features` |\r\n| `@kbn/security-solution-navigation` |\r\n`x-pack/solutions/security/packages/navigation` |\r\n| `@kbn/security-solution-side-nav` |\r\n`x-pack/solutions/security/packages/side_nav` |\r\n| `@kbn/security-solution-upselling` |\r\n`x-pack/solutions/security/packages/upselling` |\r\n| `@kbn/securitysolution-data-table` |\r\n`x-pack/solutions/security/packages/data_table` |\r\n\r\n\r\n<details>\r\n<summary>Updated references</summary>\r\n\r\n```\r\n./.eslintrc.js\r\n./package.json\r\n./packages/kbn-repo-packages/package-map.json\r\n./packages/kbn-ts-projects/config-paths.json\r\n./tsconfig.base.json\r\n./tsconfig.base.type_check.json\r\n./tsconfig.refs.json\r\n./x-pack/solutions/security/packages/data_table/jest.config.js\r\n./x-pack/solutions/security/packages/distribution_bar/jest.config.js\r\n./x-pack/solutions/security/packages/ecs_data_quality_dashboard/jest.config.js\r\n./x-pack/solutions/security/packages/features/jest.config.js\r\n./x-pack/solutions/security/packages/navigation/jest.config.js\r\n./x-pack/solutions/security/packages/side_nav/jest.config.js\r\n./x-pack/solutions/security/packages/upselling/jest.config.js\r\n./x-pack/solutions/security/plugins/security_solution_serverless/tsconfig.type_check.json\r\n./yarn.lock\r\n```\r\n</details>\r\n<details>\r\n<summary>Updated relative paths</summary>\r\n\r\n```\r\nx-pack/solutions/security/packages/data_table/jest.config.js:11\r\nx-pack/solutions/security/packages/data_table/tsconfig.json:2\r\nx-pack/solutions/security/packages/distribution_bar/jest.config.js:11\r\nx-pack/solutions/security/packages/distribution_bar/tsconfig.json:2\r\nx-pack/solutions/security/packages/ecs_data_quality_dashboard/jest.config.js:21\r\nx-pack/solutions/security/packages/ecs_data_quality_dashboard/tsconfig.json:2\r\nx-pack/solutions/security/packages/features/jest.config.js:10\r\nx-pack/solutions/security/packages/features/tsconfig.json:2\r\nx-pack/solutions/security/packages/navigation/jest.config.js:10\r\nx-pack/solutions/security/packages/navigation/tsconfig.json:2\r\nx-pack/solutions/security/packages/side_nav/jest.config.js:10\r\nx-pack/solutions/security/packages/side_nav/src/solution_side_nav.stories.tsx:11\r\nx-pack/solutions/security/packages/side_nav/tsconfig.json:2\r\nx-pack/solutions/security/packages/upselling/jest.config.js:10\r\nx-pack/solutions/security/packages/upselling/tsconfig.json:2\r\n```\r\n</details>\r\n<details>\r\n<summary>Script errors</summary>\r\n\r\n```\r\n\r\n```\r\n</details>\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Angela Chuang <yi-chun.chuang@elastic.co>\r\nCo-authored-by: Karen Grigoryan <karen.grigoryan@elastic.co>","sha":"50068fd9bae6791594bd9d25cfef1f07d2b5ceab","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:skip","v9.0.0","Team: SecuritySolution","backport:prev-minor"],"number":203522,"url":"https://github.com/elastic/kibana/pull/203522","mergeCommit":{"message":"Sustainable Kibana Architecture: Move modules under `x-pack/packages/security-solution` (#203522)\n\n## Summary\r\n\r\nThis PR aims at relocating some of the Kibana modules (plugins and\r\npackages) into a new folder structure, according to the _Sustainable\r\nKibana Architecture_ initiative.\r\n\r\n> [!IMPORTANT]\r\n> * We kindly ask you to:\r\n> * Manually fix the errors in the error section below (if there are\r\nany).\r\n> * Search for the `packages[\\/\\\\]` and `plugins[\\/\\\\]` patterns in the\r\nsource code (Babel and Eslint config files), and update them\r\nappropriately.\r\n> * Manually review\r\n`.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that\r\nany CI pipeline customizations continue to be correctly applied after\r\nthe changed path names\r\n> * Review all of the updated files, specially the `.ts` and `.js` files\r\nlisted in the sections below, as some of them contain relative paths\r\nthat have been updated.\r\n> * Think of potential impact of the move, including tooling and\r\nconfiguration files that can be pointing to the relocated modules. E.g.:\r\n> * customised eslint rules\r\n> * docs pointing to source code\r\n\r\n> [!NOTE]\r\n> This PR has been auto-generated.\r\n> Do not attempt to push any changes unless you know what you are doing.\r\n> Please use\r\n[#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E)\r\nSlack channel for feedback.\r\n\r\n\r\n#### 7 package(s) are going to be relocated:\r\n\r\n | Id | Target folder |\r\n | -- | ------------- |\r\n| `@kbn/ecs-data-quality-dashboard` |\r\n`x-pack/solutions/security/packages/ecs_data_quality_dashboard` |\r\n| `@kbn/security-solution-distribution-bar` |\r\n`x-pack/solutions/security/packages/distribution_bar` |\r\n| `@kbn/security-solution-features` |\r\n`x-pack/solutions/security/packages/features` |\r\n| `@kbn/security-solution-navigation` |\r\n`x-pack/solutions/security/packages/navigation` |\r\n| `@kbn/security-solution-side-nav` |\r\n`x-pack/solutions/security/packages/side_nav` |\r\n| `@kbn/security-solution-upselling` |\r\n`x-pack/solutions/security/packages/upselling` |\r\n| `@kbn/securitysolution-data-table` |\r\n`x-pack/solutions/security/packages/data_table` |\r\n\r\n\r\n<details>\r\n<summary>Updated references</summary>\r\n\r\n```\r\n./.eslintrc.js\r\n./package.json\r\n./packages/kbn-repo-packages/package-map.json\r\n./packages/kbn-ts-projects/config-paths.json\r\n./tsconfig.base.json\r\n./tsconfig.base.type_check.json\r\n./tsconfig.refs.json\r\n./x-pack/solutions/security/packages/data_table/jest.config.js\r\n./x-pack/solutions/security/packages/distribution_bar/jest.config.js\r\n./x-pack/solutions/security/packages/ecs_data_quality_dashboard/jest.config.js\r\n./x-pack/solutions/security/packages/features/jest.config.js\r\n./x-pack/solutions/security/packages/navigation/jest.config.js\r\n./x-pack/solutions/security/packages/side_nav/jest.config.js\r\n./x-pack/solutions/security/packages/upselling/jest.config.js\r\n./x-pack/solutions/security/plugins/security_solution_serverless/tsconfig.type_check.json\r\n./yarn.lock\r\n```\r\n</details>\r\n<details>\r\n<summary>Updated relative paths</summary>\r\n\r\n```\r\nx-pack/solutions/security/packages/data_table/jest.config.js:11\r\nx-pack/solutions/security/packages/data_table/tsconfig.json:2\r\nx-pack/solutions/security/packages/distribution_bar/jest.config.js:11\r\nx-pack/solutions/security/packages/distribution_bar/tsconfig.json:2\r\nx-pack/solutions/security/packages/ecs_data_quality_dashboard/jest.config.js:21\r\nx-pack/solutions/security/packages/ecs_data_quality_dashboard/tsconfig.json:2\r\nx-pack/solutions/security/packages/features/jest.config.js:10\r\nx-pack/solutions/security/packages/features/tsconfig.json:2\r\nx-pack/solutions/security/packages/navigation/jest.config.js:10\r\nx-pack/solutions/security/packages/navigation/tsconfig.json:2\r\nx-pack/solutions/security/packages/side_nav/jest.config.js:10\r\nx-pack/solutions/security/packages/side_nav/src/solution_side_nav.stories.tsx:11\r\nx-pack/solutions/security/packages/side_nav/tsconfig.json:2\r\nx-pack/solutions/security/packages/upselling/jest.config.js:10\r\nx-pack/solutions/security/packages/upselling/tsconfig.json:2\r\n```\r\n</details>\r\n<details>\r\n<summary>Script errors</summary>\r\n\r\n```\r\n\r\n```\r\n</details>\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Angela Chuang <yi-chun.chuang@elastic.co>\r\nCo-authored-by: Karen Grigoryan <karen.grigoryan@elastic.co>","sha":"50068fd9bae6791594bd9d25cfef1f07d2b5ceab"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203522","number":203522,"mergeCommit":{"message":"Sustainable Kibana Architecture: Move modules under `x-pack/packages/security-solution` (#203522)\n\n## Summary\r\n\r\nThis PR aims at relocating some of the Kibana modules (plugins and\r\npackages) into a new folder structure, according to the _Sustainable\r\nKibana Architecture_ initiative.\r\n\r\n> [!IMPORTANT]\r\n> * We kindly ask you to:\r\n> * Manually fix the errors in the error section below (if there are\r\nany).\r\n> * Search for the `packages[\\/\\\\]` and `plugins[\\/\\\\]` patterns in the\r\nsource code (Babel and Eslint config files), and update them\r\nappropriately.\r\n> * Manually review\r\n`.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that\r\nany CI pipeline customizations continue to be correctly applied after\r\nthe changed path names\r\n> * Review all of the updated files, specially the `.ts` and `.js` files\r\nlisted in the sections below, as some of them contain relative paths\r\nthat have been updated.\r\n> * Think of potential impact of the move, including tooling and\r\nconfiguration files that can be pointing to the relocated modules. E.g.:\r\n> * customised eslint rules\r\n> * docs pointing to source code\r\n\r\n> [!NOTE]\r\n> This PR has been auto-generated.\r\n> Do not attempt to push any changes unless you know what you are doing.\r\n> Please use\r\n[#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E)\r\nSlack channel for feedback.\r\n\r\n\r\n#### 7 package(s) are going to be relocated:\r\n\r\n | Id | Target folder |\r\n | -- | ------------- |\r\n| `@kbn/ecs-data-quality-dashboard` |\r\n`x-pack/solutions/security/packages/ecs_data_quality_dashboard` |\r\n| `@kbn/security-solution-distribution-bar` |\r\n`x-pack/solutions/security/packages/distribution_bar` |\r\n| `@kbn/security-solution-features` |\r\n`x-pack/solutions/security/packages/features` |\r\n| `@kbn/security-solution-navigation` |\r\n`x-pack/solutions/security/packages/navigation` |\r\n| `@kbn/security-solution-side-nav` |\r\n`x-pack/solutions/security/packages/side_nav` |\r\n| `@kbn/security-solution-upselling` |\r\n`x-pack/solutions/security/packages/upselling` |\r\n| `@kbn/securitysolution-data-table` |\r\n`x-pack/solutions/security/packages/data_table` |\r\n\r\n\r\n<details>\r\n<summary>Updated references</summary>\r\n\r\n```\r\n./.eslintrc.js\r\n./package.json\r\n./packages/kbn-repo-packages/package-map.json\r\n./packages/kbn-ts-projects/config-paths.json\r\n./tsconfig.base.json\r\n./tsconfig.base.type_check.json\r\n./tsconfig.refs.json\r\n./x-pack/solutions/security/packages/data_table/jest.config.js\r\n./x-pack/solutions/security/packages/distribution_bar/jest.config.js\r\n./x-pack/solutions/security/packages/ecs_data_quality_dashboard/jest.config.js\r\n./x-pack/solutions/security/packages/features/jest.config.js\r\n./x-pack/solutions/security/packages/navigation/jest.config.js\r\n./x-pack/solutions/security/packages/side_nav/jest.config.js\r\n./x-pack/solutions/security/packages/upselling/jest.config.js\r\n./x-pack/solutions/security/plugins/security_solution_serverless/tsconfig.type_check.json\r\n./yarn.lock\r\n```\r\n</details>\r\n<details>\r\n<summary>Updated relative paths</summary>\r\n\r\n```\r\nx-pack/solutions/security/packages/data_table/jest.config.js:11\r\nx-pack/solutions/security/packages/data_table/tsconfig.json:2\r\nx-pack/solutions/security/packages/distribution_bar/jest.config.js:11\r\nx-pack/solutions/security/packages/distribution_bar/tsconfig.json:2\r\nx-pack/solutions/security/packages/ecs_data_quality_dashboard/jest.config.js:21\r\nx-pack/solutions/security/packages/ecs_data_quality_dashboard/tsconfig.json:2\r\nx-pack/solutions/security/packages/features/jest.config.js:10\r\nx-pack/solutions/security/packages/features/tsconfig.json:2\r\nx-pack/solutions/security/packages/navigation/jest.config.js:10\r\nx-pack/solutions/security/packages/navigation/tsconfig.json:2\r\nx-pack/solutions/security/packages/side_nav/jest.config.js:10\r\nx-pack/solutions/security/packages/side_nav/src/solution_side_nav.stories.tsx:11\r\nx-pack/solutions/security/packages/side_nav/tsconfig.json:2\r\nx-pack/solutions/security/packages/upselling/jest.config.js:10\r\nx-pack/solutions/security/packages/upselling/tsconfig.json:2\r\n```\r\n</details>\r\n<details>\r\n<summary>Script errors</summary>\r\n\r\n```\r\n\r\n```\r\n</details>\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Angela Chuang <yi-chun.chuang@elastic.co>\r\nCo-authored-by: Karen Grigoryan <karen.grigoryan@elastic.co>","sha":"50068fd9bae6791594bd9d25cfef1f07d2b5ceab"}}]}] BACKPORT-->
Summary
This PR aims at relocating some of the Kibana modules (plugins and packages) into a new folder structure, according to the Sustainable Kibana Architecture initiative.
Important
packages[\/\\]andplugins[\/\\]patterns in the source code (Babel and Eslint config files), and update them appropriately..buildkite/scripts/pipelines/pull_request/pipeline.tsto ensure that any CI pipeline customizations continue to be correctly applied after the changed path names.tsand.jsfiles listed in the sections below, as some of them contain relative paths that have been updated.Note
This PR has been auto-generated.
Do not attempt to push any changes unless you know what you are doing.
Please use #sustainable_kibana_architecture Slack channel for feedback.
7 package(s) are going to be relocated:
@kbn/ecs-data-quality-dashboardx-pack/solutions/security/packages/ecs_data_quality_dashboard@kbn/security-solution-distribution-barx-pack/solutions/security/packages/distribution_bar@kbn/security-solution-featuresx-pack/solutions/security/packages/features@kbn/security-solution-navigationx-pack/solutions/security/packages/navigation@kbn/security-solution-side-navx-pack/solutions/security/packages/side_nav@kbn/security-solution-upsellingx-pack/solutions/security/packages/upselling@kbn/securitysolution-data-tablex-pack/solutions/security/packages/data_tableUpdated references
Updated relative paths
Script errors