Sustainable Kibana Architecture: Move modules owned by @elastic/obs-knowledge-team#202766
Conversation
|
Pinging @elastic/kibana-core (Team:Core) |
|
Pinging @elastic/obs-knowledge-team (Team:obs-knowledge) |
7ef1fde to
38bccf4
Compare
|
@gsoldevila What's the reason for the sse-utils-server package to be private instead of shared like the other ones? |
38bccf4 to
4373a3d
Compare
It was determined automatically. |
|
It's probably fine but I'd prefer if @dgieselaar weighs in on it before approving |
4373a3d to
a2ff063
Compare
There was a problem hiding this comment.
This package should be platform/shared, sorry for not catching this in the earlier categorization PR 🙏🏼
There was a problem hiding this comment.
@miltonhultgren I have rebased and picked up the new categorisation.
PR description has been updated too.
💚 Build Succeeded
Metrics [docs]
History
|
## Summary Pre-requisite to update #202766
…ic#203842) ## Summary Pre-requisite to update elastic#202766 (cherry picked from commit f4795cd)
…ic#203842) ## Summary Pre-requisite to update elastic#202766
0d20170 to
f604c1e
Compare
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12317671503 |
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12317671586 |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
1 similar comment
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
…knowledge-team` (elastic#202766) ## Summary This PR aims at relocating some of the Kibana modules (plugins and packages) into a new folder structure, according to the _Sustainable Kibana Architecture_ initiative. > [!IMPORTANT] > * We kindly ask you to: > * Manually fix the errors in the error section below (if there are any). > * Search for the `packages[\/\\]` and `plugins[\/\\]` patterns in the source code (Babel and Eslint config files), and update them appropriately. > * Manually review `.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that any CI pipeline customizations continue to be correctly applied after the changed path names > * Review all of the updated files, specially the `.ts` and `.js` files listed in the sections below, as some of them contain relative paths that have been updated. > * Think of potential impact of the move, including tooling and configuration files that can be pointing to the relocated modules. E.g.: > * customised eslint rules > * docs pointing to source code > [!NOTE] > This PR has been auto-generated. > Do not attempt to push any changes unless you know what you are doing. > Please use [#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E) Slack channel for feedback. #### 8 package(s) are going to be relocated: | Id | Target folder | | -- | ------------- | | `@kbn/io-ts-utils` | `src/platform/packages/shared/kbn-io-ts-utils` | | `@kbn/server-route-repository` | `src/platform/packages/shared/kbn-server-route-repository` | | `@kbn/server-route-repository-client` | `src/platform/packages/shared/kbn-server-route-repository-client` | | `@kbn/server-route-repository-utils` | `src/platform/packages/shared/kbn-server-route-repository-utils` | | `@kbn/sse-utils` | `src/platform/packages/shared/kbn-sse-utils` | | `@kbn/sse-utils-client` | `src/platform/packages/shared/kbn-sse-utils-client` | | `@kbn/sse-utils-server` | `src/platform/packages/private/kbn-sse-utils-server` | | `@kbn/typed-react-router-config` | `src/platform/packages/shared/kbn-typed-react-router-config` | <details> <summary>Updated references</summary> ``` ./.i18nrc.json ./package.json ./packages/kbn-repo-packages/package-map.json ./packages/kbn-ts-projects/config-paths.json ./src/platform/packages/private/kbn-sse-utils-server/jest.config.js ./src/platform/packages/shared/kbn-io-ts-utils/jest.config.js ./src/platform/packages/shared/kbn-server-route-repository-client/jest.config.js ./src/platform/packages/shared/kbn-server-route-repository-utils/jest.config.js ./src/platform/packages/shared/kbn-server-route-repository/jest.config.js ./src/platform/packages/shared/kbn-sse-utils-client/jest.config.js ./src/platform/packages/shared/kbn-sse-utils/jest.config.js ./src/platform/packages/shared/kbn-typed-react-router-config/jest.config.js ./tsconfig.base.json ./yarn.lock ``` </details> <details> <summary>Updated relative paths</summary> ``` src/platform/packages/private/kbn-sse-utils-server/jest.config.js:12 src/platform/packages/private/kbn-sse-utils-server/tsconfig.json:2 src/platform/packages/shared/kbn-io-ts-utils/jest.config.js:12 src/platform/packages/shared/kbn-io-ts-utils/tsconfig.json:2 src/platform/packages/shared/kbn-server-route-repository-client/jest.config.js:12 src/platform/packages/shared/kbn-server-route-repository-client/tsconfig.json:2 src/platform/packages/shared/kbn-server-route-repository-utils/jest.config.js:12 src/platform/packages/shared/kbn-server-route-repository-utils/tsconfig.json:2 src/platform/packages/shared/kbn-server-route-repository/jest.config.js:12 src/platform/packages/shared/kbn-server-route-repository/tsconfig.json:2 src/platform/packages/shared/kbn-sse-utils-client/jest.config.js:12 src/platform/packages/shared/kbn-sse-utils-client/tsconfig.json:2 src/platform/packages/shared/kbn-sse-utils/jest.config.js:12 src/platform/packages/shared/kbn-sse-utils/tsconfig.json:2 src/platform/packages/shared/kbn-typed-react-router-config/jest.config.js:12 src/platform/packages/shared/kbn-typed-react-router-config/tsconfig.json:2 ``` </details> <details> <summary>Script errors</summary> ``` ``` </details> (cherry picked from commit 0147e74) # Conflicts: # .github/CODEOWNERS # package.json # tsconfig.base.json # yarn.lock
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…c/obs-knowledge-team` (#202766) (#204325) # Backport This will backport the following commits from `main` to `8.x`: - [Sustainable Kibana Architecture: Move modules owned by `@elastic/obs-knowledge-team` (#202766)](#202766) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Gerard Soldevila","email":"gerard.soldevila@elastic.co"},"sourceCommit":{"committedDate":"2024-12-13T11:43:28Z","message":"Sustainable Kibana Architecture: Move modules owned by `@elastic/obs-knowledge-team` (#202766)\n\n## Summary\r\n\r\nThis PR aims at relocating some of the Kibana modules (plugins and\r\npackages) into a new folder structure, according to the _Sustainable\r\nKibana Architecture_ initiative.\r\n\r\n> [!IMPORTANT]\r\n> * We kindly ask you to:\r\n> * Manually fix the errors in the error section below (if there are\r\nany).\r\n> * Search for the `packages[\\/\\\\]` and `plugins[\\/\\\\]` patterns in the\r\nsource code (Babel and Eslint config files), and update them\r\nappropriately.\r\n> * Manually review\r\n`.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that\r\nany CI pipeline customizations continue to be correctly applied after\r\nthe changed path names\r\n> * Review all of the updated files, specially the `.ts` and `.js` files\r\nlisted in the sections below, as some of them contain relative paths\r\nthat have been updated.\r\n> * Think of potential impact of the move, including tooling and\r\nconfiguration files that can be pointing to the relocated modules. E.g.:\r\n> * customised eslint rules\r\n> * docs pointing to source code\r\n\r\n> [!NOTE]\r\n> This PR has been auto-generated.\r\n> Do not attempt to push any changes unless you know what you are doing.\r\n> Please use\r\n[#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E)\r\nSlack channel for feedback.\r\n\r\n\r\n#### 8 package(s) are going to be relocated:\r\n\r\n | Id | Target folder |\r\n | -- | ------------- |\r\n| `@kbn/io-ts-utils` | `src/platform/packages/shared/kbn-io-ts-utils` |\r\n| `@kbn/server-route-repository` |\r\n`src/platform/packages/shared/kbn-server-route-repository` |\r\n| `@kbn/server-route-repository-client` |\r\n`src/platform/packages/shared/kbn-server-route-repository-client` |\r\n| `@kbn/server-route-repository-utils` |\r\n`src/platform/packages/shared/kbn-server-route-repository-utils` |\r\n| `@kbn/sse-utils` | `src/platform/packages/shared/kbn-sse-utils` |\r\n| `@kbn/sse-utils-client` |\r\n`src/platform/packages/shared/kbn-sse-utils-client` |\r\n| `@kbn/sse-utils-server` |\r\n`src/platform/packages/private/kbn-sse-utils-server` |\r\n| `@kbn/typed-react-router-config` |\r\n`src/platform/packages/shared/kbn-typed-react-router-config` |\r\n\r\n\r\n<details>\r\n<summary>Updated references</summary>\r\n\r\n```\r\n./.i18nrc.json\r\n./package.json\r\n./packages/kbn-repo-packages/package-map.json\r\n./packages/kbn-ts-projects/config-paths.json\r\n./src/platform/packages/private/kbn-sse-utils-server/jest.config.js\r\n./src/platform/packages/shared/kbn-io-ts-utils/jest.config.js\r\n./src/platform/packages/shared/kbn-server-route-repository-client/jest.config.js\r\n./src/platform/packages/shared/kbn-server-route-repository-utils/jest.config.js\r\n./src/platform/packages/shared/kbn-server-route-repository/jest.config.js\r\n./src/platform/packages/shared/kbn-sse-utils-client/jest.config.js\r\n./src/platform/packages/shared/kbn-sse-utils/jest.config.js\r\n./src/platform/packages/shared/kbn-typed-react-router-config/jest.config.js\r\n./tsconfig.base.json\r\n./yarn.lock\r\n```\r\n</details>\r\n<details>\r\n<summary>Updated relative paths</summary>\r\n\r\n```\r\nsrc/platform/packages/private/kbn-sse-utils-server/jest.config.js:12\r\nsrc/platform/packages/private/kbn-sse-utils-server/tsconfig.json:2\r\nsrc/platform/packages/shared/kbn-io-ts-utils/jest.config.js:12\r\nsrc/platform/packages/shared/kbn-io-ts-utils/tsconfig.json:2\r\nsrc/platform/packages/shared/kbn-server-route-repository-client/jest.config.js:12\r\nsrc/platform/packages/shared/kbn-server-route-repository-client/tsconfig.json:2\r\nsrc/platform/packages/shared/kbn-server-route-repository-utils/jest.config.js:12\r\nsrc/platform/packages/shared/kbn-server-route-repository-utils/tsconfig.json:2\r\nsrc/platform/packages/shared/kbn-server-route-repository/jest.config.js:12\r\nsrc/platform/packages/shared/kbn-server-route-repository/tsconfig.json:2\r\nsrc/platform/packages/shared/kbn-sse-utils-client/jest.config.js:12\r\nsrc/platform/packages/shared/kbn-sse-utils-client/tsconfig.json:2\r\nsrc/platform/packages/shared/kbn-sse-utils/jest.config.js:12\r\nsrc/platform/packages/shared/kbn-sse-utils/tsconfig.json:2\r\nsrc/platform/packages/shared/kbn-typed-react-router-config/jest.config.js:12\r\nsrc/platform/packages/shared/kbn-typed-react-router-config/tsconfig.json:2\r\n```\r\n</details>\r\n<details>\r\n<summary>Script errors</summary>\r\n\r\n```\r\n\r\n```\r\n</details>","sha":"0147e7456e4540dc691bdb10b46f58adaa1240b4","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:skip","v9.0.0","backport:prev-minor","Team:obs-knowledge"],"number":202766,"url":"https://github.com/elastic/kibana/pull/202766","mergeCommit":{"message":"Sustainable Kibana Architecture: Move modules owned by `@elastic/obs-knowledge-team` (#202766)\n\n## Summary\r\n\r\nThis PR aims at relocating some of the Kibana modules (plugins and\r\npackages) into a new folder structure, according to the _Sustainable\r\nKibana Architecture_ initiative.\r\n\r\n> [!IMPORTANT]\r\n> * We kindly ask you to:\r\n> * Manually fix the errors in the error section below (if there are\r\nany).\r\n> * Search for the `packages[\\/\\\\]` and `plugins[\\/\\\\]` patterns in the\r\nsource code (Babel and Eslint config files), and update them\r\nappropriately.\r\n> * Manually review\r\n`.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that\r\nany CI pipeline customizations continue to be correctly applied after\r\nthe changed path names\r\n> * Review all of the updated files, specially the `.ts` and `.js` files\r\nlisted in the sections below, as some of them contain relative paths\r\nthat have been updated.\r\n> * Think of potential impact of the move, including tooling and\r\nconfiguration files that can be pointing to the relocated modules. E.g.:\r\n> * customised eslint rules\r\n> * docs pointing to source code\r\n\r\n> [!NOTE]\r\n> This PR has been auto-generated.\r\n> Do not attempt to push any changes unless you know what you are doing.\r\n> Please use\r\n[#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E)\r\nSlack channel for feedback.\r\n\r\n\r\n#### 8 package(s) are going to be relocated:\r\n\r\n | Id | Target folder |\r\n | -- | ------------- |\r\n| `@kbn/io-ts-utils` | `src/platform/packages/shared/kbn-io-ts-utils` |\r\n| `@kbn/server-route-repository` |\r\n`src/platform/packages/shared/kbn-server-route-repository` |\r\n| `@kbn/server-route-repository-client` |\r\n`src/platform/packages/shared/kbn-server-route-repository-client` |\r\n| `@kbn/server-route-repository-utils` |\r\n`src/platform/packages/shared/kbn-server-route-repository-utils` |\r\n| `@kbn/sse-utils` | `src/platform/packages/shared/kbn-sse-utils` |\r\n| `@kbn/sse-utils-client` |\r\n`src/platform/packages/shared/kbn-sse-utils-client` |\r\n| `@kbn/sse-utils-server` |\r\n`src/platform/packages/private/kbn-sse-utils-server` |\r\n| `@kbn/typed-react-router-config` |\r\n`src/platform/packages/shared/kbn-typed-react-router-config` |\r\n\r\n\r\n<details>\r\n<summary>Updated references</summary>\r\n\r\n```\r\n./.i18nrc.json\r\n./package.json\r\n./packages/kbn-repo-packages/package-map.json\r\n./packages/kbn-ts-projects/config-paths.json\r\n./src/platform/packages/private/kbn-sse-utils-server/jest.config.js\r\n./src/platform/packages/shared/kbn-io-ts-utils/jest.config.js\r\n./src/platform/packages/shared/kbn-server-route-repository-client/jest.config.js\r\n./src/platform/packages/shared/kbn-server-route-repository-utils/jest.config.js\r\n./src/platform/packages/shared/kbn-server-route-repository/jest.config.js\r\n./src/platform/packages/shared/kbn-sse-utils-client/jest.config.js\r\n./src/platform/packages/shared/kbn-sse-utils/jest.config.js\r\n./src/platform/packages/shared/kbn-typed-react-router-config/jest.config.js\r\n./tsconfig.base.json\r\n./yarn.lock\r\n```\r\n</details>\r\n<details>\r\n<summary>Updated relative paths</summary>\r\n\r\n```\r\nsrc/platform/packages/private/kbn-sse-utils-server/jest.config.js:12\r\nsrc/platform/packages/private/kbn-sse-utils-server/tsconfig.json:2\r\nsrc/platform/packages/shared/kbn-io-ts-utils/jest.config.js:12\r\nsrc/platform/packages/shared/kbn-io-ts-utils/tsconfig.json:2\r\nsrc/platform/packages/shared/kbn-server-route-repository-client/jest.config.js:12\r\nsrc/platform/packages/shared/kbn-server-route-repository-client/tsconfig.json:2\r\nsrc/platform/packages/shared/kbn-server-route-repository-utils/jest.config.js:12\r\nsrc/platform/packages/shared/kbn-server-route-repository-utils/tsconfig.json:2\r\nsrc/platform/packages/shared/kbn-server-route-repository/jest.config.js:12\r\nsrc/platform/packages/shared/kbn-server-route-repository/tsconfig.json:2\r\nsrc/platform/packages/shared/kbn-sse-utils-client/jest.config.js:12\r\nsrc/platform/packages/shared/kbn-sse-utils-client/tsconfig.json:2\r\nsrc/platform/packages/shared/kbn-sse-utils/jest.config.js:12\r\nsrc/platform/packages/shared/kbn-sse-utils/tsconfig.json:2\r\nsrc/platform/packages/shared/kbn-typed-react-router-config/jest.config.js:12\r\nsrc/platform/packages/shared/kbn-typed-react-router-config/tsconfig.json:2\r\n```\r\n</details>\r\n<details>\r\n<summary>Script errors</summary>\r\n\r\n```\r\n\r\n```\r\n</details>","sha":"0147e7456e4540dc691bdb10b46f58adaa1240b4"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202766","number":202766,"mergeCommit":{"message":"Sustainable Kibana Architecture: Move modules owned by `@elastic/obs-knowledge-team` (#202766)\n\n## Summary\r\n\r\nThis PR aims at relocating some of the Kibana modules (plugins and\r\npackages) into a new folder structure, according to the _Sustainable\r\nKibana Architecture_ initiative.\r\n\r\n> [!IMPORTANT]\r\n> * We kindly ask you to:\r\n> * Manually fix the errors in the error section below (if there are\r\nany).\r\n> * Search for the `packages[\\/\\\\]` and `plugins[\\/\\\\]` patterns in the\r\nsource code (Babel and Eslint config files), and update them\r\nappropriately.\r\n> * Manually review\r\n`.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that\r\nany CI pipeline customizations continue to be correctly applied after\r\nthe changed path names\r\n> * Review all of the updated files, specially the `.ts` and `.js` files\r\nlisted in the sections below, as some of them contain relative paths\r\nthat have been updated.\r\n> * Think of potential impact of the move, including tooling and\r\nconfiguration files that can be pointing to the relocated modules. E.g.:\r\n> * customised eslint rules\r\n> * docs pointing to source code\r\n\r\n> [!NOTE]\r\n> This PR has been auto-generated.\r\n> Do not attempt to push any changes unless you know what you are doing.\r\n> Please use\r\n[#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E)\r\nSlack channel for feedback.\r\n\r\n\r\n#### 8 package(s) are going to be relocated:\r\n\r\n | Id | Target folder |\r\n | -- | ------------- |\r\n| `@kbn/io-ts-utils` | `src/platform/packages/shared/kbn-io-ts-utils` |\r\n| `@kbn/server-route-repository` |\r\n`src/platform/packages/shared/kbn-server-route-repository` |\r\n| `@kbn/server-route-repository-client` |\r\n`src/platform/packages/shared/kbn-server-route-repository-client` |\r\n| `@kbn/server-route-repository-utils` |\r\n`src/platform/packages/shared/kbn-server-route-repository-utils` |\r\n| `@kbn/sse-utils` | `src/platform/packages/shared/kbn-sse-utils` |\r\n| `@kbn/sse-utils-client` |\r\n`src/platform/packages/shared/kbn-sse-utils-client` |\r\n| `@kbn/sse-utils-server` |\r\n`src/platform/packages/private/kbn-sse-utils-server` |\r\n| `@kbn/typed-react-router-config` |\r\n`src/platform/packages/shared/kbn-typed-react-router-config` |\r\n\r\n\r\n<details>\r\n<summary>Updated references</summary>\r\n\r\n```\r\n./.i18nrc.json\r\n./package.json\r\n./packages/kbn-repo-packages/package-map.json\r\n./packages/kbn-ts-projects/config-paths.json\r\n./src/platform/packages/private/kbn-sse-utils-server/jest.config.js\r\n./src/platform/packages/shared/kbn-io-ts-utils/jest.config.js\r\n./src/platform/packages/shared/kbn-server-route-repository-client/jest.config.js\r\n./src/platform/packages/shared/kbn-server-route-repository-utils/jest.config.js\r\n./src/platform/packages/shared/kbn-server-route-repository/jest.config.js\r\n./src/platform/packages/shared/kbn-sse-utils-client/jest.config.js\r\n./src/platform/packages/shared/kbn-sse-utils/jest.config.js\r\n./src/platform/packages/shared/kbn-typed-react-router-config/jest.config.js\r\n./tsconfig.base.json\r\n./yarn.lock\r\n```\r\n</details>\r\n<details>\r\n<summary>Updated relative paths</summary>\r\n\r\n```\r\nsrc/platform/packages/private/kbn-sse-utils-server/jest.config.js:12\r\nsrc/platform/packages/private/kbn-sse-utils-server/tsconfig.json:2\r\nsrc/platform/packages/shared/kbn-io-ts-utils/jest.config.js:12\r\nsrc/platform/packages/shared/kbn-io-ts-utils/tsconfig.json:2\r\nsrc/platform/packages/shared/kbn-server-route-repository-client/jest.config.js:12\r\nsrc/platform/packages/shared/kbn-server-route-repository-client/tsconfig.json:2\r\nsrc/platform/packages/shared/kbn-server-route-repository-utils/jest.config.js:12\r\nsrc/platform/packages/shared/kbn-server-route-repository-utils/tsconfig.json:2\r\nsrc/platform/packages/shared/kbn-server-route-repository/jest.config.js:12\r\nsrc/platform/packages/shared/kbn-server-route-repository/tsconfig.json:2\r\nsrc/platform/packages/shared/kbn-sse-utils-client/jest.config.js:12\r\nsrc/platform/packages/shared/kbn-sse-utils-client/tsconfig.json:2\r\nsrc/platform/packages/shared/kbn-sse-utils/jest.config.js:12\r\nsrc/platform/packages/shared/kbn-sse-utils/tsconfig.json:2\r\nsrc/platform/packages/shared/kbn-typed-react-router-config/jest.config.js:12\r\nsrc/platform/packages/shared/kbn-typed-react-router-config/tsconfig.json:2\r\n```\r\n</details>\r\n<details>\r\n<summary>Script errors</summary>\r\n\r\n```\r\n\r\n```\r\n</details>","sha":"0147e7456e4540dc691bdb10b46f58adaa1240b4"}}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Summary
This PR aims at relocating some of the Kibana modules (plugins and packages) into a new folder structure, according to the Sustainable Kibana Architecture initiative.
Important
packages[\/\\]andplugins[\/\\]patterns in the source code (Babel and Eslint config files), and update them appropriately..buildkite/scripts/pipelines/pull_request/pipeline.tsto ensure that any CI pipeline customizations continue to be correctly applied after the changed path names.tsand.jsfiles listed in the sections below, as some of them contain relative paths that have been updated.Note
8 packages(s) are going to be relocated:
@kbn/io-ts-utilssrc/platform/packages/shared/kbn-io-ts-utils@kbn/server-route-repositorysrc/platform/packages/shared/kbn-server-route-repository@kbn/server-route-repository-clientsrc/platform/packages/shared/kbn-server-route-repository-client@kbn/server-route-repository-utilssrc/platform/packages/shared/kbn-server-route-repository-utils@kbn/sse-utilssrc/platform/packages/shared/kbn-sse-utils@kbn/sse-utils-clientsrc/platform/packages/shared/kbn-sse-utils-client@kbn/sse-utils-serversrc/platform/packages/shared/kbn-sse-utils-server@kbn/typed-react-router-configsrc/platform/packages/shared/kbn-typed-react-router-configUpdated references
Updated relative paths