[ObsUX] Unskip failing test#196727
Merged
MiriamAparicio merged 6 commits intoelastic:mainfrom Oct 24, 2024
Merged
Conversation
Contributor
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
Contributor
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
Contributor
Author
|
Flaky test runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7168 |
Contributor
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#7168[❌] APM - Cypress: 0/50 tests passed. |
Contributor
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#7181[❌] APM - Cypress: 8/50 tests passed. |
Contributor
💚 Build Succeeded
Metrics [docs]
History
|
rmyz
reviewed
Oct 24, 2024
|
|
||
| describe('Transaction details', () => { | ||
| // flaky | ||
| describe.skip('Transaction details', () => { |
Contributor
There was a problem hiding this comment.
Is this needed? Yesterday I skipped 2 flaky tests from this suite
Contributor
Author
There was a problem hiding this comment.
I think it's better to skip the whole test suite as we don't know exactly what's the issue here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #191961