Skip to content

[Security Solution] Removes unmaintained tests#197408

Merged
MadameSheema merged 6 commits intoelastic:mainfrom
MadameSheema:removing-navigation-test
Oct 24, 2024
Merged

[Security Solution] Removes unmaintained tests#197408
MadameSheema merged 6 commits intoelastic:mainfrom
MadameSheema:removing-navigation-test

Conversation

@MadameSheema
Copy link
Copy Markdown
Contributor

@MadameSheema MadameSheema commented Oct 23, 2024

Summary

Deleting some tests that we don't maintain since we don't use the test_serverless folder for our serverless tests, in that way we'll prevent misunderstandings regarding ownership of it.

@MadameSheema MadameSheema added release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. backport:prev-major v8.16.0 v8.17.0 labels Oct 23, 2024
@MadameSheema MadameSheema requested a review from semd October 23, 2024 11:26
@MadameSheema MadameSheema self-assigned this Oct 23, 2024
@MadameSheema MadameSheema requested review from a team as code owners October 23, 2024 11:26
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Copy link
Copy Markdown
Contributor

@wayneseymour wayneseymour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sebelga
Copy link
Copy Markdown
Contributor

sebelga commented Oct 23, 2024

I think we want to keep the navigation smoke tests and set ownership to SharedUX.

We want to be able to test that our components work as expected and are accessible.
The same way we have smoke tests for the 3 solutions for the stateful side nav (https://github.com/elastic/kibana/tree/main/x-pack/test/functional_solution_sidenav).

Can you please leave this file test_serverless/functional/test_suites/security/ftr/navigation.ts? thanks

@elasticmachine
Copy link
Copy Markdown
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #7 / edit package policy page modify agent policies should create agent policy with sys monitoring when new agent policy button is clicked
  • [job] [logs] Jest Tests #7 / edit package policy page modify agent policies should not remove managed policy when policies are modified
  • [job] [logs] Jest Tests #7 / edit package policy page should disable submit button on invalid form with empty package var
  • [job] [logs] Jest Tests #7 / edit package policy page should navigate on submit
  • [job] [logs] Jest Tests #7 / edit package policy page should show generic error on other statusCode on submit
  • [job] [logs] Jest Tests #7 / edit package policy page should show out of date error on 409 statusCode on submit

Metrics [docs]

✅ unchanged

History

cc @MadameSheema

@MadameSheema MadameSheema merged commit 6ae07b3 into elastic:main Oct 24, 2024
@MadameSheema MadameSheema deleted the removing-navigation-test branch October 24, 2024 10:46
@kibanamachine
Copy link
Copy Markdown
Contributor

Starting backport for target branches: 8.15, 8.16, 8.x

https://github.com/elastic/kibana/actions/runs/11497726242

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 24, 2024
## Summary

Deleting some tests that we don't maintain since we don't use the
`test_serverless` folder for our serverless tests, in that way we'll
prevent misunderstandings regarding ownership of it.

(cherry picked from commit 6ae07b3)
@kibanamachine
Copy link
Copy Markdown
Contributor

💔 Some backports could not be created

Status Branch Result
8.15 Backport failed because of merge conflicts
8.16 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.16:
- [Discover][Embeddable] Pass embeddable filters to Surrounding Docs page (#197190)
- [ObsUX] Unskip failing test (#196727)
- [SecuritySolution] Add tooltip to entities table (#197430)
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 197408

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 24, 2024
# Backport

This will backport the following commits from `main` to `8.x`:
- [[Security Solution] Removes unmaintained tests
(#197408)](#197408)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Gloria
Hornero","email":"gloria.hornero@elastic.co"},"sourceCommit":{"committedDate":"2024-10-24T10:46:30Z","message":"[Security
Solution] Removes unmaintained tests (#197408)\n\n##
Summary\r\n\r\nDeleting some tests that we don't maintain since we don't
use the\r\n`test_serverless` folder for our serverless tests, in that
way we'll\r\nprevent misunderstandings regarding ownership of
it.","sha":"6ae07b382dc134a50b854c56f61cbc78225acbd9","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:
SecuritySolution","backport:prev-major","v8.16.0","v8.17.0"],"title":"[Security
Solution] Removes unmaintained
tests","number":197408,"url":"https://github.com/elastic/kibana/pull/197408","mergeCommit":{"message":"[Security
Solution] Removes unmaintained tests (#197408)\n\n##
Summary\r\n\r\nDeleting some tests that we don't maintain since we don't
use the\r\n`test_serverless` folder for our serverless tests, in that
way we'll\r\nprevent misunderstandings regarding ownership of
it.","sha":"6ae07b382dc134a50b854c56f61cbc78225acbd9"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197408","number":197408,"mergeCommit":{"message":"[Security
Solution] Removes unmaintained tests (#197408)\n\n##
Summary\r\n\r\nDeleting some tests that we don't maintain since we don't
use the\r\n`test_serverless` folder for our serverless tests, in that
way we'll\r\nprevent misunderstandings regarding ownership of
it.","sha":"6ae07b382dc134a50b854c56f61cbc78225acbd9"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Gloria Hornero <gloria.hornero@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.16.0 v8.17.0 v9.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants