Skip to content

[ObsUX] Unskip failing test #196727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MiriamAparicio merged 6 commits into from
Oct 24, 2024
Merged

[ObsUX] Unskip failing test #196727

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
59e0e0d
unskip failing test
MiriamAparicio Oct 17, 2024
13c71a8
skip flaky storage_explorer test suite
MiriamAparicio Oct 18, 2024
4363963
skip transaction_details flaky test
MiriamAparicio Oct 23, 2024
2fffa2b
Merge branch 'main' into 191961-fix-skipped-tests
MiriamAparicio Oct 23, 2024
06f5d83
Merge branch 'main' into 191961-fix-skipped-tests
MiriamAparicio Oct 23, 2024
5051614
Merge branch 'main' into 191961-fix-skipped-tests
MiriamAparicio Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .../observability_solution/apm/ftr_e2e/cypress/e2e/service_inventory/service_inventory.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,7 @@ const mainApiRequestsToIntercept = [

const mainAliasNames = mainApiRequestsToIntercept.map(({ aliasName }) => `@${aliasName}`);

// See details: https://github.com/elastic/kibana/issues/191961
describe.skip('Service inventory', () => {
describe('Service inventory', () => {
before(() => {
const { rangeFrom, rangeTo } = timeRange;
synthtrace.index(
Expand Down
2 changes: 1 addition & 1 deletion ...tion/apm/ftr_e2e/cypress/e2e/service_overview/mobile_overview_with_most_used_charts.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ const apmMobileServiceOverview = url.format({
rangeTo,
},
});
describe.skip('Mobile Service overview page', () => {
describe('Mobile Service overview page', () => {
before(() => {
synthtrace.index(
generateMobileData({
Expand Down
3 changes: 1 addition & 2 deletions ...ns/observability_solution/apm/ftr_e2e/cypress/e2e/service_overview/service_overview.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,7 @@ const aliasNamesWithComparison = apiRequestsToInterceptWithComparison.map(

const aliasNames = [...aliasNamesNoComparison, ...aliasNamesWithComparison];

// See details: https://github.com/elastic/kibana/issues/191961
describe.skip('Service Overview', () => {
describe('Service Overview', () => {
before(() => {
synthtrace.index(
opbeans({
Expand Down
3 changes: 1 addition & 2 deletions ...ns/observability_solution/apm/ftr_e2e/cypress/e2e/storage_explorer/storage_explorer.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,7 @@ const mainApiRequestsToIntercept = [
];

const mainAliasNames = mainApiRequestsToIntercept.map(({ aliasName }) => `@${aliasName}`);

// See details: https://github.com/elastic/kibana/issues/191961
// flaky test
describe.skip('Storage Explorer', () => {
before(() => {
const { rangeFrom, rangeTo } = timeRange;
Expand Down
4 changes: 2 additions & 2 deletions ...ervability_solution/apm/ftr_e2e/cypress/e2e/transaction_details/transaction_details.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ const timeRange = {
rangeFrom: start,
rangeTo: end,
};

describe('Transaction details', () => {
// flaky
describe.skip('Transaction details', () => {
Copy link
Copy Markdown
Contributor

@rmyz rmyz Oct 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed? Yesterday I skipped 2 flaky tests from this suite

Copy link
Copy Markdown
Contributor Author

@MiriamAparicio MiriamAparicio Oct 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to skip the whole test suite as we don't know exactly what's the issue here

before(() => {
synthtrace.index(
opbeans({
Expand Down