Consume elasticsearch.publicBaseUrl where possible#192741
Merged
sphilipse merged 20 commits intoelastic:mainfrom Sep 19, 2024
Merged
Consume elasticsearch.publicBaseUrl where possible#192741sphilipse merged 20 commits intoelastic:mainfrom
sphilipse merged 20 commits intoelastic:mainfrom
Conversation
sphilipse
added
release_note:skip
x-pack/plugins/search_indices/public/hooks/use_elasticsearch_url.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/serverless_search/public/application/components/overview.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Rodney Norris <rodney@tattdcodemonkey.com>
…/overview.tsx Co-authored-by: Rodney Norris <rodney@tattdcodemonkey.com>
sabarasaba
approved these changes
Sep 18, 2024
Member
sabarasaba
left a comment
sabarasaba
left a comment
There was a problem hiding this comment.
index management changes lgtm
afharo
approved these changes
Sep 18, 2024
Member
afharo
left a comment
afharo
left a comment
There was a problem hiding this comment.
LGTM. I just added a few comments for me to familiarize myself with this code and with some minor suggestions.
TattdCodeMonkey
approved these changes
Sep 18, 2024
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Public APIs missing exports
Page load bundle
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 19, 2024
## Summary This actually consumes the public base url in the cloud plugin and the places depending on the `elasticsearchUrl` value populated there. --------- Co-authored-by: Rodney Norris <rodney@tattdcodemonkey.com> (cherry picked from commit b4a7b2e)
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
Member
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
sphilipse
added a commit
to sphilipse/kibana
that referenced
this pull request
Sep 24, 2024
## Summary This actually consumes the public base url in the cloud plugin and the places depending on the `elasticsearchUrl` value populated there. --------- Co-authored-by: Rodney Norris <rodney@tattdcodemonkey.com> (cherry picked from commit b4a7b2e)
kibanamachine
added a commit
that referenced
this pull request
Sep 24, 2024
…193442) # Backport This will backport the following commits from `main` to `8.x`: - [Consume elasticsearch.publicBaseUrl where possible (#192741)](#192741) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sander Philipse","email":"94373878+sphilipse@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-09-19T14:57:47Z","message":"Consume elasticsearch.publicBaseUrl where possible (#192741)\n\n## Summary\r\n\r\nThis actually consumes the public base url in the cloud plugin and the\r\nplaces depending on the `elasticsearchUrl` value populated there.\r\n\r\n---------\r\n\r\nCo-authored-by: Rodney Norris <rodney@tattdcodemonkey.com>","sha":"b4a7b2e2164974e5dd9b8c1708c35d58bd021105","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Search","backport:prev-major","v8.16.0"],"title":"Consume elasticsearch.publicBaseUrl where possible","number":192741,"url":"https://github.com/elastic/kibana/pull/192741","mergeCommit":{"message":"Consume elasticsearch.publicBaseUrl where possible (#192741)\n\n## Summary\r\n\r\nThis actually consumes the public base url in the cloud plugin and the\r\nplaces depending on the `elasticsearchUrl` value populated there.\r\n\r\n---------\r\n\r\nCo-authored-by: Rodney Norris <rodney@tattdcodemonkey.com>","sha":"b4a7b2e2164974e5dd9b8c1708c35d58bd021105"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/192741","number":192741,"mergeCommit":{"message":"Consume elasticsearch.publicBaseUrl where possible (#192741)\n\n## Summary\r\n\r\nThis actually consumes the public base url in the cloud plugin and the\r\nplaces depending on the `elasticsearchUrl` value populated there.\r\n\r\n---------\r\n\r\nCo-authored-by: Rodney Norris <rodney@tattdcodemonkey.com>","sha":"b4a7b2e2164974e5dd9b8c1708c35d58bd021105"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Sander Philipse <94373878+sphilipse@users.noreply.github.com>
sphilipse
added a commit
that referenced
this pull request
Sep 24, 2024
…193838) # Backport This will backport the following commits from `main` to `8.x`: - [Consume elasticsearch.publicBaseUrl where possible (#192741)](#192741) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sander Philipse","email":"94373878+sphilipse@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-09-19T14:57:47Z","message":"Consume elasticsearch.publicBaseUrl where possible (#192741)\n\n## Summary\r\n\r\nThis actually consumes the public base url in the cloud plugin and the\r\nplaces depending on the `elasticsearchUrl` value populated there.\r\n\r\n---------\r\n\r\nCo-authored-by: Rodney Norris <rodney@tattdcodemonkey.com>","sha":"b4a7b2e2164974e5dd9b8c1708c35d58bd021105","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Search","backport:prev-major","v8.16.0"],"number":192741,"url":"https://github.com/elastic/kibana/pull/192741","mergeCommit":{"message":"Consume elasticsearch.publicBaseUrl where possible (#192741)\n\n## Summary\r\n\r\nThis actually consumes the public base url in the cloud plugin and the\r\nplaces depending on the `elasticsearchUrl` value populated there.\r\n\r\n---------\r\n\r\nCo-authored-by: Rodney Norris <rodney@tattdcodemonkey.com>","sha":"b4a7b2e2164974e5dd9b8c1708c35d58bd021105"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/192741","number":192741,"mergeCommit":{"message":"Consume elasticsearch.publicBaseUrl where possible (#192741)\n\n## Summary\r\n\r\nThis actually consumes the public base url in the cloud plugin and the\r\nplaces depending on the `elasticsearchUrl` value populated there.\r\n\r\n---------\r\n\r\nCo-authored-by: Rodney Norris <rodney@tattdcodemonkey.com>","sha":"b4a7b2e2164974e5dd9b8c1708c35d58bd021105"}},{"branch":"8.x","label":"v8.16.0","labelRegex":"^v8.16.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/193442","number":193442,"state":"OPEN"}]}] BACKPORT-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This actually consumes the public base url in the cloud plugin and the places depending on the
elasticsearchUrlvalue populated there.