Skip to content

Allow elasticsearch.publicBaseUrl to be set using an environment variable#193716

Merged
sphilipse merged 1 commit intoelastic:mainfrom
sphilipse:allow-public-base-url-setting-from-env-var
Sep 23, 2024
Merged

Allow elasticsearch.publicBaseUrl to be set using an environment variable#193716
sphilipse merged 1 commit intoelastic:mainfrom
sphilipse:allow-public-base-url-setting-from-env-var

Conversation

@sphilipse
Copy link
Copy Markdown
Member

@sphilipse sphilipse commented Sep 23, 2024

Summary

Allows users to set elasticsearch.publicBaseUrl with a ELASTICSEARCH_PUBLICBASEURL environment variable.

@sphilipse sphilipse added release_note:skip Skip the PR/issue when compiling release notes backport:prev-major v8.16.0 backport:version Backport to applied version labels and removed backport:prev-major labels Sep 23, 2024
@sphilipse sphilipse marked this pull request as ready for review September 23, 2024 12:48
@sphilipse sphilipse requested review from a team as code owners September 23, 2024 12:48
@kibana-ci
Copy link
Copy Markdown

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #10 / AllCasesSelectorModal Closing modal when pressing the x icon
  • [job] [logs] Jest Tests #10 / TheHive Cases Fields sets TLP correctly

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sphilipse sphilipse merged commit be80022 into elastic:main Sep 23, 2024
@kibanamachine
Copy link
Copy Markdown
Contributor

💔 All backports failed

Status Branch Result
8.x Backport failed because of merge conflicts

You might need to backport the following PRs to 8.x:
- Consume elasticsearch.publicBaseUrl where possible (#192741)

Manual backport

To create the backport manually run:

node scripts/backport --pr 193716

Questions ?

Please refer to the Backport tool documentation

sphilipse added a commit to sphilipse/kibana that referenced this pull request Sep 24, 2024
…able (elastic#193716)

## Summary

Allows users to set `elasticsearch.publicBaseUrl` with a
ELASTICSEARCH_PUBLICBASEURL environment variable.

(cherry picked from commit be80022)
@sphilipse
Copy link
Copy Markdown
Member Author

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

sphilipse added a commit that referenced this pull request Sep 24, 2024
…t variable (#193716) (#193860)

# Backport

This will backport the following commits from `main` to `8.x`:
- [Allow elasticsearch.publicBaseUrl to be set using an environment
variable (#193716)](#193716)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Sander
Philipse","email":"94373878+sphilipse@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-09-23T16:43:45Z","message":"Allow
elasticsearch.publicBaseUrl to be set using an environment variable
(#193716)\n\n## Summary\r\n\r\nAllows users to set
`elasticsearch.publicBaseUrl` with a\r\nELASTICSEARCH_PUBLICBASEURL
environment
variable.","sha":"be8002215411633cfe913d3110ae74d64092c580","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","v8.16.0","backport:version"],"number":193716,"url":"https://github.com/elastic/kibana/pull/193716","mergeCommit":{"message":"Allow
elasticsearch.publicBaseUrl to be set using an environment variable
(#193716)\n\n## Summary\r\n\r\nAllows users to set
`elasticsearch.publicBaseUrl` with a\r\nELASTICSEARCH_PUBLICBASEURL
environment
variable.","sha":"be8002215411633cfe913d3110ae74d64092c580"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193716","number":193716,"mergeCommit":{"message":"Allow
elasticsearch.publicBaseUrl to be set using an environment variable
(#193716)\n\n## Summary\r\n\r\nAllows users to set
`elasticsearch.publicBaseUrl` with a\r\nELASTICSEARCH_PUBLICBASEURL
environment
variable.","sha":"be8002215411633cfe913d3110ae74d64092c580"}},{"branch":"8.x","label":"v8.16.0","labelRegex":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes v8.16.0 v9.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants