Skip to content

[8.x] Consume elasticsearch.publicBaseUrl where possible (#192741)#193838

Merged
sphilipse merged 1 commit intoelastic:8.xfrom
sphilipse:backport/8.x/pr-192741
Sep 24, 2024
Merged

[8.x] Consume elasticsearch.publicBaseUrl where possible (#192741)#193838
sphilipse merged 1 commit intoelastic:8.xfrom
sphilipse:backport/8.x/pr-192741

Conversation

@sphilipse
Copy link
Copy Markdown
Member

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

## Summary

This actually consumes the public base url in the cloud plugin and the
places depending on the `elasticsearchUrl` value populated there.

---------

Co-authored-by: Rodney Norris <rodney@tattdcodemonkey.com>
(cherry picked from commit b4a7b2e)
@sphilipse sphilipse added the backport This PR is a backport of another PR label Sep 24, 2024
@sphilipse sphilipse enabled auto-merge (squash) September 24, 2024 09:52
@sphilipse sphilipse merged commit bfac4dd into elastic:8.x Sep 24, 2024
@kibana-ci
Copy link
Copy Markdown

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.6MB 2.6MB +448.0B
fleet 1.8MB 1.8MB +122.0B
home 151.9KB 152.0KB +53.0B
indexManagement 679.7KB 679.7KB +45.0B
searchHomepage 54.8KB 54.8KB +53.0B
searchIndices 84.1KB 84.3KB +196.0B
searchPlayground 151.1KB 151.2KB +84.0B
serverlessSearch 326.9KB 327.2KB +368.0B
total +1.3KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
cloud 0 1 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
cloud 7.1KB 7.6KB +464.0B
cloudLinks 30.1KB 30.2KB +53.0B
total +517.0B
Unknown metric groups

API count

id before after diff
@kbn/core-elasticsearch-server 117 118 +1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants