[FTR] Refactor test/common/services/* -> packages/kbn-ftr-common-functional-[ui-]services/* by wayneseymour · Pull Request #189051 · elastic/kibana

wayneseymour · 2024-07-24T10:21:08Z

Summary

Moving common services to respective new homes.

Resolves: #188541

wayneseymour · 2024-07-24T11:57:32Z

/ci

wayneseymour · 2024-07-24T15:32:09Z

/ci

wayneseymour · 2024-07-24T16:04:52Z

/ci

wayneseymour · 2024-07-25T09:09:47Z

/ci

wayneseymour · 2024-07-25T15:29:03Z

/ci

wayneseymour · 2024-07-26T09:45:23Z

/ci

wayneseymour · 2024-07-29T09:21:34Z

/ci

wayneseymour · 2024-07-29T10:55:15Z

/ci

wayneseymour · 2024-07-31T13:51:25Z

/ci

wayneseymour · 2024-07-31T14:19:54Z

/ci

wayneseymour · 2024-08-01T08:59:34Z

/ci

wayneseymour · 2024-08-01T10:50:19Z

/ci

wayneseymour · 2024-08-01T12:44:13Z

/ci

wayneseymour · 2024-08-01T13:41:20Z

/ci

wayneseymour · 2024-08-27T17:00:02Z

@elasticmachine merge upstream

elasticmachine · 2024-08-27T17:00:15Z

Pinging @elastic/fleet (Team:Fleet)

davismcphee

Code-only review. Data Discovery typings file change LGTM 👍

opauloh

Cloud Security Posture changes LGTM

kibana-ci · 2024-08-27T18:29:50Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 62351aa

Failed CI Steps

Jest Tests #5

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`@kbn/ftr-common-functional-services`	32	69	+37
`@kbn/ftr-common-functional-ui-services`	511	520	+9
total			+46

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
`@kbn/ftr-common-functional-ui-services`	3	7	+4

Unknown metric groups

API count

id	before	after	diff
`@kbn/ftr-common-functional-services`	47	94	+47
`@kbn/ftr-common-functional-ui-services`	551	560	+9
total			+56

History

💚 Build #230151 succeeded 49280b3299743909acb3fc59106c0e1249698a31
💔 Build #230087 failed d36d27940da81047216158f19c0cc713d7f81516
💔 Build #229853 failed 6ade8b198d17f54a6b6ce2ab4fff88aa279e1c11
💔 Build #229761 failed 057ef8f1ce0c5386e082efef8528912eec5290c2
💔 Build #229706 failed 688b5bc05df57b81ac40c258adcf2703e39bd351
💚 Build #229501 succeeded 985420353cdce3df809e72ced121c926c82122cd

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @wayneseymour

PhilippeOberti

LGTM for the Threat Hunting Investigations team

jennypavlova

Obs Ux Infra Services changes LGTM (code review only)

TinaHeiligers

LGTM

dmlemeshko · 2024-08-29T13:40:48Z

packages/kbn-ftr-common-functional-ui-services/services/security/system_indices_user.ts

question: shouldn't we put security service in kbn-ftr-common-functional-services ?
I don't think it has any dependency on browser / Kibana UI and is used in both api_integration and functional test.

nvm, TestUser services is relying on Browser service.

You're fast dude! I was just copying the link to that! lol

dmlemeshko

Code LGTM. Great progress!

…mon-functional-[ui-]services/* (elastic#189051)" This reverts commit 09a3658.

jbudz · 2024-08-29T21:07:01Z

This was reverted in #191765.

See https://buildkite.com/elastic/kibana-pull-request/builds/230868#01919ed7-15d5-425c-9b8e-146ed5fe9daf for the build failure.

…tional-[ui-]services/* (#191805) ## Summary Moving common services to respective new homes. This PR is revived from a previously [merged](09a3658) and [reverted PR](#191765) as [detailed here](#189051 (comment)). - This was due to "extra" tests being applied to #191708 - These "extra" tests were applied as #191708 changes files within `x-pack/plugins/observability_solution/` as configured [here](https://github.com/elastic/kibana/blob/main/.buildkite/scripts/pipelines/pull_request/pipeline.ts#L129) ### Why these failures were not caught in the original [PR](#189051) The pipeline is generated at runtime, and the original [PR](#189051) had zero changes under `x-pack/plugins/observability_solution/` ## Changes on top of original PR - Add `ci:all-cypress-suites` label to run extra tests - Add `services` stanza to which contains the missing references by spreading the services from `@kbn/ftr-common-functional-services` && `@kbn/ftr-common-functional-ui-services` into the stanza, for the following: - `x-pack/plugins/observability_solution/synthetics/e2e/config.ts` - `x-pack/plugins/observability_solution/apm/ftr_e2e/ftr_config.ts` - `x-pack/plugins/observability_solution/observability_onboarding/e2e/ftr_config.ts` - `x-pack/plugins/observability_solution/profiling/e2e/ftr_config.ts` - `x-pack/plugins/observability_solution/synthetics/e2e/config.ts` - `x-pack/plugins/observability_solution/uptime/e2e/config.ts` Blocked by: #191961 Resolves: #188541 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

wayneseymour added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting labels Jul 24, 2024

wayneseymour self-assigned this Jul 24, 2024

wayneseymour changed the title ~~[FTR] Refactor test/common/services/* -> packages/kbn-ftr-common-functional-[ui]-services~~ [FTR] Refactor test/common/services/* -> packages/kbn-ftr-common-functional-[ui]-services/* Jul 24, 2024

wayneseymour changed the title ~~[FTR] Refactor test/common/services/* -> packages/kbn-ftr-common-functional-[ui]-services/*~~ [FTR] Refactor test/common/services/* -> packages/kbn-ftr-common-functional-[ui]-services/* Jul 24, 2024

wayneseymour force-pushed the ftr/refactor-test-common-services branch from b6d8466 to 8a1f919 Compare July 24, 2024 15:31

wayneseymour force-pushed the ftr/refactor-test-common-services branch from 8b8c0fb to 5b16ca2 Compare July 24, 2024 16:04

wayneseymour mentioned this pull request Jul 25, 2024

Minimize shared-common everywhere #188606

Merged

5 tasks

wayneseymour force-pushed the ftr/refactor-test-common-services branch from 526ce5c to 7d256d1 Compare July 25, 2024 15:27

wayneseymour force-pushed the ftr/refactor-test-common-services branch from 7d256d1 to 54c49d2 Compare July 26, 2024 09:44

wayneseymour changed the title [FTR] Refactor test/common/services/* -> packages/kbn-ftr-common-functional-[ui]-services/* [FTR] Refactor test/common/services/* -> packages/kbn-ftr-common-functional-[ui-]services/* Jul 28, 2024

wayneseymour force-pushed the ftr/refactor-test-common-services branch from 15e4641 to 571549d Compare July 29, 2024 09:33

wayneseymour force-pushed the ftr/refactor-test-common-services branch from 571549d to 2a54f3c Compare July 31, 2024 13:51

wayneseymour force-pushed the ftr/refactor-test-common-services branch from 06b3a76 to 2dd1322 Compare July 31, 2024 14:19

wayneseymour force-pushed the ftr/refactor-test-common-services branch from e1bfc51 to abc07f9 Compare August 1, 2024 10:49

wayneseymour force-pushed the ftr/refactor-test-common-services branch from 66ee4c9 to af59b80 Compare August 1, 2024 13:40

Merge branch 'main' into ftr/refactor-test-common-services

62351aa

botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Aug 27, 2024

davismcphee approved these changes Aug 27, 2024

View reviewed changes

opauloh approved these changes Aug 27, 2024

View reviewed changes

Ikuni17 approved these changes Aug 27, 2024

View reviewed changes

PhilippeOberti approved these changes Aug 28, 2024

View reviewed changes

sabarasaba approved these changes Aug 28, 2024

View reviewed changes

hop-dev approved these changes Aug 28, 2024

View reviewed changes

juliaElastic approved these changes Aug 28, 2024

View reviewed changes

angorayc approved these changes Aug 28, 2024

View reviewed changes

jennypavlova approved these changes Aug 28, 2024

View reviewed changes

TinaHeiligers approved these changes Aug 28, 2024

View reviewed changes

smith added the apm:review label Aug 28, 2024

wayneseymour requested a review from dmlemeshko August 29, 2024 08:05

dmlemeshko reviewed Aug 29, 2024

View reviewed changes

dmlemeshko approved these changes Aug 29, 2024

View reviewed changes

wayneseymour merged commit 09a3658 into elastic:main Aug 29, 2024

wayneseymour deleted the ftr/refactor-test-common-services branch August 29, 2024 13:46

kibanamachine added the v8.16.0 label Aug 29, 2024

jbudz added a commit to jbudz/kibana that referenced this pull request Aug 29, 2024

Revert "[FTR] Refactor test/common/services/* -> packages/kbn-ftr-com…

0894c8b

…mon-functional-[ui-]services/* (elastic#189051)" This reverts commit 09a3658.

jbudz added the reverted label Aug 29, 2024

wayneseymour restored the ftr/refactor-test-common-services branch August 30, 2024 08:22

wayneseymour mentioned this pull request Aug 30, 2024

[FTR] Refactor test/common/services/* -> packages/kbn-ftr-common-functional-[ui-]services/* #191805

Merged

PhilippeOberti mentioned this pull request Sep 20, 2024

[Security Solution] - fix Cypress not running locally #193622

Merged

Comments

Conversation

wayneseymour commented Jul 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

wayneseymour commented Jul 24, 2024

Uh oh!

wayneseymour commented Jul 24, 2024

Uh oh!

wayneseymour commented Jul 24, 2024

Uh oh!

wayneseymour commented Jul 25, 2024

Uh oh!

wayneseymour commented Jul 25, 2024

Uh oh!

wayneseymour commented Jul 26, 2024

Uh oh!

wayneseymour commented Jul 29, 2024

Uh oh!

wayneseymour commented Jul 29, 2024

Uh oh!

wayneseymour commented Jul 31, 2024

Uh oh!

wayneseymour commented Jul 31, 2024

Uh oh!

wayneseymour commented Aug 1, 2024

Uh oh!

wayneseymour commented Aug 1, 2024

Uh oh!

wayneseymour commented Aug 1, 2024

Uh oh!

wayneseymour commented Aug 1, 2024

Uh oh!

wayneseymour commented Aug 27, 2024

Uh oh!

elasticmachine commented Aug 27, 2024

Uh oh!

davismcphee left a comment

Choose a reason for hiding this comment

Uh oh!

opauloh left a comment

Choose a reason for hiding this comment

Uh oh!

kibana-ci commented Aug 27, 2024

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Public APIs missing comments

Public APIs missing exports

API count

History

Uh oh!

PhilippeOberti left a comment

Choose a reason for hiding this comment

Uh oh!

jennypavlova left a comment

Choose a reason for hiding this comment

Uh oh!

TinaHeiligers left a comment

Choose a reason for hiding this comment

Uh oh!

dmlemeshko Aug 29, 2024

Choose a reason for hiding this comment

Uh oh!

wayneseymour Aug 29, 2024

Choose a reason for hiding this comment

Uh oh!

dmlemeshko Aug 29, 2024

Choose a reason for hiding this comment

Uh oh!

wayneseymour Aug 29, 2024

Choose a reason for hiding this comment

Uh oh!

dmlemeshko left a comment

Choose a reason for hiding this comment

Uh oh!

jbudz commented Aug 29, 2024

Uh oh!

Reviewers

wayneseymour commented Jul 24, 2024 •

edited

Loading