[FTR] Refactor test/common/services/* -> packages/kbn-ftr-common-functional-[ui-]services/* by wayneseymour · Pull Request #191805 · elastic/kibana

wayneseymour · 2024-08-30T08:35:23Z

Summary

Moving common services to respective new homes.

This PR is revived from a previously merged and reverted PR as detailed here.

This was due to "extra" tests being applied to [Uptime] Report uptime overview metrics #191708
These "extra" tests were applied as [Uptime] Report uptime overview metrics #191708 changes files within x-pack/plugins/observability_solution/ as configured here

Why these failures were not caught in the original PR

The pipeline is generated at runtime, and the original PR had zero changes under x-pack/plugins/observability_solution/

Changes on top of original PR

Add ci:all-cypress-suites label to run extra tests
Add services stanza to which contains the missing references by spreading the services from @kbn/ftr-common-functional-services && @kbn/ftr-common-functional-ui-services into the stanza, for the following:
- x-pack/plugins/observability_solution/synthetics/e2e/config.ts
- x-pack/plugins/observability_solution/apm/ftr_e2e/ftr_config.ts
- x-pack/plugins/observability_solution/observability_onboarding/e2e/ftr_config.ts
- x-pack/plugins/observability_solution/profiling/e2e/ftr_config.ts
- x-pack/plugins/observability_solution/synthetics/e2e/config.ts
- x-pack/plugins/observability_solution/uptime/e2e/config.ts

Blocked by: #191961
Resolves: #188541

github-actions · 2024-08-30T08:35:38Z

A documentation preview will be available soon.

🔨 Buildkite builds
📚 HTML diff
📙 Preview page

Request a new doc build by commenting

Rebuild this PR: run docs-build
Rebuild this PR and all Elastic docs: run docs-build rebuild

_{run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.}

_{If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.}

wayneseymour · 2024-08-30T09:59:24Z

Looks like there are 22 potential files that could need an update

wayneseymour · 2024-08-30T10:23:07Z

/ci

wayneseymour · 2024-08-30T10:57:07Z

/ci

wayneseymour · 2024-08-30T13:22:05Z

Flakiness was due to (Client.Timeout exceeded while awaiting headers):

Job Environment Setup
  | Error response from daemon: Get "https://docker.elastic.co/v2/": Get "https://docker-auth.elastic.co/auth?account=kibanamachine&client_id=docker&offline_token=true&service=token-service": net/http: request canceled (Client.Timeout exceeded while awaiting headers) (Client.Timeout exceeded while awaiting headers)

shahzad31

LGTM !!

…-svcs

wayneseymour · 2024-09-03T08:16:11Z

Same "extra tests" failing on kibana / on merge unsupported ftrs (Upgrade EUI to v95.9.0 (#190752)) as well

wayneseymour · 2024-09-03T08:16:40Z

@elasticmachine merge upstream

cauemarcondes

LGTM

jennypavlova

Obs Ux Infra Services changes LGTM (code review)

wayneseymour · 2024-09-03T10:22:41Z

Reached out to ops team for guidance on what to do in this situation: where tests are failing on https://buildkite.com/elastic/kibana-on-merge-unsupported-ftrs and in a pr

wayneseymour · 2024-09-03T11:35:01Z

Adding the ci:all-cypress-suites label back now

wayneseymour · 2024-09-03T11:35:47Z

@elasticmachine merge upstream

…-svcs

kibana-ci · 2024-09-03T14:38:00Z

💚 Build Succeeded

Buildkite Build
Commit: e89522d
Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-191805-e89522db1762

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`@kbn/ftr-common-functional-services`	32	69	+37
`@kbn/ftr-common-functional-ui-services`	511	520	+9
total			+46

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
`@kbn/ftr-common-functional-ui-services`	3	7	+4

Unknown metric groups

API count

id	before	after	diff
`@kbn/ftr-common-functional-services`	47	94	+47
`@kbn/ftr-common-functional-ui-services`	551	560	+9
total			+56

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @wayneseymour

nchaulet

Fleet changes LGTM 🚀

TinaHeiligers

Core changes LGTM!

dmlemeshko

LGTM

logeekal

LGTM 🚀

wayneseymour added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting FTR labels Aug 30, 2024

wayneseymour self-assigned this Aug 30, 2024

wayneseymour added the ci:all-cypress-suites label Aug 30, 2024

wayneseymour force-pushed the refactor-common-svcs branch from 49447fa to 8385a47 Compare August 30, 2024 10:22

wayneseymour marked this pull request as ready for review August 30, 2024 14:02

wayneseymour requested a review from a team August 30, 2024 14:02

wayneseymour requested review from a team as code owners August 30, 2024 14:02

wayneseymour requested a review from a team August 30, 2024 14:02

wayneseymour requested a review from a team as a code owner August 30, 2024 14:02

wayneseymour requested a review from hop-dev August 30, 2024 14:02

shahzad31 approved these changes Aug 30, 2024

View reviewed changes

botelastic bot added the ci:project-deploy-observability Create an Observability project label Aug 30, 2024

Merge branch 'main' of github.com:elastic/kibana into refactor-common…

e6dc4f7

…-svcs

wayneseymour removed the ci:all-cypress-suites label Sep 3, 2024

Merge branch 'main' into refactor-common-svcs

0aa9c29

hop-dev approved these changes Sep 3, 2024

View reviewed changes

cauemarcondes approved these changes Sep 3, 2024

View reviewed changes

jennypavlova approved these changes Sep 3, 2024

View reviewed changes

wayneseymour added the ci:all-cypress-suites label Sep 3, 2024

Merge branch 'main' into refactor-common-svcs

4f16b5b

wayneseymour mentioned this pull request Sep 3, 2024

[FTR] Refactor SuperTest provider to the kbn-ftr-common-functional-services pkg #191970

Closed

Merge branch 'main' of github.com:elastic/kibana into refactor-common…

e89522d

…-svcs

jbudz approved these changes Sep 3, 2024

View reviewed changes

nchaulet approved these changes Sep 3, 2024

View reviewed changes

TattdCodeMonkey approved these changes Sep 3, 2024

View reviewed changes

TinaHeiligers approved these changes Sep 3, 2024

View reviewed changes

thomheymann approved these changes Sep 3, 2024

View reviewed changes

angorayc approved these changes Sep 4, 2024

View reviewed changes

MadameSheema approved these changes Sep 4, 2024

View reviewed changes

dmlemeshko approved these changes Sep 4, 2024

View reviewed changes

logeekal approved these changes Sep 5, 2024

View reviewed changes

wayneseymour merged commit 69665ce into elastic:main Sep 5, 2024

wayneseymour deleted the refactor-common-svcs branch September 5, 2024 09:01

kibanamachine added the v8.16.0 label Sep 5, 2024

PhilippeOberti mentioned this pull request Sep 20, 2024

[Security Solution] - fix Cypress not running locally #193622

Merged

Comments

Conversation

wayneseymour commented Aug 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Why these failures were not caught in the original PR

Changes on top of original PR

Uh oh!

github-actions bot commented Aug 30, 2024

Uh oh!

wayneseymour commented Aug 30, 2024

Uh oh!

wayneseymour commented Aug 30, 2024

Uh oh!

wayneseymour commented Aug 30, 2024

Uh oh!

wayneseymour commented Aug 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shahzad31 left a comment

Choose a reason for hiding this comment

Uh oh!

wayneseymour commented Sep 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wayneseymour commented Sep 3, 2024

Uh oh!

cauemarcondes left a comment

Choose a reason for hiding this comment

Uh oh!

jennypavlova left a comment

Choose a reason for hiding this comment

Uh oh!

wayneseymour commented Sep 3, 2024

Uh oh!

wayneseymour commented Sep 3, 2024

Uh oh!

wayneseymour commented Sep 3, 2024

Uh oh!

kibana-ci commented Sep 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Public APIs missing exports

API count

History

Uh oh!

nchaulet left a comment

Choose a reason for hiding this comment

Uh oh!

TinaHeiligers left a comment

Choose a reason for hiding this comment

Uh oh!

dmlemeshko left a comment

Choose a reason for hiding this comment

Uh oh!

logeekal left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

wayneseymour commented Aug 30, 2024 •

edited

Loading

wayneseymour commented Aug 30, 2024 •

edited

Loading

wayneseymour commented Sep 3, 2024 •

edited

Loading

kibana-ci commented Sep 3, 2024 •

edited

Loading