Add 5s `minRefreshInterval` to `timefilter` with validation by nickofthyme · Pull Request #188881 · elastic/kibana

nickofthyme · 2024-07-22T22:27:49Z

Summary

Set global min refresh interval in timeFilter with validation.

Checklist

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list

nickofthyme

@thomasneirynck, @ThomThomson & @lukasolson Could you take a look at this first pass and let me know if I'm on the right track? Thanks 🙏🏼

src/plugins/data/public/query/timefilter/timefilter.ts

src/plugins/data/public/query/timefilter/timefilter_service.ts

…fix'

src/plugins/navigation/public/top_nav_menu/create_top_nav_menu.tsx

…fix'

…lugin

elasticmachine · 2024-08-12T18:49:29Z

Pinging @elastic/kibana-visualizations (Team:Visualizations)

kc13greiner

CodeOwner review - LGTM!

src/plugins/data/config.ts

nickofthyme · 2024-08-15T15:36:15Z

Codeonwer review please @elastic/appex-sharedux, @elastic/kibana-visualizations, @elastic/security-solution, @elastic/kibana-data-discovery, @elastic/ml-ui

lukasolson

Works great! Just had some very minor feedback. Will we want to add this new config value to the allowed list inside cloud?

src/plugins/data/public/plugin.ts

src/plugins/data/public/query/query_service.ts

mbondyra

LGTM!

darnautov

LGTM

tsullivan

LGTM

nickofthyme · 2024-08-22T16:23:34Z

@elastic/security-solution

logeekal

Desk tested on Serverless. Works great 🚀.

kibana-ci · 2024-08-23T16:21:52Z

💚 Build Succeeded

Buildkite Build
Commit: 40509ff

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`discover`	843.6KB	843.6KB	+17.0B
`unifiedSearch`	218.9KB	219.0KB	+89.0B
total			+106.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`data`	418.1KB	418.7KB	+577.0B
`securitySolution`	86.2KB	86.3KB	+109.0B
`unifiedSearch`	38.8KB	38.9KB	+98.0B
total			+784.0B

History

💛 Build #229224 was flaky 155744c
💛 Build #228534 was flaky ce93360
💛 Build #228150 was flaky 3cc60d8
💛 Build #227767 was flaky 5892855
💔 Build #227747 failed ffb3dc5
💔 Build #227746 failed ffb3dc5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Add 5s min refresh interval to timefilter with validation

6bbdd7f

nickofthyme added release_note:skip Skip the PR/issue when compiling release notes Feature:Unified search Unified search related tasks Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// labels Jul 22, 2024

nickofthyme commented Jul 22, 2024

View reviewed changes

src/plugins/data/public/query/timefilter/timefilter.ts Show resolved Hide resolved

src/plugins/data/public/query/timefilter/timefilter.ts Outdated Show resolved Hide resolved

src/plugins/data/public/query/timefilter/timefilter_service.ts Outdated Show resolved Hide resolved

nickofthyme changed the title ~~Add 5s min refresh interval to timefilter with validation~~ Add 5s minRefreshInterval to timefilter with validation Jul 22, 2024

nickofthyme mentioned this pull request Jul 23, 2024

fix: refreshMinInterval for use in EuiQuickSelectPopover elastic/eui#7905

Merged

1 task

nickofthyme and others added 2 commits July 29, 2024 12:32

Merge branch 'main' into min-refresh-interval

85eb553

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

f37e7f4

…fix'

lukasolson reviewed Jul 31, 2024

View reviewed changes

src/plugins/navigation/public/top_nav_menu/create_top_nav_menu.tsx Outdated Show resolved Hide resolved

nickofthyme added 3 commits August 6, 2024 17:27

remove setMinRefreshInterval method

2be42e1

remove data dep from navigation plugin

44e5bbd

Merge branch 'main' into min-refresh-interval

ea3519e

elastic deleted a comment from kibana-ci Aug 7, 2024

kibanamachine and others added 15 commits August 7, 2024 00:44

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

b858a86

…fix'

add config option for minRefreshInterval default

ca79323

change QueryService service to allow usage in security_solution p…

2187cc3

…lugin

fix: jest tests and type errors

00451eb

Merge branch 'main' into min-refresh-interval

986728e

test: update and add timefilter tests

64ed4dc

chore: fix type errors in tests

b3f7e55

fix expected config check

1edd8d0

Merge branch 'main' into min-refresh-interval

e1c065a

fix more tests

99760dd

fix config test

ec3bc54

Merge branch 'main' into min-refresh-interval

b4622ce

pause when interval is 0, cleanup default intervals in test code

d3aebad

Merge branch 'main' into min-refresh-interval

ce76a1f

revert SO changes, add and fix tests

59b39bc

nickofthyme marked this pull request as ready for review August 12, 2024 18:49

nickofthyme requested review from a team as code owners August 12, 2024 18:49

nickofthyme requested a review from lukasolson August 12, 2024 18:49

kc13greiner self-requested a review August 12, 2024 19:37

kc13greiner approved these changes Aug 12, 2024

View reviewed changes

This comment was marked as resolved.

Sign in to view

nickofthyme commented Aug 13, 2024

View reviewed changes

src/plugins/data/config.ts Show resolved Hide resolved

src/plugins/data/config.ts Show resolved Hide resolved

nickofthyme added 4 commits August 14, 2024 10:51

fix: failing to start refresh loop on browser refresh

e852cf0

chore: update discover data loop check

6612e77

Merge branch 'main' into min-refresh-interval

ffb3dc5

update config optional type

5892855

lukasolson approved these changes Aug 15, 2024

View reviewed changes

src/plugins/data/public/plugin.ts Show resolved Hide resolved

src/plugins/data/public/query/query_service.ts Show resolved Hide resolved

src/plugins/data/public/query/query_service.ts Show resolved Hide resolved

mbondyra approved these changes Aug 19, 2024

View reviewed changes

Merge branch 'main' into min-refresh-interval

3cc60d8

darnautov approved these changes Aug 20, 2024

View reviewed changes

Merge branch 'main' into min-refresh-interval

ce93360

tsullivan approved these changes Aug 20, 2024

View reviewed changes

Merge branch 'main' into min-refresh-interval

155744c

logeekal approved these changes Aug 23, 2024

View reviewed changes

Merge branch 'main' into min-refresh-interval

40509ff

nickofthyme enabled auto-merge (squash) August 23, 2024 15:01

nickofthyme merged commit 94b657e into elastic:main Aug 23, 2024

nickofthyme deleted the min-refresh-interval branch August 23, 2024 16:21

kibanamachine added v8.16.0 backport:skip This PR does not require backporting labels Aug 23, 2024

Conversation

nickofthyme commented Jul 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Uh oh!

nickofthyme left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

elasticmachine commented Aug 12, 2024

Uh oh!

kc13greiner left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as resolved.

Uh oh!

Uh oh!

nickofthyme commented Aug 15, 2024

Uh oh!

lukasolson left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mbondyra left a comment

Choose a reason for hiding this comment

Uh oh!

darnautov left a comment

Choose a reason for hiding this comment

Uh oh!

tsullivan left a comment

Choose a reason for hiding this comment

Uh oh!

nickofthyme commented Aug 22, 2024

Uh oh!

logeekal left a comment

Choose a reason for hiding this comment

Uh oh!

kibana-ci commented Aug 23, 2024

💚 Build Succeeded

Metrics [docs]

Async chunks

Page load bundle

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

nickofthyme commented Jul 22, 2024 •

edited

Loading