Add 5s minRefreshInterval to timefilter with validation

src/plugins/data/public/query/timefilter/timefilter.ts

@@ -41,6 +41,7 @@ export class Timefilter {
   // Denotes whether setTime has been called, can be used to determine if the constructor defaults are being used.
   private _isTimeTouched: boolean = false;
   private _refreshInterval!: RefreshInterval;
+  private _minRefreshInterval: number;
   // Denotes whether the refresh interval defaults were overriden.
   private _isRefreshIntervalTouched: boolean = false;
   private _history: TimeHistoryContract;
@@ -62,6 +63,7 @@ export class Timefilter {
     this._history = timeHistory;
     this.timeDefaults = config.timeDefaults;
     this.refreshIntervalDefaults = config.refreshIntervalDefaults;
+    this._minRefreshInterval = config.minRefreshIntervalDefault;
     this._time = config.timeDefaults;
     this.setRefreshInterval(config.refreshIntervalDefaults);
   }
@@ -148,6 +150,14 @@ export class Timefilter {
     return _.clone(this._refreshInterval);
   };
 
+  public getMinRefreshInterval = () => {
+    return this._minRefreshInterval;
+  };
+
+  public setMinRefreshInterval = (t: number) => {
+    this._minRefreshInterval = Math.max(t, 0);
+  };
+
   /**
    * Set timefilter refresh interval.
    * @param {Object} refreshInterval
@@ -157,6 +167,9 @@ export class Timefilter {
   public setRefreshInterval = (refreshInterval: Partial<RefreshInterval>) => {
     const prevRefreshInterval = this.getRefreshInterval();
     const newRefreshInterval = { ...prevRefreshInterval, ...refreshInterval };
+
+    if (newRefreshInterval.value < this._minRefreshInterval) return;
+
     let shouldUnpauseRefreshLoop =
       newRefreshInterval.pause === false && prevRefreshInterval != null;
     if (prevRefreshInterval?.value > 0 && newRefreshInterval.value <= 0) {

src/plugins/data/public/query/timefilter/timefilter_service.ts

@@ -8,7 +8,13 @@
 
 import { IUiSettingsClient } from '@kbn/core/public';
 import { IStorageWrapper } from '@kbn/kibana-utils-plugin/public';
-import { TimeHistory, Timefilter, TimeHistoryContract, TimefilterContract } from '.';
+import {
+  TimeHistory,
+  Timefilter,
+  TimeHistoryContract,
+  TimefilterContract,
+  TimefilterConfig,
+} from '.';
 import { UI_SETTINGS } from '../../../common';
 import { NowProviderInternalContract } from '../../now_provider';
 
@@ -26,9 +32,10 @@ export class TimefilterService {
   constructor(private readonly nowProvider: NowProviderInternalContract) {}
 
   public setup({ uiSettings, storage }: TimeFilterServiceDependencies): TimefilterSetup {
-    const timefilterConfig = {
+    const timefilterConfig: TimefilterConfig = {
       timeDefaults: uiSettings.get(UI_SETTINGS.TIMEPICKER_TIME_DEFAULTS),
       refreshIntervalDefaults: uiSettings.get(UI_SETTINGS.TIMEPICKER_REFRESH_INTERVAL_DEFAULTS),
+      minRefreshIntervalDefault: 5000,
     };
     const history = new TimeHistory(storage);
     const timefilter = new Timefilter(timefilterConfig, history, this.nowProvider);

src/plugins/data/public/query/timefilter/types.ts

@@ -14,6 +14,7 @@ import { RefreshInterval } from '../../../common';
 export interface TimefilterConfig {
   timeDefaults: TimeRange;
   refreshIntervalDefaults: RefreshInterval;
+  minRefreshIntervalDefault: number;
 }
 
 // Timefilter accepts moment input but always returns string output

src/plugins/navigation/public/plugin.tsx

@@ -67,7 +67,7 @@ export class NavigationPublicPlugin
     this.coreStart = core;
     this.depsStart = depsStart;
 
-    const { unifiedSearch, cloud, cloudExperiments, spaces } = depsStart;
+    const { unifiedSearch, data, cloud, cloudExperiments, spaces } = depsStart;
     const extensions = this.topNavMenuExtensionsRegistry.getAll();
     const chrome = core.chrome as InternalChromeStart;
     const activeSpace$ = spaces?.getActiveSpace$() ?? of(undefined);
@@ -89,7 +89,11 @@ export class NavigationPublicPlugin
       customUnifiedSearch?: UnifiedSearchPublicPluginStart,
       customExtensions?: RegisteredTopNavMenuData[]
     ) => {
-      return createTopNav(customUnifiedSearch ?? unifiedSearch, customExtensions ?? extensions);
+      return createTopNav(
+        data,
+        customUnifiedSearch ?? unifiedSearch,
+        customExtensions ?? extensions
+      );
     };
 
     const onCloud = cloud !== undefined; // The new side nav will initially only be available to cloud users
@@ -118,8 +122,8 @@ export class NavigationPublicPlugin
 
     return {
       ui: {
-        TopNavMenu: createTopNav(unifiedSearch, extensions),
-        AggregateQueryTopNavMenu: createTopNav(unifiedSearch, extensions),
+        TopNavMenu: createTopNav(data, unifiedSearch, extensions),
+        AggregateQueryTopNavMenu: createTopNav(data, unifiedSearch, extensions),
         createTopNavWithCustomContext: createCustomTopNav,
       },
       addSolutionNavigation: (solutionNavigation) => {

src/plugins/navigation/public/top_nav_menu/create_top_nav_menu.tsx

@@ -10,13 +10,16 @@ import React from 'react';
 import { I18nProvider } from '@kbn/i18n-react';
 import { AggregateQuery, Query } from '@kbn/es-query';
 import { UnifiedSearchPublicPluginStart } from '@kbn/unified-search-plugin/public';
+import { DataPublicPluginStart } from '@kbn/data-plugin/public';
 import { TopNavMenuProps, TopNavMenu } from './top_nav_menu';
 import { RegisteredTopNavMenuData } from './top_nav_menu_data';
 
 export function createTopNav(
+  data: DataPublicPluginStart,
   unifiedSearch: UnifiedSearchPublicPluginStart,
   extraConfig: RegisteredTopNavMenuData[]
 ) {
+  const minRefreshInterval = data.query.timefilter.timefilter.getMinRefreshInterval();
   return <QT extends AggregateQuery | Query = Query>(props: TopNavMenuProps<QT>) => {
     const relevantConfig = extraConfig.filter(
       (dataItem) => dataItem.appName === undefined || dataItem.appName === props.appName
@@ -25,7 +28,12 @@ export function createTopNav(
 
     return (
       <I18nProvider>
-        <TopNavMenu {...props} unifiedSearch={unifiedSearch} config={config} />
+        <TopNavMenu
+          {...props}
+          unifiedSearch={unifiedSearch}
+          config={config}
+          minRefreshInterval={minRefreshInterval}
+        />
       </I18nProvider>
     );
   };

src/plugins/navigation/public/top_nav_menu/top_nav_menu.tsx

@@ -79,7 +79,7 @@ export function TopNavMenu<QT extends AggregateQuery | Query = Query>(
   }
 
   function renderSearchBar(): ReactElement | null {
-    // Validate presense of all required fields
+    // Validate presence of all required fields
     if (!showSearchBar || !props.unifiedSearch) return null;
     const { AggregateQuerySearchBar } = props.unifiedSearch.ui;
     return <AggregateQuerySearchBar<QT> {...searchBarProps} />;

src/plugins/navigation/public/types.ts

@@ -15,6 +15,7 @@ import type { SpacesPluginSetup, SpacesPluginStart } from '@kbn/spaces-plugin/pu
 import type { CloudExperimentsPluginStart } from '@kbn/cloud-experiments-plugin/common';
 
 import { PanelContentProvider } from '@kbn/shared-ux-chrome-navigation';
+import { DataPublicPluginStart } from '@kbn/data-plugin/public';
 import { TopNavMenuProps, TopNavMenuExtensionsRegistrySetup, createTopNav } from './top_nav_menu';
 import type { RegisteredTopNavMenuData } from './top_nav_menu/top_nav_menu_data';
 
@@ -52,6 +53,7 @@ export interface NavigationPublicSetupDependencies {
 
 export interface NavigationPublicStartDependencies {
   unifiedSearch: UnifiedSearchPublicPluginStart;
+  data: DataPublicPluginStart;
   cloud?: CloudStart;
   cloudExperiments?: CloudExperimentsPluginStart;
   spaces?: SpacesPluginStart;

src/plugins/navigation/tsconfig.json

@@ -28,6 +28,7 @@
     "@kbn/config-schema",
     "@kbn/i18n",
     "@kbn/std",
+    "@kbn/data-plugin",
   ],
   "exclude": [
     "target/**/*",

src/plugins/unified_search/public/query_string_input/query_bar_top_row.tsx

@@ -153,6 +153,7 @@ export interface QueryBarTopRowProps<QT extends Query | AggregateQuery = Query>
   prepend?: React.ComponentProps<typeof EuiFieldText>['prepend'];
   query?: Query | QT;
   refreshInterval?: number;
+  minRefreshInterval?: number;
   screenTitle?: string;
   showQueryInput?: boolean;
   showAddFilter?: boolean;
@@ -502,6 +503,7 @@ export const QueryBarTopRow = React.memo(
           end={props.dateRangeTo}
           isPaused={props.isRefreshPaused}
           refreshInterval={props.refreshInterval}
+          refreshMinInterval={props.minRefreshInterval}
           onTimeChange={onTimeChange}
           onRefresh={onRefresh}
           onRefreshChange={props.onRefreshChange}

src/plugins/unified_search/public/search_bar/create_search_bar.tsx

@@ -171,7 +171,7 @@ export function createSearchBar({
       query: props.query,
       queryStringManager: data.query.queryString,
     }) as { query: QT };
-    const { timeRange, refreshInterval } = useTimefilter({
+    const { timeRange, refreshInterval, minRefreshInterval } = useTimefilter({
       dateRangeFrom: props.dateRangeFrom,
       dateRangeTo: props.dateRangeTo,
       refreshInterval: props.refreshInterval,
@@ -232,6 +232,7 @@ export function createSearchBar({
             timeHistory={data.query.timefilter.history}
             dateRangeFrom={timeRange.from}
             dateRangeTo={timeRange.to}
+            minRefreshInterval={minRefreshInterval}
             refreshInterval={refreshInterval.value}
             isRefreshPaused={refreshInterval.pause}
             isLoading={props.isLoading}

src/plugins/unified_search/public/search_bar/lib/use_timefilter.ts

@@ -59,5 +59,6 @@ export const useTimefilter = (props: UseTimefilterProps) => {
   return {
     refreshInterval,
     timeRange,
+    minRefreshInterval: props.timefilter.getMinRefreshInterval(),
   };
 };

src/plugins/unified_search/public/search_bar/search_bar.tsx

@@ -72,6 +72,7 @@ export interface SearchBarOwnProps<QT extends AggregateQuery | Query = Query> {
   // Date picker
   isRefreshPaused?: boolean;
   refreshInterval?: number;
+  minRefreshInterval?: number;
   dateRangeFrom?: string;
   dateRangeTo?: string;
   // Query bar - should be in SearchBarInjectedDeps
@@ -612,6 +613,7 @@ class SearchBarUI<QT extends (Query | AggregateQuery) | Query = Query> extends C
           dateRangeTo={this.state.dateRangeTo}
           isRefreshPaused={this.props.isRefreshPaused}
           refreshInterval={this.props.refreshInterval}
+          minRefreshInterval={this.props.minRefreshInterval}
           showAutoRefreshOnly={this.props.showAutoRefreshOnly}
           showQueryInput={this.props.showQueryInput}
           showAddFilter={this.props.showFilterBar}