fix: refreshMinInterval for use in EuiQuickSelectPopover#7905
Merged
cee-chen merged 4 commits intoelastic:mainfrom Jul 23, 2024
Merged
fix: refreshMinInterval for use in EuiQuickSelectPopover#7905cee-chen merged 4 commits intoelastic:mainfrom
refreshMinInterval for use in EuiQuickSelectPopover#7905cee-chen merged 4 commits intoelastic:mainfrom
Conversation
Use the full `refreshMinInterval` prop for EuiSuperDatePicker subcomponents - we use `minInterval` for the refresh component directly + unify types
cee-chen
approved these changes
Jul 23, 2024
Contributor
cee-chen
left a comment
cee-chen
left a comment
There was a problem hiding this comment.
Thanks a million for catching this @nickofthyme! 🤦 I've pushed up some minor naming/copy tweaks but otherwise this looks great!
Collaborator
💚 Build Succeeded
History
|
Contributor
Author
|
Not a problem, Thanks for the quick merge. You da best!! |
jbudz
pushed a commit
to elastic/kibana
that referenced
this pull request
Aug 1, 2024
`v95.4.0` ⏩ `v95.5.0` _[Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_ --- ## [`v95.5.0`](https://github.com/elastic/eui/releases/v95.5.0) - Added `minusInSquare` and `plusInSquare` glyphs to `EuiIcon`. ([#7875](elastic/eui#7875)) **Bug fixes** - Fixed `EuiSuperDatePicker` not correctly passing `refreshMinInterval` from the quick select popover ([#7905](elastic/eui#7905)) **CSS-in-JS conversions** - Converted `EuiSuperDatePicker`'s form control to Emotion; ([#7904](elastic/eui#7904)) - Removed `$euiSuperDatePickerWidth` - Removed `$euiSuperDatePickerButtonWidth` - Removed `$euiSuperDatePickerNeedsUpdatingBackgroundColor` - Removed `$euiSuperDatePickerNeedsUpdatingTextColor` - Removed `@euiSuperDatePickerText` mixin - Converted `EuiSuperDatePicker`'s date popover content to Emotion ([#7908](elastic/eui#7908)) - Converted `EuiSuperDatePicker`'s quick select to Emotion ([#7909](elastic/eui#7909)) --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Following the addition of the new
refreshMinIntervalprop toEuiSuperDatePickerin #7516, we missed passing this prop toEuiQuickSelectPopoverBefore
Notice changing the interval from
EuiAutoRefreshButtonproperly validates against theminInterval. But when changing the interval from withinEuiQuickSelectPopover, the validation is skipped.After
Related to elastic/kibana#188881
General checklist
[ ] Added or updated jest and cypress tests- Skipped, just a basic prop pass