Skip to content

[a11y] Remove jext-axe and supporting code from kibana#180694

Merged
bhavyarm merged 9 commits intoelastic:mainfrom
bhavyarm:removeJestAxe11y
Apr 25, 2024
Merged

[a11y] Remove jext-axe and supporting code from kibana#180694
bhavyarm merged 9 commits intoelastic:mainfrom
bhavyarm:removeJestAxe11y

Conversation

@bhavyarm
Copy link
Copy Markdown
Contributor

@bhavyarm bhavyarm commented Apr 12, 2024

Removing jest-axe and supporting code from Kibana because this library (not regularly updated anymore and used only in one test file) is blocking me from updating axe-core.

@bhavyarm
Copy link
Copy Markdown
Contributor Author

/ci

1 similar comment
@bhavyarm
Copy link
Copy Markdown
Contributor Author

/ci

@bhavyarm
Copy link
Copy Markdown
Contributor Author

/ci

@bhavyarm
Copy link
Copy Markdown
Contributor Author

/ci

@bhavyarm bhavyarm marked this pull request as ready for review April 25, 2024 13:41
@bhavyarm bhavyarm requested review from a team as code owners April 25, 2024 13:42
@bhavyarm bhavyarm added v8.14.0 release_note:skip Skip the PR/issue when compiling release notes Project:Accessibility labels Apr 25, 2024
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@bhavyarm bhavyarm changed the title [a11y][WIP] Remove jext-axe and supporting code from kibana [a11y] Remove jext-axe and supporting code from kibana Apr 25, 2024
Copy link
Copy Markdown
Contributor

@wayneseymour wayneseymour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link
Copy Markdown

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/test-jest-helpers 105 103 -2
Unknown metric groups

API count

id before after diff
@kbn/test-jest-helpers 137 133 -4

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @bhavyarm

@yuliacech yuliacech self-requested a review April 25, 2024 16:52
@bhavyarm bhavyarm merged commit 3a65e17 into elastic:main Apr 25, 2024
@bhavyarm bhavyarm added the backport:skip This PR does not require backporting label Apr 25, 2024
@bhavyarm bhavyarm removed the v8.14.0 label Apr 25, 2024
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Apr 25, 2024
Removing jest-axe and supporting code from Kibana because this library
(not regularly updated anymore and used only in one test file) is
blocking me from updating axe-core.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 3a65e17)
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 All backports created successfully

Status Branch Result
8.14

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Apr 25, 2024
… (#181747)

# Backport

This will backport the following commits from `main` to `8.14`:
- [[a11y] Remove jext-axe and supporting code from kibana
(#180694)](#180694)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Bhavya
RM","email":"bhavya@elastic.co"},"sourceCommit":{"committedDate":"2024-04-25T16:54:18Z","message":"[a11y]
Remove jext-axe and supporting code from kibana (#180694)\n\nRemoving
jest-axe and supporting code from Kibana because this library\r\n(not
regularly updated anymore and used only in one test file) is\r\nblocking
me from updating axe-core.\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"3a65e17d78a8f5148adae6c6445230da55ce4869","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","backport:skip","v8.14.0","v8.15.0"],"title":"[a11y]
Remove jext-axe and supporting code from
kibana","number":180694,"url":"https://github.com/elastic/kibana/pull/180694","mergeCommit":{"message":"[a11y]
Remove jext-axe and supporting code from kibana (#180694)\n\nRemoving
jest-axe and supporting code from Kibana because this library\r\n(not
regularly updated anymore and used only in one test file) is\r\nblocking
me from updating axe-core.\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"3a65e17d78a8f5148adae6c6445230da55ce4869"}},"sourceBranch":"main","suggestedTargetBranches":["8.14"],"targetPullRequestStates":[{"branch":"8.14","label":"v8.14.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/180694","number":180694,"mergeCommit":{"message":"[a11y]
Remove jext-axe and supporting code from kibana (#180694)\n\nRemoving
jest-axe and supporting code from Kibana because this library\r\n(not
regularly updated anymore and used only in one test file) is\r\nblocking
me from updating axe-core.\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"3a65e17d78a8f5148adae6c6445230da55ce4869"}}]}]
BACKPORT-->

Co-authored-by: Bhavya RM <bhavya@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting Project:Accessibility release_note:skip Skip the PR/issue when compiling release notes v8.14.0 v8.15.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants