[Search] Fix mapping tab breaking docLinks and refresh#181729
Merged
sphilipse merged 2 commits intoelastic:mainfrom Apr 25, 2024
Merged
[Search] Fix mapping tab breaking docLinks and refresh#181729sphilipse merged 2 commits intoelastic:mainfrom
sphilipse merged 2 commits intoelastic:mainfrom
Conversation
sphilipse
added
release_note:skip
efegurkan
approved these changes
Apr 25, 2024
| <EuiSpacer size="s" /> | ||
| <EuiLink href={docLinks.connectorsMappings} target="_blank" external> | ||
| <EuiLink | ||
| data-test-subj="enterpriseSearchSearchIndexIndexMappingsLearnHowToCustomizeIndexMappingsAndSettingsLink" |
Member
There was a problem hiding this comment.
nitpick: wrong schema for test/telemetry. We should update the autofix for the plugin.
saikatsarkar056
approved these changes
Apr 25, 2024
...rch/public/applications/enterprise_search_content/components/search_index/index_mappings.tsx
Show resolved
Hide resolved
yuliacech
approved these changes
Apr 25, 2024
💚 Build Succeeded
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
Member
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
sphilipse
added a commit
to sphilipse/kibana
that referenced
this pull request
Apr 26, 2024
## Summary This fixes two issues on the mappings tab in Search: - A frequent refresh caused by input changes unrelated to the mappings component - Doclinks breaking because they hadn't been initialized yet (cherry picked from commit 35974ca) # Conflicts: # x-pack/plugins/index_management/public/application/components/mappings_editor/components/document_fields/field_parameters/select_inference_id.tsx
sphilipse
added a commit
that referenced
this pull request
Apr 26, 2024
… (#181806) # Backport This will backport the following commits from `main` to `8.14`: - [[Search] Fix mapping tab breaking docLinks and refresh (#181729)](#181729) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sander Philipse","email":"94373878+sphilipse@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-04-25T17:44:49Z","message":"[Search] Fix mapping tab breaking docLinks and refresh (#181729)\n\n## Summary\r\n\r\nThis fixes two issues on the mappings tab in Search:\r\n- A frequent refresh caused by input changes unrelated to the mappings\r\ncomponent\r\n- Doclinks breaking because they hadn't been initialized yet","sha":"35974ca8166ebc702308f04b9333c47b9ff04cfe","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:EnterpriseSearch","v8.14.0","v8.15.0"],"number":181729,"url":"https://github.com/elastic/kibana/pull/181729","mergeCommit":{"message":"[Search] Fix mapping tab breaking docLinks and refresh (#181729)\n\n## Summary\r\n\r\nThis fixes two issues on the mappings tab in Search:\r\n- A frequent refresh caused by input changes unrelated to the mappings\r\ncomponent\r\n- Doclinks breaking because they hadn't been initialized yet","sha":"35974ca8166ebc702308f04b9333c47b9ff04cfe"}},"sourceBranch":"main","suggestedTargetBranches":["8.14"],"targetPullRequestStates":[{"branch":"8.14","label":"v8.14.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.15.0","labelRegex":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/181729","number":181729,"mergeCommit":{"message":"[Search] Fix mapping tab breaking docLinks and refresh (#181729)\n\n## Summary\r\n\r\nThis fixes two issues on the mappings tab in Search:\r\n- A frequent refresh caused by input changes unrelated to the mappings\r\ncomponent\r\n- Doclinks breaking because they hadn't been initialized yet","sha":"35974ca8166ebc702308f04b9333c47b9ff04cfe"}}]}] BACKPORT-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes two issues on the mappings tab in Search: