Skip to content

[Security Assistant] Fixes LangSmith support for specifying configuration via env vars #180426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spong merged 2 commits into from
Apr 10, 2024
Merged

[Security Assistant] Fixes LangSmith support for specifying configuration via env vars #180426

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7afe7a6
Fixes langsmith support for env vars
spong Apr 9, 2024
cb656f6
Remove explicit env check, defer to langchain
spong Apr 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions x-pack/packages/kbn-elastic-assistant/impl/assistant/api/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,10 @@ export const fetchConnectorExecuteAction = async ({
replacements,
isEnabledKnowledgeBase,
isEnabledRAGAlerts,
langSmithProject: traceOptions?.langSmithProject,
langSmithApiKey: traceOptions?.langSmithApiKey,
langSmithProject:
traceOptions?.langSmithProject === '' ? undefined : traceOptions?.langSmithProject,
langSmithApiKey:
traceOptions?.langSmithApiKey === '' ? undefined : traceOptions?.langSmithApiKey,
...optionalRequestParams,
};

Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/elastic_assistant/server/routes/evaluate/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ export const getLangSmithTracer = ({
return [];
}
const lcTracer = new LangChainTracer({
projectName: projectName ?? 'default', // Shows as the 'test' run's 'name' in langsmith ui
projectName, // Shows as the 'test' run's 'name' in langsmith ui
Copy link
Copy Markdown
Member Author

@spong spong Apr 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine to pass in undefined as the projectName here. LangChain will attempt to fetch it from the env vars, and if still not available it will then fall back to default when pushing to LangSmith.

exampleId,
client: new Client({ apiKey }),
});
Expand Down