[Security Assistant] Fixes LangSmith support for specifying configuration via env vars#180426
Merged
spong merged 2 commits intoelastic:mainfrom Apr 10, 2024
Merged
[Security Assistant] Fixes LangSmith support for specifying configuration via env vars#180426spong merged 2 commits intoelastic:mainfrom
spong merged 2 commits intoelastic:mainfrom
Conversation
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
spong
commented
Apr 9, 2024
| } | ||
| const lcTracer = new LangChainTracer({ | ||
| projectName: projectName ?? 'default', // Shows as the 'test' run's 'name' in langsmith ui | ||
| projectName, // Shows as the 'test' run's 'name' in langsmith ui |
Member
Author
There was a problem hiding this comment.
It's fine to pass in undefined as the projectName here. LangChain will attempt to fetch it from the env vars, and if still not available it will then fall back to default when pushing to LangSmith.
stephmilovic
approved these changes
Apr 9, 2024
Contributor
stephmilovic
left a comment
There was a problem hiding this comment.
Thanks for getting this fixed quickly. Ran your test and had success, LGTM!
💚 Build Succeeded
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: cc @spong |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With #180227, LangSmith configuration (Project & API Key) could no longer be specified using environment variables when working locally. This fixes that issue, which was caused by sending
''forlangSmithProjectandlangSmithApiKeyinstead ofundefined.To test, set the below env vars, then start kibana. Be sure to not have the UI trace options set as shown in #180227.