[EuiInMemoryTable] Replace basic usages of deprecated ref method with controlled `selection.selected` API by cee-chen · Pull Request #175722 · elastic/kibana

cee-chen · 2024-01-26T18:57:47Z

Summary

EUI will shortly be removing this deprecated ref setSelection method in favor of the new controlled selection.selected prop. This PR converts basic usages of controlled selection, which should not suffer any UI/UX regressions.

Please help us QA your affected tables to confirm that your table selection still works as before!

elasticmachine · 2024-01-26T22:42:52Z

Pinging @elastic/eui-team (EUI)

jeramysoucy

LGTM! Just once change request for our team.

...gins/security/public/management/role_mappings/role_mappings_grid/role_mappings_grid_page.tsx

x-pack/plugins/security/public/management/roles/roles_grid/roles_grid_page.tsx

… controlled `selection.selected` API (#175727) ## Summary **Please help us QA your affected tables to confirm that your plugin's table selection still works as before!** EUI will shortly be removing this deprecated ref `setSelection` method in favor of the new controlled `selection.selected` prop. This PR converts Fleet's more advanced usage of controlled selection, which should not suffer any UI/UX regressions. See also: - elastic/eui#7321 - #175722 (examples of basic conversions)

…ith controlled `selection.selected` API (#175838) Closes #175836 ## Summary **Please help us QA your affected tables to confirm that your plugin's table selection still works as before!** EUI will shortly be removing this deprecated ref `setSelection` method in favor of the new controlled `selection.selected` prop. This PR converts the Security plugin's basic usages of controlled selection and additionally removes 2 deletion cancellation behaviors on the team's request. There should not be any other UI/UX regressions when selecting rows. See also: - elastic/eui#7321 - #175722 (examples of basic conversions)

cauemarcondes

LGTM

rshen91

tested locally in stateful

… method with controlled `selection.selected` API (#175726) ## Summary **Please help us QA your affected tables to confirm that your plugin's table selection still works as before!** EUI will shortly be removing this deprecated ref `setSelection` method in favor of the new controlled `selection.selected` prop. This PR converts basic usages of controlled selection, which should not suffer any UI/UX regressions. See also: - elastic/eui#7321 - #175722 (examples of basic conversions) Co-authored-by: Tomasz Ciecierski <tomasz.ciecierski@elastic.co>

adcoelho

Cases changes ok 👍

spong · 2024-01-31T15:57:46Z

x-pack/packages/kbn-elastic-assistant/impl/data_anonymization_editor/context_editor/index.tsx

Just tested locally and this appears to break the 'select all pages' action:

Before / After (changes from this PR):

cc @andrew-goldstein

I think this should fix it - please let me know if not! 1567fd9

…cted` API

…cted` API + remove `refs` (should no longer be needed)

…ion.selected` API

andrew-goldstein · 2024-01-31T23:49:53Z

.../packages/kbn-elastic-assistant/impl/data_anonymization_editor/context_editor/index.test.tsx

-    expect(screen.getByTestId('selectedFields')).toHaveTextContent('Selected 2 fields');
+    // The select all button should select all rows regardless of visibility
+    userEvent.click(screen.getByTestId('selectAllFields'));
+    expect(screen.getByTestId('selectedFields')).toHaveTextContent('Selected 20 fields');


Thanks for adding this @cee-chen !

andrew-goldstein

Thanks for this update @cee-chen! 🙏
✅ Desk tested locally
LGTM 🚀

kibana-ci · 2024-01-31T23:56:14Z

💚 Build Succeeded

Buildkite Build
Commit: 1567fd9

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`cases`	450.4KB	450.3KB	-102.0B
`infra`	1.3MB	1.3MB	-113.0B
`savedObjectsTagging`	46.5KB	46.4KB	-114.0B
`securitySolution`	11.4MB	11.4MB	-224.0B
total			-553.0B

History

💚 Build #190602 succeeded 7284be5196aa6565181933c62d2c863b98a7f8cb
💛 Build #190012 was flaky 1e87a0c0ae307af0f2b0dfd6ec1ba1dce46e110a
💚 Build #189719 succeeded 825494fa62cf8b511ded3f8e231d19c2557699ad
💔 Build #189692 failed 29c3626775f5eb766fb4866cf279347d059751a9

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

… controlled `selection.selected` API (elastic#175722) ## Summary See elastic/eui#7321 EUI will shortly be removing this deprecated ref `setSelection` method in favor of the new controlled `selection.selected` prop. This PR converts basic usages of controlled selection, which should not suffer any UI/UX regressions. **Please help us QA your affected tables to confirm that your table selection still works as before!**

… controlled `selection.selected` API (elastic#175727) ## Summary **Please help us QA your affected tables to confirm that your plugin's table selection still works as before!** EUI will shortly be removing this deprecated ref `setSelection` method in favor of the new controlled `selection.selected` prop. This PR converts Fleet's more advanced usage of controlled selection, which should not suffer any UI/UX regressions. See also: - elastic/eui#7321 - elastic#175722 (examples of basic conversions)

…ith controlled `selection.selected` API (elastic#175838) Closes elastic#175836 ## Summary **Please help us QA your affected tables to confirm that your plugin's table selection still works as before!** EUI will shortly be removing this deprecated ref `setSelection` method in favor of the new controlled `selection.selected` prop. This PR converts the Security plugin's basic usages of controlled selection and additionally removes 2 deletion cancellation behaviors on the team's request. There should not be any other UI/UX regressions when selecting rows. See also: - elastic/eui#7321 - elastic#175722 (examples of basic conversions)

… method with controlled `selection.selected` API (elastic#175726) ## Summary **Please help us QA your affected tables to confirm that your plugin's table selection still works as before!** EUI will shortly be removing this deprecated ref `setSelection` method in favor of the new controlled `selection.selected` prop. This PR converts basic usages of controlled selection, which should not suffer any UI/UX regressions. See also: - elastic/eui#7321 - elastic#175722 (examples of basic conversions) Co-authored-by: Tomasz Ciecierski <tomasz.ciecierski@elastic.co>

… controlled `selection.selected` API (elastic#175722) ## Summary See elastic/eui#7321 EUI will shortly be removing this deprecated ref `setSelection` method in favor of the new controlled `selection.selected` prop. This PR converts basic usages of controlled selection, which should not suffer any UI/UX regressions. **Please help us QA your affected tables to confirm that your table selection still works as before!**

… controlled `selection.selected` API (elastic#175727) ## Summary **Please help us QA your affected tables to confirm that your plugin's table selection still works as before!** EUI will shortly be removing this deprecated ref `setSelection` method in favor of the new controlled `selection.selected` prop. This PR converts Fleet's more advanced usage of controlled selection, which should not suffer any UI/UX regressions. See also: - elastic/eui#7321 - elastic#175722 (examples of basic conversions)

…ith controlled `selection.selected` API (elastic#175838) Closes elastic#175836 ## Summary **Please help us QA your affected tables to confirm that your plugin's table selection still works as before!** EUI will shortly be removing this deprecated ref `setSelection` method in favor of the new controlled `selection.selected` prop. This PR converts the Security plugin's basic usages of controlled selection and additionally removes 2 deletion cancellation behaviors on the team's request. There should not be any other UI/UX regressions when selecting rows. See also: - elastic/eui#7321 - elastic#175722 (examples of basic conversions)

… method with controlled `selection.selected` API (elastic#175726) ## Summary **Please help us QA your affected tables to confirm that your plugin's table selection still works as before!** EUI will shortly be removing this deprecated ref `setSelection` method in favor of the new controlled `selection.selected` prop. This PR converts basic usages of controlled selection, which should not suffer any UI/UX regressions. See also: - elastic/eui#7321 - elastic#175722 (examples of basic conversions) Co-authored-by: Tomasz Ciecierski <tomasz.ciecierski@elastic.co>

… controlled `selection.selected` API (elastic#175722) ## Summary See elastic/eui#7321 EUI will shortly be removing this deprecated ref `setSelection` method in favor of the new controlled `selection.selected` prop. This PR converts basic usages of controlled selection, which should not suffer any UI/UX regressions. **Please help us QA your affected tables to confirm that your table selection still works as before!**

cee-chen added release_note:skip Skip the PR/issue when compiling release notes EUI v8.13.0 labels Jan 26, 2024

This was referenced Jan 26, 2024

[Security Solution][EuiInMemoryTable] Replace usage of deprecated ref method with controlled selection.selected API #175726

Merged

[Fleet][EuiInMemoryTable] Replace usage of deprecated ref method with controlled selection.selected API #175727

Merged

cee-chen force-pushed the eui-table-selection-controlled branch from 29c3626 to 77c9910 Compare January 26, 2024 19:56

cee-chen mentioned this pull request Jan 26, 2024

[EuiBasicTable][EuiInMemoryTable] Remove deprecated internal setSelection class methods elastic/eui#7491

Merged

4 tasks

cee-chen force-pushed the eui-table-selection-controlled branch from 77c9910 to 825494f Compare January 26, 2024 21:13

cee-chen marked this pull request as ready for review January 26, 2024 22:42

cee-chen requested a review from a team January 26, 2024 22:42

cee-chen requested review from a team as code owners January 26, 2024 22:42

smith added the apm:review label Jan 26, 2024

jeramysoucy self-requested a review January 29, 2024 17:01

jeramysoucy requested changes Jan 29, 2024

View reviewed changes

...gins/security/public/management/role_mappings/role_mappings_grid/role_mappings_grid_page.tsx Outdated Show resolved Hide resolved

x-pack/plugins/security/public/management/roles/roles_grid/roles_grid_page.tsx Outdated Show resolved Hide resolved

jeramysoucy approved these changes Jan 29, 2024

View reviewed changes

jeramysoucy mentioned this pull request Jan 29, 2024

Canceling delete operation in Role & Role Mapping grids clears item section #175836

Closed

cee-chen mentioned this pull request Jan 29, 2024

[Security][EuiInMemoryTable] Replace usage of deprecated ref method with controlled selection.selected API #175838

Merged

cee-chen force-pushed the eui-table-selection-controlled branch from 825494f to 1e87a0c Compare January 29, 2024 19:44

cauemarcondes approved these changes Jan 30, 2024

View reviewed changes

rshen91 approved these changes Jan 30, 2024

View reviewed changes

adcoelho approved these changes Jan 31, 2024

View reviewed changes

spong reviewed Jan 31, 2024

View reviewed changes

cee-chen added 4 commits January 31, 2024 14:39

[Cases] Replace deprecated ref method with controlled `selection.sele…

936a296

…cted` API

[Infra] Replace deprecated ref method with controlled `selection.sele…

b81b5f0

…cted` API + remove `refs` (should no longer be needed)

[Saved Objects] Replace deprecated ref method with controlled `select…

114a17f

…ion.selected` API

[AI Assistant] Fix incorrect select all toolbar count

1567fd9

cee-chen force-pushed the eui-table-selection-controlled branch from 7284be5 to 1567fd9 Compare January 31, 2024 22:51

andrew-goldstein reviewed Jan 31, 2024

View reviewed changes

andrew-goldstein approved these changes Jan 31, 2024

View reviewed changes

cee-chen merged commit 82460b4 into elastic:main Feb 1, 2024

cee-chen deleted the eui-table-selection-controlled branch February 1, 2024 01:04

kibanamachine added the backport:skip This PR does not require backporting label Feb 1, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[EuiInMemoryTable] Replace basic usages of deprecated ref method with controlled `selection.selected` API#175722

[EuiInMemoryTable] Replace basic usages of deprecated ref method with controlled `selection.selected` API#175722
cee-chen merged 5 commits intoelastic:mainfrom
cee-chen:eui-table-selection-controlled

cee-chen commented Jan 26, 2024 •

edited

Loading

Uh oh!

elasticmachine commented Jan 26, 2024

Uh oh!

jeramysoucy left a comment

Uh oh!

Uh oh!

Uh oh!

cauemarcondes left a comment

Uh oh!

rshen91 left a comment

Uh oh!

adcoelho left a comment

Uh oh!

spong Jan 31, 2024

Uh oh!

cee-chen Jan 31, 2024 •

edited

Loading

Uh oh!

andrew-goldstein Jan 31, 2024

Uh oh!

andrew-goldstein left a comment

Uh oh!

kibana-ci commented Jan 31, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

Conversation

cee-chen commented Jan 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

elasticmachine commented Jan 26, 2024

Uh oh!

jeramysoucy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

cauemarcondes left a comment

Choose a reason for hiding this comment

Uh oh!

rshen91 left a comment

Choose a reason for hiding this comment

Uh oh!

adcoelho left a comment

Choose a reason for hiding this comment

Uh oh!

spong Jan 31, 2024

Choose a reason for hiding this comment

Uh oh!

cee-chen Jan 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

andrew-goldstein Jan 31, 2024

Choose a reason for hiding this comment

Uh oh!

andrew-goldstein left a comment

Choose a reason for hiding this comment

Uh oh!

kibana-ci commented Jan 31, 2024

💚 Build Succeeded

Metrics [docs]

Async chunks

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

cee-chen commented Jan 26, 2024 •

edited

Loading

cee-chen Jan 31, 2024 •

edited

Loading