[Security Solution][EuiInMemoryTable] Replace usage of deprecated ref method with controlled selection.selected API#175726
Merged
cee-chen merged 6 commits intoelastic:mainfrom Jan 30, 2024
Conversation
cee-chen
added
release_note:skip
4 tasks
…ith controlled `selection.selected` API
cee-chen
force-pushed
the
eui-table-selection-controlled-advanced-2
branch
from
6cbfb6b to
106dc84
Compare
Contributor
Author
|
/ci |
Contributor
Author
Contributor
|
/ci |
Contributor
|
/ci |
Contributor
|
Pinging @elastic/eui-team (EUI) |
dplumlee
approved these changes
Jan 30, 2024
Contributor
dplumlee
left a comment
dplumlee
left a comment
There was a problem hiding this comment.
Pulled down and tested some use cases, lgtm!
Contributor
Author
|
Thanks a million @dplumlee! |
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
CoenWarmer
pushed a commit
to CoenWarmer/kibana
that referenced
this pull request
Feb 15, 2024
… method with controlled `selection.selected` API (elastic#175726) ## Summary **Please help us QA your affected tables to confirm that your plugin's table selection still works as before!** EUI will shortly be removing this deprecated ref `setSelection` method in favor of the new controlled `selection.selected` prop. This PR converts basic usages of controlled selection, which should not suffer any UI/UX regressions. See also: - elastic/eui#7321 - elastic#175722 (examples of basic conversions) Co-authored-by: Tomasz Ciecierski <tomasz.ciecierski@elastic.co>
fkanout
pushed a commit
to fkanout/kibana
that referenced
this pull request
Mar 4, 2024
… method with controlled `selection.selected` API (elastic#175726) ## Summary **Please help us QA your affected tables to confirm that your plugin's table selection still works as before!** EUI will shortly be removing this deprecated ref `setSelection` method in favor of the new controlled `selection.selected` prop. This PR converts basic usages of controlled selection, which should not suffer any UI/UX regressions. See also: - elastic/eui#7321 - elastic#175722 (examples of basic conversions) Co-authored-by: Tomasz Ciecierski <tomasz.ciecierski@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Please help us QA your affected tables to confirm that your plugin's table selection still works as before!
EUI will shortly be removing this deprecated ref
setSelectionmethod in favor of the new controlledselection.selectedprop. This PR converts basic usages of controlled selection, which should not suffer any UI/UX regressions.See also:
selectionAPI eui#7321selection.selectedAPI #175722 (examples of basic conversions)