Skip to content

[Ops] More resilient test failure collection #175423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
delanni wants to merge 2 commits into from
Closed

[Ops] More resilient test failure collection #175423

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ddd9563
chore: Allow all test reporter steps to run before exiting with a fai…
delanni Jan 24, 2024
6368d1f
chore: fix exit code collection
delanni Jan 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .buildkite/scripts/lifecycle/post_command.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,13 +34,24 @@ if [[ "$IS_TEST_EXECUTION_STEP" == "true" ]]; then
buildkite-agent artifact upload '.es/**/*.hprof'
buildkite-agent artifact upload 'data/es_debug_*.tar.gz'

set +e
TEST_REPORT_EXIT_CODE=0
if [[ $BUILDKITE_COMMAND_EXIT_STATUS -ne 0 ]]; then
echo "--- Run Failed Test Reporter"
node scripts/report_failed_tests --build-url="${BUILDKITE_BUILD_URL}#${BUILDKITE_JOB_ID}" 'target/junit/**/*.xml'
TEST_REPORT_EXIT_CODE=$((TEST_REPORT_EXIT_CODE || $?))
fi

if [[ -d 'target/test_failures' ]]; then
buildkite-agent artifact upload 'target/test_failures/**/*'
TEST_REPORT_EXIT_CODE=$((TEST_REPORT_EXIT_CODE || $?))
ts-node .buildkite/scripts/lifecycle/annotate_test_failures.ts
TEST_REPORT_EXIT_CODE=$((TEST_REPORT_EXIT_CODE || $?))
fi
set -e

if [[ $TEST_REPORT_EXIT_CODE -ne 0 ]]; then
echo "Failed to archive artifacts! See above for details." >&2
exit $TEST_REPORT_EXIT_CODE
fi
fi