[8.10][Ops] Re-enable typecheck#167609
Merged
delanni merged 4 commits intoelastic:8.10from Oct 2, 2023
Merged
Conversation
…c#167392) ## Summary This is hopefully the last batch of typescript issues to be fixed, related to elastic#166813. It's also re-enabling full typecheck, with this, we should be back in a clean, typechecked main branch. Blocked by elastic#167428 --------- Co-authored-by: Brad White <Ikuni17@users.noreply.github.com> Co-authored-by: Brad White <brad.white@elastic.co> Co-authored-by: Thomas Watson <watson@elastic.co> Co-authored-by: Patryk Kopyciński <contact@patrykkopycinski.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 8a29a5e) # Conflicts: # .buildkite/pipelines/pull_request/base.yml # .buildkite/scripts/steps/check_types_commits.sh
delanni
added
backport
Contributor
|
Pinging @elastic/kibana-operations (Team:Operations) |
delanni
changed the title
delanni
added a commit
that referenced
this pull request
Sep 29, 2023
Contributor
Author
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Semi-manual backport of #167392
This would re-enable full typecheck in the 8.10 branch.
Closes: #167373