Skip to content

[8.10][Sec-solutions] Fix a few 8.10 type errors#167618

Merged
delanni merged 1 commit intoelastic:8.10from
delanni:fix-sec-solution-ts-errors-8.10
Sep 29, 2023
Merged

[8.10][Sec-solutions] Fix a few 8.10 type errors#167618
delanni merged 1 commit intoelastic:8.10from
delanni:fix-sec-solution-ts-errors-8.10

Conversation

@delanni
Copy link
Contributor

@delanni delanni commented Sep 29, 2023 •
edited
Loading

Summary

Fix a few issues that occurred around x-pack/plugins/security_solution_ess/tsconfig.json in 8.10.

  • chore(typecheck): fix type errors re: unused variables and missing mock fields

Required for: #167609

Part of: #167373

@delanni delanni added chore Team:Operations Kibana-Operations Team release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.10.3 labels Sep 29, 2023
@elasticmachine
Copy link
Contributor

elasticmachine commented Sep 29, 2023

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

elasticmachine commented Sep 29, 2023

Pinging @elastic/kibana-operations (Team:Operations)

szwarckonrad
szwarckonrad approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@szwarckonrad szwarckonrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@delanni delanni enabled auto-merge (squash) September 29, 2023 11:06
@kibana-ci
Copy link

kibana-ci commented Sep 29, 2023 •
edited
Loading

💔 Build Failed

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolutionServerless 255.2KB 255.2KB -42.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@delanni delanni merged commit df2706e into elastic:8.10 Sep 29, 2023
@delanni delanni deleted the fix-sec-solution-ts-errors-8.10 branch September 29, 2023 13:21
This was referenced Oct 1, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@szwarckonrad szwarckonrad szwarckonrad approved these changes

@watson watson Awaiting requested review from watson

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting chore release_note:skip Skip the PR/issue when compiling release notes Team:Operations Kibana-Operations Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.10.3

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@delanni @elasticmachine @kibana-ci @szwarckonrad