Skip to content

Fix typescript errors in osquery cypress tsconfig#167369

Merged
delanni merged 3 commits intoelastic:mainfrom
delanni:fix/security-types
Sep 27, 2023
Merged

Fix typescript errors in osquery cypress tsconfig#167369
delanni merged 3 commits intoelastic:mainfrom
delanni:fix/security-types

Conversation

@delanni
Copy link
Contributor

@delanni delanni commented Sep 27, 2023

Summary

Supposedly, this is the error that's causing these type of errors:/

Cannot write file '/Users/alex/Git/kibana/x-pack/test/functional/services/random.js' because it would overwrite input file.

Separated off from: #167355

@delanni delanni requested a review from a team as a code owner September 27, 2023 08:11
@delanni delanni added chore release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting v8.11.0 labels Sep 27, 2023
Copy link
Contributor

@tomsonpl tomsonpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks for doing this 👍

@delanni
Copy link
Contributor Author

delanni commented Sep 27, 2023

@elasticmachine merge upstream

@kibana-ci
Copy link

kibana-ci commented Sep 27, 2023

💔 Build Failed

Failed CI Steps

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@delanni
Copy link
Contributor Author

delanni commented Sep 27, 2023

Admin merging because the tests passed, and the only type issue is an unrelated one that's already fixed in main.

@delanni delanni closed this Sep 27, 2023
@delanni delanni reopened this Sep 27, 2023
@delanni delanni merged commit 07570c6 into elastic:main Sep 27, 2023
@delanni delanni deleted the fix/security-types branch September 27, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting chore release_note:skip Skip the PR/issue when compiling release notes v8.11.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants