Merged
Conversation
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
stratoula
added
release_note:skip
Contributor
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
Contributor
|
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
stratoula
commented
Sep 26, 2023
| for (const keyPress of keyPresses) { | ||
| await PageObjects.console.sleepForDebouncePeriod(); | ||
| log.debug('Key', keyPress); | ||
| // @ts-ignore |
Contributor
Author
There was a problem hiding this comment.
I synced with @yuliacech, adding a ts-ignore for now as this test breaks the PRs which are introducing changes to the FTs suites. They are going to fix it properly on another PR.
nreese
approved these changes
Sep 26, 2023
Contributor
nreese
left a comment
nreese
left a comment
There was a problem hiding this comment.
kibana-presentation changes LGTM
code review only
drewdaemon
approved these changes
Sep 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes some types problems in our FTs which are blocking PRs with changes in the functional tests suites. (type diff check is failing)