Skip to content

Fixes some types problems #167228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stratoula merged 2 commits into from
Sep 26, 2023
Merged

Fixes some types problems #167228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
53685da
Fixes some types problems
stratoula Sep 26, 2023
e61bd3a
Fix types errors
stratoula Sep 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion test/functional/apps/console/_autocomplete.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,7 @@ GET _search
for (const keyPress of keyPresses) {
await PageObjects.console.sleepForDebouncePeriod();
log.debug('Key', keyPress);
// @ts-ignore
Copy link
Copy Markdown
Contributor Author

@stratoula stratoula Sep 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I synced with @yuliacech, adding a ts-ignore for now as this test breaks the PRs which are introducing changes to the FTs suites. They are going to fix it properly on another PR.

await PageObjects.console[keyPress]();
expect(await PageObjects.console.isAutocompleteVisible()).to.be.eql(false);
}
Expand Down Expand Up @@ -257,7 +258,7 @@ GET _search
for (const char of [method.at(-1), ' ', '_']) {
await PageObjects.console.sleepForDebouncePeriod();
log.debug('Key type "%s"', char);
await PageObjects.console.enterText(char); // e.g. 'Post ' -> 'Post _'
await PageObjects.console.enterText(char ?? ''); // e.g. 'Post ' -> 'Post _'
}

await retry.waitFor('autocomplete to be visible', () =>
Expand Down
2 changes: 1 addition & 1 deletion test/functional/apps/dashboard_elements/controls/common/replace_controls.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
const retry = getService('retry');
const security = getService('security');

const { dashboardControls, timePicker, common, dashboard } = getPageObjects([
const { dashboardControls, timePicker, dashboard } = getPageObjects([
'dashboardControls',
'timePicker',
'dashboard',
Expand Down
1 change: 0 additions & 1 deletion test/functional/apps/visualize/group2/_inspector.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
const log = getService('log');
const inspector = getService('inspector');
const filterBar = getService('filterBar');
const monacoEditor = getService('monacoEditor');
const PageObjects = getPageObjects(['visualize', 'visEditor', 'visChart', 'timePicker']);

describe('inspector', function describeIndexTests() {
Expand Down