Skip to content

[type check] Fix ./test/tsconfig.json TypeScript errors#167239

Merged
watson merged 3 commits intoelastic:mainfrom
watson:fix-types
Sep 26, 2023
Merged

[type check] Fix ./test/tsconfig.json TypeScript errors#167239
watson merged 3 commits intoelastic:mainfrom
watson:fix-types

Conversation

@watson
Copy link
Contributor

@watson watson commented Sep 26, 2023

TypeScript errors introduced in #163233, #166377, #166565

@watson watson added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting labels Sep 26, 2023
@watson watson self-assigned this Sep 26, 2023
@watson watson requested review from a team as code owners September 26, 2023 12:01
@nreese
Copy link
Contributor

nreese commented Sep 26, 2023

This PR has a lot of overlap with #167228. Not sure if @stratoula and @watson want to chat to discuss which moves forward

@stratoula
Copy link
Contributor

@watson sorry! I merged mine, I just saw this. I resolved the conflicts in your PR

@stratoula stratoula removed request for a team September 26, 2023 12:24
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM

@kibana-ci
Copy link

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #15 / serverless security UI Case View page "before all" hook for "should show the case view page correctly"

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @watson

@watson watson merged commit f42b40f into elastic:main Sep 26, 2023
@watson watson deleted the fix-types branch September 26, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.11.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants