[Defend Workflows] Adjust headers in fleet api#165823
[Defend Workflows] Adjust headers in fleet api#165823tomsonpl merged 10 commits intoelastic:mainfrom
Conversation
# Conflicts: # x-pack/plugins/security_solution/scripts/endpoint/endpoint_agent_runner/fleet_server.ts
ashokaditya
left a comment
There was a problem hiding this comment.
I've two suggestions.
- use consistent lowercase
elastic-api-versioneverywhere - move
headerskey to the top of everyrequestobject, so
request( headers, method, path, body)
criamico
left a comment
There was a problem hiding this comment.
LGTM, thanks for fixing the missing versions in Fleet!
💛 Build succeeded, but was flaky
Failed CI Steps
Test Failures
Metrics [docs]Public APIs missing comments
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @tomsonpl |
|
Pinging @elastic/security-defend-workflows (Team:Defend Workflows) |
|
Pinging @elastic/fleet (Team:Fleet) |
szwarckonrad
left a comment
There was a problem hiding this comment.
Good job @ashokaditya @gergoabraham @tomsonpl , thanks for taking care of this!
Worth to mention that Osquery tests found some missing pieces in api/fleet (missing version).
Combined work of @szwarckonrad @gergoabraham @ashokaditya - thanks!