Skip to content

[Defend Workflows] Adjust headers in fleet api#165823

Merged
tomsonpl merged 10 commits intoelastic:mainfrom
tomsonpl:fix-headers-fleet
Sep 6, 2023
Merged

[Defend Workflows] Adjust headers in fleet api#165823
tomsonpl merged 10 commits intoelastic:mainfrom
tomsonpl:fix-headers-fleet

Conversation

@tomsonpl
Copy link
Copy Markdown
Contributor

@tomsonpl tomsonpl commented Sep 6, 2023

Worth to mention that Osquery tests found some missing pieces in api/fleet (missing version).

Combined work of @szwarckonrad @gergoabraham @ashokaditya - thanks!

@tomsonpl tomsonpl self-assigned this Sep 6, 2023
Copy link
Copy Markdown
Member

@ashokaditya ashokaditya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've two suggestions.

  1. use consistent lowercase elastic-api-version everywhere
  2. move headers key to the top of every request object, so
 request( headers, method, path, body)

@gergoabraham gergoabraham added the Team:Defend Workflows “EDR Workflows” sub-team of Security Solution label Sep 6, 2023
Copy link
Copy Markdown
Contributor

@criamico criamico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing the missing versions in Fleet!

@kibana-ci
Copy link
Copy Markdown

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Serverless Security Cypress Tests #8 / Add endpoint exception from rule details edits an endpoint exception item edits an endpoint exception item
  • [job] [logs] Serverless Security Investigations Cypress Tests #2 / Export timelines "before all" hook for "Exports a custom timeline template" "before all" hook for "Exports a custom timeline template"
  • [job] [logs] Serverless Security Investigations Cypress Tests #6 / Toggle full screen "before each" hook for "Should hide timeline header and tab list area" "before each" hook for "Should hide timeline header and tab list area"

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
fleet 1073 1082 +9

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 1.2MB 1.2MB +44.0B
securitySolution 12.6MB 12.6MB +478.0B
total +522.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
fleet 142.3KB 142.5KB +114.0B
Unknown metric groups

API count

id before after diff
fleet 1189 1199 +10

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @tomsonpl

@tomsonpl tomsonpl marked this pull request as ready for review September 6, 2023 13:36
@tomsonpl tomsonpl requested review from a team as code owners September 6, 2023 13:36
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

@tomsonpl tomsonpl added chore release_note:skip Skip the PR/issue when compiling release notes v8.11.0 labels Sep 6, 2023
Copy link
Copy Markdown
Contributor

@criamico criamico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fleet LGTM

@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Sep 6, 2023
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/fleet (Team:Fleet)

Copy link
Copy Markdown
Contributor

@szwarckonrad szwarckonrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @ashokaditya @gergoabraham @tomsonpl , thanks for taking care of this!

Copy link
Copy Markdown
Member

@ashokaditya ashokaditya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 it!

@tomsonpl tomsonpl merged commit 630a95b into elastic:main Sep 6, 2023
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting chore release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution Team:Fleet Team label for Observability Data Collection Fleet team v8.11.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants