Skip to content

[Security Solution][Endpoint] Transition to fleet versioned APIs on Management pages#165811

Closed
gergoabraham wants to merge 2 commits intoelastic:mainfrom
gergoabraham:fix/add-version-to-fleet-api-calls
Closed

[Security Solution][Endpoint] Transition to fleet versioned APIs on Management pages#165811
gergoabraham wants to merge 2 commits intoelastic:mainfrom
gergoabraham:fix/add-version-to-fleet-api-calls

Conversation

@gergoabraham
Copy link
Copy Markdown
Contributor

Summary

adding version header to API calls towards Fleet on Management pages, as Fleet requires version since PR: /pull/163570

@gergoabraham gergoabraham added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Team:Defend Workflows “EDR Workflows” sub-team of Security Solution labels Sep 6, 2023
@gergoabraham gergoabraham requested a review from a team as a code owner September 6, 2023 09:10
@gergoabraham gergoabraham self-assigned this Sep 6, 2023
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

Copy link
Copy Markdown
Member

@ashokaditya ashokaditya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should import the API_VERSIONS from '@kbn/fleet-plugin/common/constants' and use that to set the versions.

version: API_VERSIONS.public.v1

@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Sep 6, 2023

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #16 / ingest service sendGetEndpointSecurityPackage() should query for endpoint package
  • [job] [logs] Jest Tests #16 / ingest service sendGetEndpointSpecificPackagePolicies() auto adds kuery to api request
  • [job] [logs] Jest Tests #16 / ingest service sendGetEndpointSpecificPackagePolicies() supports additional KQL to be defined on input for query params
  • [job] [logs] Jest Tests #16 / ingest service sendGetPackagePolicy() builds correct API path
  • [job] [logs] Jest Tests #16 / ingest service sendGetPackagePolicy() supports http options
  • [job] [logs] Jest Tests #16 / When rendering PolicySettingsLayout and user has Edit permissions should allow updates to be made
  • [job] [logs] Jest Tests #16 / When using the useFetchEndpointPolicyAgentSummary() hook should call the correct api with expected value
  • [job] [logs] Jest Tests #16 / When using the useFetchEndpointPolicyAgentSummary() hook should send expected update payload
  • [job] [logs] Jest Tests #16 / When using the useGetFileInfo() hook should call the correct api with expected value

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @gergoabraham

@gergoabraham
Copy link
Copy Markdown
Contributor Author

closing this in favor of #165823

@gergoabraham gergoabraham deleted the fix/add-version-to-fleet-api-calls branch September 6, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants