Skip to content

[Security Solution][Endpoint] Transition to fleet versioned APIs on data loaders#165806

Closed
ashokaditya wants to merge 4 commits intoelastic:mainfrom
ashokaditya:task/dw-fix-data-loaders-using-fleet-versioned-apis-7547
Closed

[Security Solution][Endpoint] Transition to fleet versioned APIs on data loaders#165806
ashokaditya wants to merge 4 commits intoelastic:mainfrom
ashokaditya:task/dw-fix-data-loaders-using-fleet-versioned-apis-7547

Conversation

@ashokaditya
Copy link
Copy Markdown
Member

@ashokaditya ashokaditya commented Sep 6, 2023 •
edited
Loading

Summary

security_solution data loader scripts using fleet APIs need to move to versioned fleet APIs after changes in /pull/163570

related PR /pull/165823

@ashokaditya
transition to fleet versioned APIs
5a43e38 
security_solution data loader scripts using fleet APIs
need to move to versioned fleet APIs after changes in elastic/pull/163570

refs elastic/security-team/issues/7547
@ashokaditya ashokaditya requested a review from a team as a code owner September 6, 2023 08:45
@ashokaditya ashokaditya self-assigned this Sep 6, 2023
@ashokaditya ashokaditya added release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution OLM Sprint v8.11.0 labels Sep 6, 2023
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Sep 6, 2023

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

gergoabraham
gergoabraham approved these changes Sep 6, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@gergoabraham gergoabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking great! 💯

also, stole your idea to rather use the API_VERSIONS 🙌

@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Sep 6, 2023 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Defend Workflows Endpoint Cypress Tests #6 / Response console User journey for Isolate command: isolate and release an endpoint should isolate host from response console should isolate host from response console
  • [job] [logs] Defend Workflows Endpoint Cypress Tests #6 / Response console User journey for Isolate command: isolate and release an endpoint should release host from response console should release host from response console
  • [job] [logs] Serverless Observability Tests / serverless common UI Data View Management Scripted fields tab is missing

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @ashokaditya

@ashokaditya
Copy link
Copy Markdown
Member Author

ashokaditya commented Sep 6, 2023

/pull/165823 has the same fixes

@ashokaditya ashokaditya closed this Sep 6, 2023
@ashokaditya ashokaditya deleted the task/dw-fix-data-loaders-using-fleet-versioned-apis-7547 branch September 6, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gergoabraham gergoabraham gergoabraham approved these changes

@parkiino parkiino Awaiting requested review from parkiino parkiino was automatically assigned from elastic/security-defend-workflows

@paul-tavares paul-tavares Awaiting requested review from paul-tavares paul-tavares was automatically assigned from elastic/security-defend-workflows

Assignees

@ashokaditya ashokaditya

Labels

OLM Sprint release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.11.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ashokaditya @elasticmachine @kibana-ci @gergoabraham