[Logs+] End onboarding wizard in default discover by mohamedhamed-ahmed · Pull Request #163218 · elastic/kibana

mohamedhamed-ahmed · 2023-08-04T22:02:36Z

📝 Summary

This PR navigates to default discover at the end of the onboarding flow for both custom and system workflows.
It also adds logs-* as the default dataview along with a preset filter for the intended dataset during the onboarding flow.

✅ Testing

Navigate to the onboarding flow /app/observabilityOnboarding/
Choose either System logs or Stream log files
Go through the onboarding wizard
Click the Explore logs button at the end
Observe the DataView and Preset Filter after being navigated to Discover

🎥 Demo

Screen.Recording.2023-08-04.at.17.33.13.mov

ghost · 2023-08-04T22:02:53Z

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

/oblt-deploy : Deploy a Kibana instance using the Observability test environments.
/oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

…fix'

…onboarding-wizard-ends-in-default-discover

elasticmachine · 2023-08-05T05:47:50Z

Pinging @elastic/apm-ui (Team:APM)

elasticmachine · 2023-08-05T05:47:52Z

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

…cover

…onboarding-wizard-ends-in-default-discover

…cover

yngrdyn · 2023-08-07T09:15:49Z

For system logs, the datasets are system.auth and system.syslog. Maybe you'll need to get the latest version in master.

I need to work on installing the system integration, wouldn't make more sense then to land in the integration view when finishing the system logs onboarding?

…onboarding-wizard-ends-in-default-discover

mohamedhamed-ahmed · 2023-08-07T09:27:24Z

For system logs, the datasets are system.auth and system.syslog. Maybe you'll need to get the latest version in master.

Doesn't matter in the scope of the PR as I actually read whatever dataset is created there, but what you are saying is absolutely correct as when I got latest it changes the name of the selected dataset 👍 Thanks for pointing out that this changed already 😊 was really confusing during testing

I need to work on installing the system integration, wouldn't make more sense then to land in the integration view when finishing the system logs onboarding?

integration view is part of the log-explorer profile, and as for the scope of 8.10 we agreed on making the navigation always point to the default discover view and not the log-explorer profile one.
After 8.10 we are planning to continue working on this ticket which will then apply the changes you suggested, and will point to the integration view.
@weltenwort please correct me if I missed something here.

One more question, to make sure I got it correct does this mean we have 2 datasets in case of system logs that we need to filter on with an or condition, but always a single dataset in case of the custom logs?

gbamparop · 2023-08-07T09:49:29Z

Is it navigating to default discover for serverless projects too?

yngrdyn · 2023-08-07T09:57:15Z

One more question, to make sure I got it correct does this mean we have 2 datasets in case of system logs that we need to filter on with an or condition, but always a single dataset in case of the custom logs?

yes, since for the system logs we are the ones defining the dataset we have those two (as we already have when using fleet), for custom logs is the user who defines the dataset so they will end up having just one even when they configure multiple paths.

mohamedhamed-ahmed · 2023-08-07T10:16:16Z

Is it navigating to default discover for serverless projects too?

yes its always pointing to default discover in 8.10

yngrdyn

LGTM 🧙🏼‍♂️

…onboarding-wizard-ends-in-default-discover

kibana-ci · 2023-08-07T18:32:54Z

💚 Build Succeeded

Buildkite Build
Commit: 3c0d6cb

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`observabilityOnboarding`	74	109	+35

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`observabilityOnboarding`	107.1KB	277.9KB	+170.8KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`observabilityOnboarding`	4.6KB	4.6KB	+54.0B

History

💚 Build #147893 succeeded fc980e4
💚 Build #147821 succeeded 2cdaf0f
💔 Build #147813 failed d852c4a
💔 Build #147797 failed 4338f3d
💚 Build #147714 succeeded 6cf9e5e
💚 Build #147705 succeeded 024ea14

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

closes [elastic#163080](elastic#163080) ## 📝 Summary This PR navigates to default discover at the end of the onboarding flow for both custom and system workflows. It also adds `logs-*` as the default dataview along with a preset filter for the intended dataset during the onboarding flow. ## ✅ Testing 1. Navigate to the onboarding flow `/app/observabilityOnboarding/` 2. Choose either System logs or Stream log files 3. Go through the onboarding wizard 4. Click the Explore logs button at the end 5. Observe the DataView and Preset Filter after being navigated to Discover ## 🎥 Demo https://github.com/elastic/kibana/assets/11225826/5eff74e4-c12a-46e7-968a-6efa34a6a7a9 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

closes #164995 closes #165618 closes #166596 ## 📝 Summary ### Observability Log Explorer Locators: This PR adds 2 new customized locators to the Observability log explorer profile. At the moment we implemented: 1- Single dataset selector locator 2- All dataset selector locator With more locators to come in the future depending on the use cases. ### Log Explorer Locators: We also added a log explorer locator that navigates to discover, this can be used in case the **Observability Log Explorer** plugin is disabled. ### Logs Onboarding: The PR also replaces the temp navigation to the default discover we implemented for[ 8.10 here](#163218) with the above new Observability Log Explorer locators. ### APM: After [disabling infra plugin in serverless projects](#165289), APM links to infra locators in serverless have been replaced to use the above locators. ### Observability Landing Page: The landing page now redirects to the Log Explorer if `logs-*-*` has data in it, otherwise the flow continues as before. ### Necessary Refactoring: To avoid the circular dependency between `ObservabilityLogExplorer` & `ObservabilityOnboarding` after each one using the other's locator and importing the necessary types, I moved the type definition for all locators in the `deeplinks` package. ## ✅ Testing - Onboarding Wizard in Serverless and Stateful 1. Navigate to the onboarding flow `/app/observabilityOnboarding/` 2. Choose either System logs or Stream log files 3. Go through the onboarding wizard 4. Click the Explore logs button at the end 5. You should be redirected to observability log explorer with the integration and dataset preselected. - APM links in Serverless 1. Navigate to APM and click on the logs links as shown in the Demos below 2. All links should navigate to Observability Log Explorer with the queries set in the search bar. ## 🎥 Demos - APM Serverless https://github.com/elastic/kibana/assets/11225826/7161364e-333f-4ac4-87d5-7f1ffec699b3 - APM Stateful https://github.com/elastic/kibana/assets/11225826/058c9587-b766-4d4f-a73d-50fd381be4bb - Onboarding Serverless https://github.com/elastic/kibana/assets/11225826/ee1cab42-f91c-4558-aa5f-4fa7e8963427 - Onboarding Stateful https://github.com/elastic/kibana/assets/11225826/a376a12b-499b-4488-a75a-d06e81f8e21d - Observability Landing Page https://github.com/elastic/kibana/assets/11225826/c1c084ca-b1b1-4c4b-a4e6-ae8e157dcf57 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani@elastic.co> Co-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani01@gmail.com>

closes elastic#164995 closes elastic#165618 closes elastic#166596 ## 📝 Summary ### Observability Log Explorer Locators: This PR adds 2 new customized locators to the Observability log explorer profile. At the moment we implemented: 1- Single dataset selector locator 2- All dataset selector locator With more locators to come in the future depending on the use cases. ### Log Explorer Locators: We also added a log explorer locator that navigates to discover, this can be used in case the **Observability Log Explorer** plugin is disabled. ### Logs Onboarding: The PR also replaces the temp navigation to the default discover we implemented for[ 8.10 here](elastic#163218) with the above new Observability Log Explorer locators. ### APM: After [disabling infra plugin in serverless projects](elastic#165289), APM links to infra locators in serverless have been replaced to use the above locators. ### Observability Landing Page: The landing page now redirects to the Log Explorer if `logs-*-*` has data in it, otherwise the flow continues as before. ### Necessary Refactoring: To avoid the circular dependency between `ObservabilityLogExplorer` & `ObservabilityOnboarding` after each one using the other's locator and importing the necessary types, I moved the type definition for all locators in the `deeplinks` package. ## ✅ Testing - Onboarding Wizard in Serverless and Stateful 1. Navigate to the onboarding flow `/app/observabilityOnboarding/` 2. Choose either System logs or Stream log files 3. Go through the onboarding wizard 4. Click the Explore logs button at the end 5. You should be redirected to observability log explorer with the integration and dataset preselected. - APM links in Serverless 1. Navigate to APM and click on the logs links as shown in the Demos below 2. All links should navigate to Observability Log Explorer with the queries set in the search bar. ## 🎥 Demos - APM Serverless https://github.com/elastic/kibana/assets/11225826/7161364e-333f-4ac4-87d5-7f1ffec699b3 - APM Stateful https://github.com/elastic/kibana/assets/11225826/058c9587-b766-4d4f-a73d-50fd381be4bb - Onboarding Serverless https://github.com/elastic/kibana/assets/11225826/ee1cab42-f91c-4558-aa5f-4fa7e8963427 - Onboarding Stateful https://github.com/elastic/kibana/assets/11225826/a376a12b-499b-4488-a75a-d06e81f8e21d - Observability Landing Page https://github.com/elastic/kibana/assets/11225826/c1c084ca-b1b1-4c4b-a4e6-ae8e157dcf57 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani@elastic.co> Co-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani01@gmail.com>

[Logs+] End onboarding wizard in default discover

ae8582d

kibanamachine and others added 3 commits August 4, 2023 22:08

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

0e228e5

…fix'

Await on navigation

deebbe1

Merge branch 'main' of https://github.com/elastic/kibana into 163080-…

024ea14

…onboarding-wizard-ends-in-default-discover

mohamedhamed-ahmed marked this pull request as ready for review August 5, 2023 05:47

mohamedhamed-ahmed requested a review from a team August 5, 2023 05:47

mohamedhamed-ahmed added 3 commits August 5, 2023 06:48

Merge branch 'main' into 163080-onboarding-wizard-ends-in-default-dis…

6cf9e5e

…cover

Merge branch 'main' of https://github.com/elastic/kibana into 163080-…

4338f3d

…onboarding-wizard-ends-in-default-discover

Merge branch 'main' into 163080-onboarding-wizard-ends-in-default-dis…

d852c4a

…cover

Merge branch 'main' of https://github.com/elastic/kibana into 163080-…

2cdaf0f

…onboarding-wizard-ends-in-default-discover

mohamedhamed-ahmed added 2 commits August 7, 2023 12:39

Add support for multiple filters

db9dc1f

Moved generators to common folder

fc980e4

yngrdyn approved these changes Aug 7, 2023

View reviewed changes

mohamedhamed-ahmed added 2 commits August 7, 2023 19:26

Bug Fix

a4e5049

Merge branch 'main' of https://github.com/elastic/kibana into 163080-…

3c0d6cb

…onboarding-wizard-ends-in-default-discover

mohamedhamed-ahmed merged commit a42df25 into elastic:main Aug 7, 2023

mohamedhamed-ahmed mentioned this pull request Aug 12, 2023

[Logs+] Add specialized locators #163148

Closed

mohamedhamed-ahmed mentioned this pull request Sep 12, 2023

[Log Explorer] Add Explorer app locator #165962

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Logs+] End onboarding wizard in default discover#163218

[Logs+] End onboarding wizard in default discover#163218
mohamedhamed-ahmed merged 12 commits intoelastic:mainfrom
mohamedhamed-ahmed:163080-onboarding-wizard-ends-in-default-discover

mohamedhamed-ahmed commented Aug 4, 2023 •

edited

Loading

Uh oh!

ghost commented Aug 4, 2023

Uh oh!

elasticmachine commented Aug 5, 2023

Uh oh!

elasticmachine commented Aug 5, 2023

Uh oh!

yngrdyn commented Aug 7, 2023

Uh oh!

mohamedhamed-ahmed commented Aug 7, 2023 •

edited

Loading

Uh oh!

gbamparop commented Aug 7, 2023

Uh oh!

yngrdyn commented Aug 7, 2023

Uh oh!

mohamedhamed-ahmed commented Aug 7, 2023

Uh oh!

yngrdyn left a comment

Uh oh!

kibana-ci commented Aug 7, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

mohamedhamed-ahmed commented Aug 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📝 Summary

✅ Testing

🎥 Demo

Uh oh!

ghost commented Aug 4, 2023

🤖 GitHub comments

Uh oh!

elasticmachine commented Aug 5, 2023

Uh oh!

elasticmachine commented Aug 5, 2023

Uh oh!

yngrdyn commented Aug 7, 2023

Uh oh!

mohamedhamed-ahmed commented Aug 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gbamparop commented Aug 7, 2023

Uh oh!

yngrdyn commented Aug 7, 2023

Uh oh!

mohamedhamed-ahmed commented Aug 7, 2023

Uh oh!

yngrdyn left a comment

Choose a reason for hiding this comment

Uh oh!

kibana-ci commented Aug 7, 2023

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

Page load bundle

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

mohamedhamed-ahmed commented Aug 4, 2023 •

edited

Loading

mohamedhamed-ahmed commented Aug 7, 2023 •

edited

Loading