[Logs+] Add specialized locators#163148
[Logs+] Add specialized locators#163148mohamedhamed-ahmed wants to merge 13 commits intoelastic:mainfrom
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
…logs-explorer-add-specialized-locators
…logs-explorer-add-specialized-locators
…logs-explorer-add-specialized-locators
x-pack/plugins/discover_log_explorer/public/services/datasets/datasets_service.ts
Show resolved
Hide resolved
|
I implemented the locators in the common folder, and as a result, had to move the public/utils into common |
| const datasetsService = new DatasetsService().start({ | ||
| http: core.http, | ||
| }); | ||
| const [{ initializeLogExplorerProfileStateService, waitForState }] = await Promise.all([ |
There was a problem hiding this comment.
We can maybe remove the Prmise.all as its not needed anymore
const { initializeLogExplorerProfileStateService, waitForState } =
await logExplorerMachineModuleLoadable;
|
Pinging @elastic/apm-ui (Team:APM) |
|
Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI) |
Are they going to be allowed to navigate? or should the |
…logs-explorer-add-specialized-locators
AFAIK they will be allowed to continue. Maybe @ruflin, @isaclfreire or @grabowskit can shed a light regarding this. |
@yngrdyn Adding to what you mentioned.
The problem is in |
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Public APIs missing exports
Page load bundle
Unknown metric groupsAPI count
async chunk count
History
To update your PR or re-run it, just comment with: |
|
@mohamedhamed-ahmed as discussed, let's redirect this PR to target #164995. I reduced the scope and fields a bit in comparison to the original ACs. |
|
This PR will be closed as it has been implemented as part of this PR |





closes #158382
📝 Summary
This PR adds new customized locators to the log explorer profile. At the moment we only implemented a single dataset selector locator, but we are planning to have more when we start implementing the multiselect in the dataset selector.
The PR replaces the temp navigation to the default discover we implemented for 8.10 here.
✅ Testing
/app/observabilityOnboarding/🎥 Demo
Screen.Recording.2023-08-11.at.21.29.57.mov