[Infra] Disable infra plugin in serverless projects by crespocarlos · Pull Request #165289 · elastic/kibana

crespocarlos · 2023-08-31T07:52:22Z

closes #158925

Summary

This PR disables the infra plugin in the oblt and security projects

Oblt

Navbar

Saved Objects

Server-side APIs

Infra routes
/metrics/inventory

Alert rules

APM

Infra links hidden in the Transaction "Investigate" pop up menu

Infra links removed from Services Overview Instance actions

** Server Routes **

Security

Saved Objects

Server-side APIs

Infra routes
/metrics/inventory

How to test

Start a local ES instance
run yarn serverless-oblt and yarn serverless-security
Validate the screenshots above.

ghost · 2023-08-31T07:52:38Z

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

/oblt-deploy : Deploy a Kibana instance using the Observability test environments.
/oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

…infra-in-serverless-projets

crespocarlos · 2023-08-31T10:08:28Z

@elasticmachine merge upstream

crespocarlos · 2023-08-31T11:03:58Z

buildkite test this

crespocarlos · 2023-08-31T11:07:33Z

@elasticmachine merge upstream

crespocarlos · 2023-08-31T12:10:56Z

@elasticmachine merge upstream

weltenwort · 2023-08-31T14:21:47Z

/oblt-deploy-serverless

crespocarlos · 2023-08-31T15:31:16Z

/oblt-deploy-serverless

crespocarlos · 2023-08-31T17:40:32Z

@elasticmachine merge upstream

crespocarlos · 2023-08-31T20:18:20Z

@elasticmachine merge upstream

crespocarlos · 2023-09-01T08:00:48Z

@elasticmachine merge upstream

crespocarlos · 2023-09-04T13:59:00Z

@elasticmachine merge upstream

crespocarlos · 2023-09-06T11:06:31Z

Hi @weltenwort , thanks for reviewing it.

Can we also mark the infra plugin as optional in the apm plugin's server-side types? That way we can let the compiler enforce the softness of the dependency in the server-side code too.

Done! I had to touch 3 endpoints. While doing this I also found a couple more places in the UI that depended on InfraLocators. Fixed those too.

When starting Kibana I noticed that it disables the plugin ux because it has a dependency on infra. Can we clarify whether ux is supposed to be disabled?

Apparently ux didn't even need to depend on infra. I've removed it from the dependency list.

crespocarlos · 2023-09-06T12:49:18Z

@elasticmachine merge upstream

crespocarlos · 2023-09-07T07:44:57Z

@elasticmachine merge upstream

tonyghiani · 2023-09-07T08:28:08Z

I closed it by mistake, I was in the wrong browser tab I'm sorry 🙏

crespocarlos · 2023-09-07T09:18:57Z

@elasticmachine merge upstream

weltenwort

LGTM, tested on a QA serverless project 👍 thanks for taking care of this.

I'll leave it to the apm-ui team to judge whether throwing exceptions is the appropriate way of handling a disabled infra dependency.

MiriamAparicio

LGTM

crespocarlos · 2023-09-08T09:47:15Z

@elasticmachine merge upstream

crespocarlos · 2023-09-08T11:59:03Z

@elasticmachine merge upstream

kibana-ci · 2023-09-08T12:38:25Z

💚 Build Succeeded

Buildkite Build
Commit: 77f4914
Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-165289-77f4914bacdc

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`apm`	3.7MB	3.7MB	+130.0B

Canvas Sharable Runtime

The Canvas "shareable runtime" is an bundle produced to enable running Canvas workpads outside of Kibana. This bundle is included in third-party webpages that embed canvas and therefor should be as slim as possible.

id	before	after	diff
`module count`	-	5594	+5594
`total size`	-	6.0MB	+6.0MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

closes #164995 closes #165618 closes #166596 ## 📝 Summary ### Observability Log Explorer Locators: This PR adds 2 new customized locators to the Observability log explorer profile. At the moment we implemented: 1- Single dataset selector locator 2- All dataset selector locator With more locators to come in the future depending on the use cases. ### Log Explorer Locators: We also added a log explorer locator that navigates to discover, this can be used in case the **Observability Log Explorer** plugin is disabled. ### Logs Onboarding: The PR also replaces the temp navigation to the default discover we implemented for[ 8.10 here](#163218) with the above new Observability Log Explorer locators. ### APM: After [disabling infra plugin in serverless projects](#165289), APM links to infra locators in serverless have been replaced to use the above locators. ### Observability Landing Page: The landing page now redirects to the Log Explorer if `logs-*-*` has data in it, otherwise the flow continues as before. ### Necessary Refactoring: To avoid the circular dependency between `ObservabilityLogExplorer` & `ObservabilityOnboarding` after each one using the other's locator and importing the necessary types, I moved the type definition for all locators in the `deeplinks` package. ## ✅ Testing - Onboarding Wizard in Serverless and Stateful 1. Navigate to the onboarding flow `/app/observabilityOnboarding/` 2. Choose either System logs or Stream log files 3. Go through the onboarding wizard 4. Click the Explore logs button at the end 5. You should be redirected to observability log explorer with the integration and dataset preselected. - APM links in Serverless 1. Navigate to APM and click on the logs links as shown in the Demos below 2. All links should navigate to Observability Log Explorer with the queries set in the search bar. ## 🎥 Demos - APM Serverless https://github.com/elastic/kibana/assets/11225826/7161364e-333f-4ac4-87d5-7f1ffec699b3 - APM Stateful https://github.com/elastic/kibana/assets/11225826/058c9587-b766-4d4f-a73d-50fd381be4bb - Onboarding Serverless https://github.com/elastic/kibana/assets/11225826/ee1cab42-f91c-4558-aa5f-4fa7e8963427 - Onboarding Stateful https://github.com/elastic/kibana/assets/11225826/a376a12b-499b-4488-a75a-d06e81f8e21d - Observability Landing Page https://github.com/elastic/kibana/assets/11225826/c1c084ca-b1b1-4c4b-a4e6-ae8e157dcf57 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani@elastic.co> Co-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani01@gmail.com>

closes elastic#164995 closes elastic#165618 closes elastic#166596 ## 📝 Summary ### Observability Log Explorer Locators: This PR adds 2 new customized locators to the Observability log explorer profile. At the moment we implemented: 1- Single dataset selector locator 2- All dataset selector locator With more locators to come in the future depending on the use cases. ### Log Explorer Locators: We also added a log explorer locator that navigates to discover, this can be used in case the **Observability Log Explorer** plugin is disabled. ### Logs Onboarding: The PR also replaces the temp navigation to the default discover we implemented for[ 8.10 here](elastic#163218) with the above new Observability Log Explorer locators. ### APM: After [disabling infra plugin in serverless projects](elastic#165289), APM links to infra locators in serverless have been replaced to use the above locators. ### Observability Landing Page: The landing page now redirects to the Log Explorer if `logs-*-*` has data in it, otherwise the flow continues as before. ### Necessary Refactoring: To avoid the circular dependency between `ObservabilityLogExplorer` & `ObservabilityOnboarding` after each one using the other's locator and importing the necessary types, I moved the type definition for all locators in the `deeplinks` package. ## ✅ Testing - Onboarding Wizard in Serverless and Stateful 1. Navigate to the onboarding flow `/app/observabilityOnboarding/` 2. Choose either System logs or Stream log files 3. Go through the onboarding wizard 4. Click the Explore logs button at the end 5. You should be redirected to observability log explorer with the integration and dataset preselected. - APM links in Serverless 1. Navigate to APM and click on the logs links as shown in the Demos below 2. All links should navigate to Observability Log Explorer with the queries set in the search bar. ## 🎥 Demos - APM Serverless https://github.com/elastic/kibana/assets/11225826/7161364e-333f-4ac4-87d5-7f1ffec699b3 - APM Stateful https://github.com/elastic/kibana/assets/11225826/058c9587-b766-4d4f-a73d-50fd381be4bb - Onboarding Serverless https://github.com/elastic/kibana/assets/11225826/ee1cab42-f91c-4558-aa5f-4fa7e8963427 - Onboarding Stateful https://github.com/elastic/kibana/assets/11225826/a376a12b-499b-4488-a75a-d06e81f8e21d - Observability Landing Page https://github.com/elastic/kibana/assets/11225826/c1c084ca-b1b1-4c4b-a4e6-ae8e157dcf57 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani@elastic.co> Co-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani01@gmail.com>

## Summary Closes #165227. Removes configurable app targets. Only the standard logs app is registered (Note: [Infra is disabled in serverless](#165289) observability / security projects currently). --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Disable infra in serverless

1f2af52

Merge branch 'main' of github.com:elastic/kibana into 158925-disable-…

8547218

…infra-in-serverless-projets

crespocarlos requested a review from weltenwort August 31, 2023 09:06

crespocarlos changed the title ~~Disable infra in serverless~~ [Infra] Disable infra plugin in serverless projects Aug 31, 2023

crespocarlos added release_note:fix Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services backport:skip This PR does not require backporting v8.11.0 labels Aug 31, 2023

Merge branch 'main' into 158925-disable-infra-in-serverless-projets

0f292c8

Merge branch 'main' into 158925-disable-infra-in-serverless-projets

64c74f1

Merge branch 'main' into 158925-disable-infra-in-serverless-projets

a488652

Turn infra into optional dependency in APM

c8708d0

Merge branch 'main' into 158925-disable-infra-in-serverless-projets

ba362fa

Merge branch 'main' into 158925-disable-infra-in-serverless-projets

f10960e

Merge branch 'main' into 158925-disable-infra-in-serverless-projets

b92d697

Merge branch 'main' into 158925-disable-infra-in-serverless-projets

54ed0a7

crespocarlos marked this pull request as ready for review September 4, 2023 13:59

crespocarlos requested a review from a team as a code owner September 4, 2023 13:59

crespocarlos requested a review from a team September 4, 2023 13:59

shahzad31 approved these changes Sep 6, 2023

View reviewed changes

weltenwort added the ci:build-serverless-image label Sep 6, 2023

Merge branch 'main' into 158925-disable-infra-in-serverless-projets

8e09ff4

Merge branch 'main' into 158925-disable-infra-in-serverless-projets

022130b

tonyghiani closed this Sep 7, 2023

tonyghiani reopened this Sep 7, 2023

Merge branch 'main' into 158925-disable-infra-in-serverless-projets

c33ca08

crespocarlos requested a review from weltenwort September 7, 2023 12:00

crespocarlos added release_note:skip Skip the PR/issue when compiling release notes and removed release_note:fix labels Sep 7, 2023

weltenwort approved these changes Sep 7, 2023

View reviewed changes

MiriamAparicio approved these changes Sep 8, 2023

View reviewed changes

Merge branch 'main' into 158925-disable-infra-in-serverless-projets

84ed203

Merge branch 'main' into 158925-disable-infra-in-serverless-projets

77f4914

crespocarlos merged commit 7ba3554 into elastic:main Sep 8, 2023

crespocarlos deleted the 158925-disable-infra-in-serverless-projets branch September 8, 2023 13:05

mohamedhamed-ahmed mentioned this pull request Sep 12, 2023

[Log Explorer] Add Explorer app locator #165962

Merged

Kerry350 mentioned this pull request Sep 25, 2023

[Logs+] Remove configurable redirects to Discover #167151

Merged

Conversation

crespocarlos commented Aug 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Oblt

APM

Security

How to test

Uh oh!

ghost commented Aug 31, 2023

🤖 GitHub comments

Uh oh!

crespocarlos commented Aug 31, 2023

Uh oh!

crespocarlos commented Aug 31, 2023

Uh oh!

crespocarlos commented Aug 31, 2023

Uh oh!

crespocarlos commented Aug 31, 2023

Uh oh!

weltenwort commented Aug 31, 2023

Uh oh!

crespocarlos commented Aug 31, 2023

Uh oh!

crespocarlos commented Aug 31, 2023

Uh oh!

crespocarlos commented Aug 31, 2023

Uh oh!

crespocarlos commented Sep 1, 2023

Uh oh!

crespocarlos commented Sep 4, 2023

Uh oh!

crespocarlos commented Sep 6, 2023

Uh oh!

crespocarlos commented Sep 6, 2023

Uh oh!

crespocarlos commented Sep 7, 2023

Uh oh!

tonyghiani commented Sep 7, 2023

Uh oh!

crespocarlos commented Sep 7, 2023

Uh oh!

weltenwort left a comment

Choose a reason for hiding this comment

Uh oh!

MiriamAparicio left a comment

Choose a reason for hiding this comment

Uh oh!

crespocarlos commented Sep 8, 2023

Uh oh!

crespocarlos commented Sep 8, 2023

Uh oh!

kibana-ci commented Sep 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💚 Build Succeeded

Metrics [docs]

Async chunks

Canvas Sharable Runtime

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

crespocarlos commented Aug 31, 2023 •

edited

Loading

kibana-ci commented Sep 8, 2023 •

edited

Loading