[Console] Remove an unused function for "extension" files#161871
Merged
yuliacech merged 1 commit intoelastic:mainfrom Jul 13, 2023
Merged
[Console] Remove an unused function for "extension" files#161871yuliacech merged 1 commit intoelastic:mainfrom
yuliacech merged 1 commit intoelastic:mainfrom
Conversation
yuliacech
added
release_note:breaking
Feature:Console
Contributor
|
Pinging @elastic/platform-deployment-management (Team:Deployment Management) |
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: |
ElenaStoeva
approved these changes
Jul 13, 2023
Contributor
ElenaStoeva
left a comment
ElenaStoeva
left a comment
There was a problem hiding this comment.
Good catch! Thanks for removing this redundancy @yuliacech. LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related to #159041
While working on #161684, I noticed another unused function. There is no usage in the code base of the "extensions" function and I think it would be better to delete it from Console. That makes the remaining code that we need to work with easier to understand.
Release note
The function
addExtensionSpecFilePathis removed from the Console plugin setup contract (server side).