Skip to content

[Console] Remove an unused function for "extension" files #161871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yuliacech merged 1 commit into from
Jul 13, 2023
Merged

[Console] Remove an unused function for "extension" files #161871

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/plugins/console/server/plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,10 +76,6 @@ export class ConsoleServerPlugin implements Plugin<ConsoleSetup, ConsoleStart> {
},
kibanaVersion,
});

return {
...this.specDefinitionsService.setup(),
};
}

start() {
Expand Down
14 changes: 0 additions & 14 deletions src/plugins/console/server/services/spec_definitions_service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ export class SpecDefinitionsService {

private readonly globalRules: Record<string, any> = {};
private readonly endpoints: Record<string, any> = {};
private readonly extensionSpecFilePaths: string[] = [];

private hasLoadedSpec = false;

Expand Down Expand Up @@ -82,16 +81,6 @@ export class SpecDefinitionsService {
};
}

public addExtensionSpecFilePath(path: string) {
this.extensionSpecFilePaths.push(path);
}

public setup() {
return {
addExtensionSpecFilePath: this.addExtensionSpecFilePath.bind(this),
};
}

public start() {
if (!this.hasLoadedSpec) {
this.loadJsonSpec();
Expand Down Expand Up @@ -129,9 +118,6 @@ export class SpecDefinitionsService {

private loadJsonSpec() {
const result = this.loadJSONSpecInDir(AUTOCOMPLETE_DEFINITIONS_FOLDER);
this.extensionSpecFilePaths.forEach((extensionSpecFilePath) => {
merge(result, this.loadJSONSpecInDir(extensionSpecFilePath));
});

Object.keys(result).forEach((endpoint) => {
this.addEndpointDescription(endpoint, result[endpoint]);
Expand Down