Skip to content

[Console] Remove unused function#159041

Merged
yuliacech merged 2 commits intoelastic:mainfrom
yuliacech:console/remove_unused_function
Jun 23, 2023
Merged

[Console] Remove unused function#159041
yuliacech merged 2 commits intoelastic:mainfrom
yuliacech:console/remove_unused_function

Conversation

@yuliacech
Copy link
Copy Markdown
Contributor

@yuliacech yuliacech commented Jun 5, 2023 •
edited
Loading

Summary

While working on #159410, I noticed that there are some unused functions in the Console server side plugin contracts. This PR removes the function addProcessorDefinition from the start contract. I was not able to find any uses of this function in the Kibana code. I believe it might have been planned to be used for ingest processors but currently we use the _processor endpoint for that (see here). And since the tests also pass I think it's safe to remove this function. I'm using the label release_note:breaking because the plugin's contracts are public and theoretically it's possible that there are some external plugins that use that function.

Release note

The function addProcessorDefinition is removed from the Console plugin start contract (server side).

@yuliacech yuliacech added Feature:Console Dev Tools Console Feature Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// release_note:skip Skip the PR/issue when compiling release notes v8.9.0 labels Jun 5, 2023
@yuliacech yuliacech force-pushed the console/remove_unused_function branch from c273f62 to 012422b Compare June 13, 2023 11:38
@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Jun 13, 2023

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #50 / Machine Learning modules "before all" hook in "modules"

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 16 18 +2
securitySolution 410 414 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 17 19 +2
securitySolution 491 495 +4
total +6

History

  • 💔 Build #132624 failed c273f62b87539b6ae16111782e6bc64713db705c

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@yuliacech yuliacech added release_note:breaking and removed release_note:skip Skip the PR/issue when compiling release notes labels Jun 13, 2023
@yuliacech yuliacech marked this pull request as ready for review June 13, 2023 15:58
@yuliacech yuliacech requested a review from a team as a code owner June 13, 2023 15:58
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jun 13, 2023

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

sabarasaba
sabarasaba approved these changes Jun 14, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@sabarasaba sabarasaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes lgtm! Do we have to ping anyone about this possible breaking change for external plugins or just with the label is enough?

@yuliacech
Copy link
Copy Markdown
Contributor Author

yuliacech commented Jun 14, 2023

Thanks a lot for your review, @sabarasaba!
I don't think we know exactly if there are any external plugins that use this function. What I meant is that it's possible to develop plugins for Kibana (docs) and since this function was part of the plugin's contract, so theoretically it's possible that someone is using it. But I think the label should do the trick.
The 8.9 FF is next week so I would wait to merge this PR until 8.10 dev cycle though.

@yuliacech yuliacech added v8.10.0 and removed v8.9.0 labels Jun 14, 2023
@sabarasaba
Copy link
Copy Markdown
Member

sabarasaba commented Jun 14, 2023

Cool! Was just wondering if anyone within elastic has to be notified about it (support?) but if the label works then should be all good!

@yuliacech yuliacech merged commit 87e31ce into elastic:main Jun 23, 2023
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Jun 23, 2023
@yuliacech yuliacech mentioned this pull request Jul 13, 2023
Merged
yuliacech added a commit that referenced this pull request Jul 13, 2023
@yuliacech
[Console] Remove an unused function for "extension" files (#161871)
c36b620 
## Summary
Related to #159041 

While working on #161684, I
noticed another unused function. There is no usage in the code base of
the "extensions" function and I think it would be better to delete it
from Console. That makes the remaining code that we need to work with
easier to understand.

### Release note
The function `addExtensionSpecFilePath` is removed from the Console
plugin setup contract (server side).
@yuliacech yuliacech deleted the console/remove_unused_function branch February 15, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sabarasaba sabarasaba sabarasaba approved these changes

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting Feature:Console Dev Tools Console Feature release_note:breaking Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// v8.10.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yuliacech @kibana-ci @elasticmachine @sabarasaba @kibanamachine