[8.9] Fix publicUrlWarning message related to server.publicBaseUrl (#161091)#161110
Merged
kibanamachine merged 1 commit intoelastic:8.9from Jul 3, 2023
Merged
Conversation
…#161091) Fixes elastic#160909 ## Summary This PR fixes the publicUrlWarning. Some of the URLs such as `context.alertDetailsUrl` and `rule.url` are empty strings if `server.publicBaseUrl` is not configured. <img src="https://github.com/elastic/kibana/assets/12370520/644e9a3e-8545-4b9b-84a9-1402815ac53d" width=300 /> This is where you can see the message if `server.publicBaseUrl` is not configured: |Before|After| |---|---| ||| (cherry picked from commit e9a9f03)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.9:Questions ?
Please refer to the Backport tool documentation