Fix publicUrlWarning message related to server.publicBaseUrl#161091
Merged
maryam-saeidi merged 3 commits intoelastic:mainfrom Jul 3, 2023
Merged
Fix publicUrlWarning message related to server.publicBaseUrl#161091maryam-saeidi merged 3 commits intoelastic:mainfrom
maryam-saeidi merged 3 commits intoelastic:mainfrom
Conversation
maryam-saeidi
added
bug
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
Member
Author
|
Please let me know if I need to do something related to the translation of this message. |
guskovaue
reviewed
Jul 3, 2023
x-pack/plugins/triggers_actions_ui/public/application/lib/validate_params_for_warnings.ts
Show resolved
Hide resolved
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 3, 2023
…#161091) Fixes elastic#160909 ## Summary This PR fixes the publicUrlWarning. Some of the URLs such as `context.alertDetailsUrl` and `rule.url` are empty strings if `server.publicBaseUrl` is not configured. <img src="https://github.com/elastic/kibana/assets/12370520/644e9a3e-8545-4b9b-84a9-1402815ac53d" width=300 /> This is where you can see the message if `server.publicBaseUrl` is not configured: |Before|After| |---|---| ||| (cherry picked from commit e9a9f03)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jul 3, 2023
…161091) (#161110) # Backport This will backport the following commits from `main` to `8.9`: - [Fix publicUrlWarning message related to server.publicBaseUrl (#161091)](#161091) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Maryam Saeidi","email":"maryam.saeidi@elastic.co"},"sourceCommit":{"committedDate":"2023-07-03T14:50:18Z","message":"Fix publicUrlWarning message related to server.publicBaseUrl (#161091)\n\nFixes #160909\r\n\r\n## Summary\r\n\r\nThis PR fixes the publicUrlWarning. Some of the URLs such as\r\n`context.alertDetailsUrl` and `rule.url` are empty strings if\r\n`server.publicBaseUrl` is not configured.\r\n\r\n<img\r\nsrc=\"https://github.com/elastic/kibana/assets/12370520/644e9a3e-8545-4b9b-84a9-1402815ac53d\"\r\nwidth=300 />\r\n\r\nThis is where you can see the message if `server.publicBaseUrl` is not\r\nconfigured:\r\n\r\n|Before|After|\r\n|---|---|\r\n\r\n|||","sha":"e9a9f0396558581f29e34479917c991e81bc49af","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","backport:prev-minor","v8.10.0"],"number":161091,"url":"https://github.com/elastic/kibana/pull/161091","mergeCommit":{"message":"Fix publicUrlWarning message related to server.publicBaseUrl (#161091)\n\nFixes #160909\r\n\r\n## Summary\r\n\r\nThis PR fixes the publicUrlWarning. Some of the URLs such as\r\n`context.alertDetailsUrl` and `rule.url` are empty strings if\r\n`server.publicBaseUrl` is not configured.\r\n\r\n<img\r\nsrc=\"https://github.com/elastic/kibana/assets/12370520/644e9a3e-8545-4b9b-84a9-1402815ac53d\"\r\nwidth=300 />\r\n\r\nThis is where you can see the message if `server.publicBaseUrl` is not\r\nconfigured:\r\n\r\n|Before|After|\r\n|---|---|\r\n\r\n|||","sha":"e9a9f0396558581f29e34479917c991e81bc49af"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/161091","number":161091,"mergeCommit":{"message":"Fix publicUrlWarning message related to server.publicBaseUrl (#161091)\n\nFixes #160909\r\n\r\n## Summary\r\n\r\nThis PR fixes the publicUrlWarning. Some of the URLs such as\r\n`context.alertDetailsUrl` and `rule.url` are empty strings if\r\n`server.publicBaseUrl` is not configured.\r\n\r\n<img\r\nsrc=\"https://github.com/elastic/kibana/assets/12370520/644e9a3e-8545-4b9b-84a9-1402815ac53d\"\r\nwidth=300 />\r\n\r\nThis is where you can see the message if `server.publicBaseUrl` is not\r\nconfigured:\r\n\r\n|Before|After|\r\n|---|---|\r\n\r\n|||","sha":"e9a9f0396558581f29e34479917c991e81bc49af"}}]}] BACKPORT--> Co-authored-by: Maryam Saeidi <maryam.saeidi@elastic.co>
maryam-saeidi
added a commit
that referenced
this pull request
Jul 5, 2023
Related to #161091 ## Summary I learned that when we update a default message, we should manually remove outdated translations. In this PR, I updated the ID and removed outdated translations. I will not backport this PR since the translation for the previous version is already started so I will keep the previous translation for v8.9. Please let me know if there is an issue with this approach.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #160909
Summary
This PR fixes the publicUrlWarning. Some of the URLs such as
context.alertDetailsUrlandrule.urlare empty strings ifserver.publicBaseUrlis not configured.This is where you can see the message if
server.publicBaseUrlis not configured: