Skip to content

[8.9] Fix publicUrlWarning message related to server.publicBaseUrl (#161091) #161110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kibanamachine merged 1 commit into from
Jul 3, 2023
Merged

[8.9] Fix publicUrlWarning message related to server.publicBaseUrl (#161091) #161110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...k/plugins/triggers_actions_ui/public/application/lib/validate_params_for_warnings.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@ describe('validateParamsForWarnings', () => {
];

test('returns warnings when publicUrl is not set and there are publicUrl variables used', () => {
const warning = 'server.publicBaseUrl is not set. Actions will use relative URLs.';
const warning =
'server.publicBaseUrl is not set. Generated URLs will be either relative or empty.';
expect(
validateParamsForWarnings('Test for {{context.url}}', undefined, actionVariables)
).toEqual(warning);
Expand Down
3 changes: 2 additions & 1 deletion x-pack/plugins/triggers_actions_ui/public/application/lib/validate_params_for_warnings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@ import Mustache from 'mustache';
const publicUrlWarning = i18n.translate(
'xpack.triggersActionsUI.sections.actionTypeForm.warning.publicUrl',
{
defaultMessage: 'server.publicBaseUrl is not set. Actions will use relative URLs.',
defaultMessage:
'server.publicBaseUrl is not set. Generated URLs will be either relative or empty.',
}
);

Expand Down