Skip to content

[Console] Remove unused function #159041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yuliacech merged 2 commits into from
Jun 23, 2023
Merged

[Console] Remove unused function #159041

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
012422b
[Console] Remove unused function
yuliacech Jun 5, 2023
d452fbc
[Console] Fix plugins start
yuliacech Jun 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/plugins/console/server/plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,9 +83,7 @@ export class ConsoleServerPlugin implements Plugin<ConsoleSetup, ConsoleStart> {
}

start() {
return {
...this.specDefinitionsService.start(),
};
this.specDefinitionsService.start();
}

stop() {
Expand Down
12 changes: 0 additions & 12 deletions src/plugins/console/server/services/spec_definitions_service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,15 +87,6 @@ export class SpecDefinitionsService {
this.extensionSpecFilePaths.push(path);
}

public addProcessorDefinition(processor: unknown) {
if (!this.hasLoadedSpec) {
throw new Error(
'Cannot add a processor definition because spec definitions have not loaded!'
);
}
this.endpoints._processor!.data_autocomplete_rules.__one_of.push(processor);
}

public setup() {
return {
addExtensionSpecFilePath: this.addExtensionSpecFilePath.bind(this),
Expand All @@ -107,9 +98,6 @@ export class SpecDefinitionsService {
this.loadJsonSpec();
this.loadJSSpec();
this.hasLoadedSpec = true;
return {
addProcessorDefinition: this.addProcessorDefinition.bind(this),
};
} else {
throw new Error('Service has already started!');
}
Expand Down