Skip to content

[Security Solution] add expandable flyout investigation section#153807

Merged
PhilippeOberti merged 1 commit intomainfrom
expdanded-flyout-6070
Apr 4, 2023
Merged

[Security Solution] add expandable flyout investigation section#153807
PhilippeOberti merged 1 commit intomainfrom
expdanded-flyout-6070

Conversation

@PhilippeOberti
Copy link
Copy Markdown
Contributor

@PhilippeOberti PhilippeOberti commented Mar 27, 2023

Summary

This previous PR added the Highlighted Fields component to the expandable flyout right section overview tab. The mocks have slightly changed and the Highlighted Fields are now displayed under the Investigation expandable section.

This PR covers the following

  • create new Investigation section
  • move highlighted fields inside investigation section

How to test

  • add xpack.securitySolution.enableExperimental: ['securityFlyoutEnabled'] to the kibana.json file
  • run yarn es snapshot --license trial, yarn test:generate and yarn start --no-base-path
  • go to the Alerts page, and click on the expand detail button on any row of the table
  • navigate to the Overview tab

Run tests and storybook

  • node scripts/storybook security_solution to run Storybook
  • npm run test:jest --config ./x-pack/plugins/security_solution/public/flyout to run the unit tests
  • yarn cypress:open-as-ci but note that the integration/e2e tests have been written but are now skipped because the feature is protected behind a feature flag, disabled by default. To check them, add 'securityFlyoutEnabled' here

Screenshot 2023-03-27 at 2 15 19 PM

https://github.com/elastic/security-team/issues/6070

Checklist

@PhilippeOberti PhilippeOberti added Team:Threat Hunting Security Solution Threat Hunting Team Team:Threat Hunting:Investigations Security Solution Threat Hunting Investigations Team v8.8.0 labels Mar 27, 2023
@PhilippeOberti PhilippeOberti requested review from a team as code owners March 27, 2023 19:18
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

- move highlighted fields inside investigation section
@kibana-ci
Copy link
Copy Markdown

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 3804 3805 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 15.8MB 15.8MB +1.4KB
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 432 435 +3

Total ESLint disabled count

id before after diff
securitySolution 512 515 +3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Copy Markdown
Contributor

@christineweng christineweng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Desk tested and LGTM 🚀

/**
* Boolean to allow the component to be expanded or collapsed on first render
*/
expanded?: boolean;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor Author

@PhilippeOberti PhilippeOberti Apr 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

like I answered here, I like having the props colocated with the component, and I prefer writing identical ones instead of sharing them... Would you be opposed to that?

@PhilippeOberti PhilippeOberti merged commit ee72588 into main Apr 4, 2023
@PhilippeOberti PhilippeOberti deleted the expdanded-flyout-6070 branch April 4, 2023 15:53
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:feature Makes this part of the condensed release notes Team:Threat Hunting:Investigations Security Solution Threat Hunting Investigations Team Team:Threat Hunting Security Solution Threat Hunting Team v8.8.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants