[Security Solution] add expandable flyout investigation section#153807
[Security Solution] add expandable flyout investigation section#153807PhilippeOberti merged 1 commit intomainfrom
Conversation
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
- move highlighted fields inside investigation section
2a4d71c to
4ce2b46
Compare
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
christineweng
left a comment
There was a problem hiding this comment.
Desk tested and LGTM 🚀
...urity_solution/cypress/e2e/detection_alerts/expandable_flyout/alert_details_left_panel.cy.ts
Show resolved
Hide resolved
| /** | ||
| * Boolean to allow the component to be expanded or collapsed on first render | ||
| */ | ||
| expanded?: boolean; |
There was a problem hiding this comment.
I created OverviewSectionProps here https://github.com/elastic/kibana/pull/154196/files#diff-281670d8d141832d8cdf6812a535538b36c45e77e20ed0e06360907e55d305d8R11 maybe we can reuse this?
There was a problem hiding this comment.
like I answered here, I like having the props colocated with the component, and I prefer writing identical ones instead of sharing them... Would you be opposed to that?
Summary
This previous PR added the Highlighted Fields component to the expandable flyout right section overview tab. The mocks have slightly changed and the Highlighted Fields are now displayed under the Investigation expandable section.
This PR covers the following
How to test
xpack.securitySolution.enableExperimental: ['securityFlyoutEnabled']to thekibana.jsonfileyarn es snapshot --license trial,yarn test:generateandyarn start --no-base-pathRun tests and storybook
node scripts/storybook security_solutionto run Storybooknpm run test:jest --config ./x-pack/plugins/security_solution/public/flyoutto run the unit testsyarn cypress:open-as-cibut note that the integration/e2e tests have been written but are now skipped because the feature is protected behind a feature flag, disabled by default. To check them, add'securityFlyoutEnabled'herehttps://github.com/elastic/security-team/issues/6070
Checklist