[Security Solution] add highlighted fields to overview tab#153074
Merged
PhilippeOberti merged 2 commits intomainfrom Mar 21, 2023
Merged
[Security Solution] add highlighted fields to overview tab#153074PhilippeOberti merged 2 commits intomainfrom
PhilippeOberti merged 2 commits intomainfrom
Conversation
PhilippeOberti
force-pushed
the
expanded-flyout-6070
branch
from
6a3ac26 to
8dacf48
Compare
PhilippeOberti
added
Team:Threat Hunting
Contributor
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
lgestc
approved these changes
Mar 21, 2023
Contributor
lgestc
left a comment
lgestc
left a comment
There was a problem hiding this comment.
lgtm, I think you missed that TODO I commented on:)
|
|
||
| // TODO enable when the table tab PR is merged | ||
| // https://github.com/elastic/kibana/pull/152303 | ||
| it.skip('should navigate to table tab when clicking on highlighted fields view button', () => { |
Contributor
Author
There was a problem hiding this comment.
yes that's correct, skip removed!
Comment on lines
+41
to
+50
| const { getByTestId } = render( | ||
| <ThemeProvider theme={mockTheme}> | ||
| <ExpandableFlyoutContext.Provider value={flyoutContextValue}> | ||
| <RightPanelContext.Provider value={panelContextValue}> | ||
| <HighlightedFields /> | ||
| </RightPanelContext.Provider> | ||
| </ExpandableFlyoutContext.Provider> | ||
| </ThemeProvider> | ||
| ); | ||
|
|
Contributor
There was a problem hiding this comment.
just a nitpick but maybe this can be extracted into some helper on top of this file, looks like it only changes a little bit in between tests
Contributor
Author
There was a problem hiding this comment.
that's a good point! To not slow down development (there is still a lot to do) I logged a tech debt ticket for this (I also have one for some Storybook cleanup)
PhilippeOberti
force-pushed
the
expanded-flyout-6070
branch
from
8dacf48 to
6dc8491
Compare
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
4 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR leverages the work done in a previous PR and add the Highlighted Fields section under the overview tab of the Security Solution expandable flyout right section panel:
AlertSummaryViewcomponentdataFormattedForFieldBrowserorbrowserFieldsare nullHow to test
xpack.securitySolution.enableExperimental: ['securityFlyoutEnabled']to thekibana.jsonfileyarn es snapshot --license trial,yarn test:generateandyarn start --no-base-pathRun tests and storybook
node scripts/storybook security_solutionto run Storybooknpm run test:jest --config ./x-pack/plugins/security_solution/public/flyoutto run the unit testsyarn cypress:open-as-cibut note that the integration/e2e tests have been written but are now skipped because the feature is protected behind a feature flag, disabled by default. To check them, add'securityFlyoutEnabled'hereNotes:
Screen.Recording.2023-03-09.at.8.43.57.PM.mov
https://github.com/elastic/security-team/issues/6070
Checklist
Delete any items that are not applicable to this PR.